Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
orpiske merged PR #15083: URL: https://github.com/apache/camel/pull/15083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
orpiske commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2278113298 Changes done. Let's merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
orpiske commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277997595 Let's mark this one as a draft. Later I'll take a look at the public classes we should deprecate. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
davsclaus commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277990316 Ah okay its a data format, so its a good idea to add `@Deprecated` to its model definition classes, so its also marked as deprecated in the DSL and in catalog and so on. So there is a b

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
davsclaus commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277985392 No its fine just to mark the component as deprecated as Otavio do. No need to do more. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
apupier commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277981583 Also shouldn't we mark all public classes as Deprecated inside this module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
apupier commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277972472 Shouldn't it be added to the migration guide? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
orpiske opened a new pull request, #15083: URL: https://github.com/apache/camel/pull/15083 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] CAMEL-21067: marked camel-univocity as deprecated [camel]

2024-08-09 Thread via GitHub
github-actions[bot] commented on PR #15083: URL: https://github.com/apache/camel/pull/15083#issuecomment-2277946367 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer