Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-08-05 Thread via GitHub
orpiske merged PR #14972: URL: https://github.com/apache/camel/pull/14972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-08-01 Thread via GitHub
oscerd commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2264692305 This looks good to me, we just need to apply the same logic everywhere. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
essobedo commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2262159328 Good to know, thank you @orpiske -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
orpiske commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2262149237 FYI, I've looked at the test results and they are looking great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
essobedo commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2260429193 I just wanted to add that if we have to choose between synchronized blocks and locks according to the situation, we need to be very careful during the review of each PR that adds new syn

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
essobedo commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2259940339 > Hi @essobedo, I'll take a quick look at it and I'll trigger a full test on my CI. I won't be able to post the results today, though. Hi @orpiske, it sounds great thank you --

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
orpiske commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2259938509 Hi @essobedo, I'll take a quick look at it and I'll trigger a full test on my CI. I won't be able to post the results today, though. -- This is an automated message from the Apache Git

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-31 Thread via GitHub
essobedo commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2259924026 Hi, is there anybody that could review this PR? Thank you in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #14972: URL: https://github.com/apache/camel/pull/14972#issuecomment-2258571635 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] CAMEL-20199: camel-core - Remove synchronized blocks [camel]

2024-07-30 Thread via GitHub
essobedo opened a new pull request, #14972: URL: https://github.com/apache/camel/pull/14972 Related to https://issues.apache.org/jira/browse/CAMEL-20199 # Description For better support of virtual threads, we need to avoid lengthy and frequent pinning by replacing synchronized