CodeSmell commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1813006721
Will add another PR with this for consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
CodeSmell closed pull request #11960: CAMEL-20044 Removing the lastResult used
in breakOnFirstError
URL: https://github.com/apache/camel/pull/11960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1806760897
:no_entry_sign: There are (likely) no changes in core core to be tested in
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
github-actions[bot] commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1806760893
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated me
orpiske commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1805394448
Attaching test logs from Github.
[components-camel-kafka.log](https://github.com/apache/camel/files/13317865/components-camel-kafka.log)
--
This is an automated message from
github-actions[bot] commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1805372972
:no_entry_sign: There are (likely) no changes in core core to be tested in
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
github-actions[bot] commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1805372950
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated me
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388495185
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##
@@ -126,7 +129,7 @@ private ProcessingRe
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388494228
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##
@@ -54,49 +54,53 @@ private boolean isSt
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388496205
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -297,6 +297,7 @@ private void subscribe() {
}
prote
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388496205
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##
@@ -297,6 +297,7 @@ private void subscribe() {
}
prote
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388494228
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##
@@ -54,49 +54,53 @@ private boolean isSt
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388495185
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##
@@ -126,7 +129,7 @@ private ProcessingRe
CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388494228
##
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##
@@ -54,49 +54,53 @@ private boolean isSt
github-actions[bot] commented on PR #11960:
URL: https://github.com/apache/camel/pull/11960#issuecomment-1804463230
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested
automatically**.
CodeSmell opened a new pull request, #11960:
URL: https://github.com/apache/camel/pull/11960
# Description
This PR is dependent on https://github.com/apache/camel/pull/11959
It shows that we can remove the `lastResult` from the code if we go with the
proposed changes
# Targe
16 matches
Mail list logo
