orpiske merged PR #11870:
URL: https://github.com/apache/camel/pull/11870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apac
orpiske commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1792572841
Thanks! Let's get this one in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
oscerd commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1792570998
For me it's +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
orpiske commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1792568385
Hey @oscerd, any other comments here? Otherwise I'll merge ... it would be
good to have this one for 4.2.
--
This is an automated message from the Apache Git Service.
To respond to the
orpiske commented on code in PR #11870:
URL: https://github.com/apache/camel/pull/11870#discussion_r1380465715
##
parent/pom.xml:
##
@@ -952,6 +953,11 @@
camel-chunk
${project.version}
+
+org.apache.came
orpiske commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1791149555
> I don't think camel-cifs is supposed to be listed
Thanks for the great review! I think I removed all references to the old
name of this component.
--
This is an automated mess
orpiske commented on code in PR #11870:
URL: https://github.com/apache/camel/pull/11870#discussion_r1380468150
##
components/camel-smb/src/main/resources/META-INF/services/org/apache/camel/component/smb:
##
@@ -0,0 +1 @@
+class=org.apache.camel.component.cifs.SmbComponent
Revie
orpiske commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1791052491
Looking OK now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
oscerd commented on code in PR #11870:
URL: https://github.com/apache/camel/pull/11870#discussion_r1380415303
##
parent/pom.xml:
##
@@ -952,6 +953,11 @@
camel-chunk
${project.version}
+
+org.apache.camel
orpiske commented on PR #11870:
URL: https://github.com/apache/camel/pull/11870#issuecomment-1790254208
Marking as draft again. There's a valid test error I need to fix when I get
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
10 matches
Mail list logo
