Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
jamesnetherton merged PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1572044860 ## extensions/wasm/runtime/src/main/resources/META-INF/quarkus-extension.yaml: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1572018004 ## integration-tests/wasm/rust/build.sh: ## @@ -0,0 +1,25 @@ +#! /bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# cont

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1572019366 ## extensions/wasm/runtime/src/main/resources/META-INF/quarkus-extension.yaml: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571978507 ## extensions/wasm/runtime/src/main/resources/META-INF/quarkus-extension.yaml: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-19 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571931044 ## extensions/wasm/runtime/src/main/resources/META-INF/quarkus-extension.yaml: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
lburgazzoli commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571919535 ## extensions/wasm/runtime/src/main/resources/META-INF/quarkus-extension.yaml: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571898760 ## integration-tests/wasm/rust/build.sh: ## @@ -0,0 +1,25 @@ +#! /bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# cont

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571891689 ## integration-tests/wasm/rust/Cargo.lock: ## Review Comment: OK, I get it. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571892988 ## integration-tests/wasm/rust/build.sh: ## @@ -0,0 +1,25 @@ +#! /bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571888310 ## integration-tests/wasm/rust/Cargo.lock: ## Review Comment: Yeah - it's like package.lock in the JavaScript world or go.sum with Go. It records the

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571884836 ## integration-tests/wasm/rust/Cargo.lock: ## Review Comment: I don't understand. It is used by Cargo to do the rust build, is it right? -- This is an aut

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
jamesnetherton commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571880454 ## integration-tests/wasm/rust/Cargo.lock: ## Review Comment: Depends if we want reproducable builds I guess. -- This is an automated message from

Re: [PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
zhfeng commented on code in PR #6012: URL: https://github.com/apache/camel-quarkus/pull/6012#discussion_r1571876499 ## integration-tests/wasm/rust/Cargo.lock: ## Review Comment: This file is really needed? I think it might be removed. -- This is an automated message fro

[PR] Add Wasm extension [camel-quarkus]

2024-04-18 Thread via GitHub
jamesnetherton opened a new pull request, #6012: URL: https://github.com/apache/camel-quarkus/pull/6012 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu