Re: [I] Knative installation check is wrong [camel-k]

2024-01-08 Thread via GitHub
squakez closed issue #4962: Knative installation check is wrong URL: https://github.com/apache/camel-k/issues/4962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Knative installation check is wrong [camel-k]

2023-12-27 Thread via GitHub
eshepelyuk commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1870608878 Hi all I am seeing the same error, jfyi. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Knative installation check is wrong [camel-k]

2023-12-05 Thread via GitHub
claudio4j commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1841496668 We should probably add the eventing to https://github.com/apache/camel-k/blob/main/pkg/util/knative/apis.go#L138 -- This is an automated message from the Apache Git Service. To r

Re: [I] Knative installation check is wrong [camel-k]

2023-12-05 Thread via GitHub
matzew commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1840232557 > one more thing. please be careful to reference my fork (christophd) of the camel-k repository 😄 it might not be up-to-date all the time Oh, I have not noticed this - I came th

Re: [I] Knative installation check is wrong [camel-k]

2023-12-05 Thread via GitHub
christophd commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1840223807 thanks @matzew! yes, makes sense we should improve the Knative installation check one more thing. please be careful to reference my fork (christophd) of the camel-k reposit

Re: [I] Knative installation check is wrong [camel-k]

2023-12-04 Thread via GitHub
matzew commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1840199084 (of course installing serving "fixes" it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Knative installation check is wrong [camel-k]

2023-12-04 Thread via GitHub
matzew commented on issue #4962: URL: https://github.com/apache/camel-k/issues/4962#issuecomment-1840192536 I guess it is better to just resolve the "addressable", for the sink address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Knative installation check is wrong [camel-k]

2023-12-04 Thread via GitHub
matzew opened a new issue, #4962: URL: https://github.com/apache/camel-k/issues/4962 ### What happened? I have Knative Eventing installed, but b/c of how the code is written, the `knative.IsInstalled` check in `knative_ref.go` is returning `false` https://github.com/christophd/ca