Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2020-01-07 Thread Manoj Srivastava
Progress report: I have managed to get the underlying data-structures mostly changed, I am in the process of modifying the write plugins to deal with having since source ,etric data with labels instead of the multi-source value_list_t. > git diffstat master Makefile.am

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-12-04 Thread Manoj Srivastava
Added another commit along the way: [metric-label-support]: Modify write queue to use metric_t This commit adds an updated write queue data structure, and updates the enqueue and dequeue calling paths. Note that while this compiles and the tests pass, thisis not a functioning collectd by itself,

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-12-02 Thread Manoj Srivastava
Added a commit with utility functions for cloning and freeing the new metric, identity and metadata list head data structures that will be used by the helper functions that enqueue and dequeue from the the future new write queue. I have that mostly code complete, and am writing unit tests for the n

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-11-27 Thread Matthias Runge
Hi Manoj, thank you for the heads-up here. This is a great achievement. A tiny typo, your repo is this one https://github.com/srivasta/collectd/tree/metric-label-support Matthias On 25/11/2019 23:07, Manoj Srivastava wrote: > Hi, > >   I have implemented a mechanism to convert from the current

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-11-25 Thread Manoj Srivastava
Hi, I have implemented a mechanism to convert from the current values_list_t metric representation to the new metric_list_t representation. This method can be called from write_queue_enque method to convert metric data from unmigrated read plugins to provide for a backward compatible transition

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-10-09 Thread Manoj Srivastava
Hi, I have an initial design proposal on how to convert from a value_list_t format to the new, single data source metrics_t format for metrics at https://docs.google.com/document/d/1B4drbdkPoXvMFrBx57cnKtDgeehQ1zkptq9Ozx7MnG8/edit?usp=sharing Comments appreciated. Manoj On Mon, Sep 30, 20

Re: [collectd] [Feature Request/Version 6.0]: Adding Labels to Collectd Metrics #3094

2019-09-30 Thread Manoj Srivastava
Hi, I have an initial stalking horse commit based on the 5.9 branch that implements the data structures in the design docs, and has unit tests to the avl tree used in the structures. I think we need some discussion on how to convert the current value_list_t 5-tupples --> name + labels structur