[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Florian Bruhin
Hey, On Fri, Sep 18, 2020 at 05:55:29PM -0400, Ahmed Hassan wrote: > Does anyone know an open source tool that checks PR before merge for code > quality? I'm looking for something similar to code climate or codacy. I > don't want to hook a Jenkins job that makes the usability of Pylint harder. Wh

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Ahmed Hassan
Thanks Thomas, I will try that. That's my next option. @Florian: Pylint itself is perfectly fine. However, I want to see all the pylint issues to be shown within the PR instead of another console. Also, I don't want to run pylint on the whole file, I want to run it only on the code that was added.

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Florian Bruhin
Hey again, On Mon, Sep 21, 2020 at 07:15:09AM -0400, Ahmed Hassan wrote: > However, I want to see all the pylint issues to be shown within the PR > instead of another console. You can do that by registering a "problem matcher" file with GitHub Actions, which defines a regex to parse the console o

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Martin Vielsmaier
Hi, On 21.09.20 13:15, Ahmed Hassan wrote: @Florian: Pylint itself is perfectly fine. However, I want to see all the pylint issues to be shown within the PR instead of another console. Also, I don't want to run pylint on the whole file, I want to run it only on the code that was added. There

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Ahmed Hassan
@Florian: I think I will endup building my own opensource tool. @Martin, I'm not looking for commercial solutions. Most of the SaaS tools I have seen are half-assed. I can just hook up pylint with the CI server, and pre-commit before merging. Thanks to everyone who responded to me. On Mon, Sep 21

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread hirainchen
You can have a look at diff-cover(https://diff-cover.readthedocs.io/en/latest/README.html), it can find diff lines that have violations (according to tools such as pep8, pyflakes, flake8, or pylint). Original Message Sender: Ahmed Hassan Recipient: Florian Bruhin Cc: code-quality Date: Monda

[code-quality] Re: pip install astroid 2.1.0 problems

2020-09-21 Thread Florian Bruhin
Hey, Sorry for the very late answer, but if you're still having this issue: On Mon, Aug 24, 2020 at 10:28:36PM +, Reid Karabush wrote: > [...] > Retrying (Retry(total=0, connect=None, read=None, redirect=None, > status=None)) after connection broken by > 'NewConnectionError(' object at 0x

[code-quality] Re: What are the best tools for code quality checks to use within Github?

2020-09-21 Thread Marius Gedminas
On Mon, Sep 21, 2020 at 07:15:09AM -0400, Ahmed Hassan wrote: > @Florian: Pylint itself is perfectly fine. However, I want to see all the > pylint issues to be shown within the PR instead of another console. Also, I > don't want to run pylint on the whole file, I want to run it only on the code > t