Re: [CMake] patch proposal for PythonInterp

2013-04-15 Thread Yngve Inntjore Levinsen
On 12. april 2013 18:45, Rolf Eike Beer wrote: > Yes, I will take a look. So far it looks not too bad. Yngve, please make the > changes Brad requested and squash both patches together so I need to review > only those changes that you really intend to do. Done: https://gitorious.org/eothred/cmake/

Re: [CMake] patch proposal for PythonInterp

2013-04-12 Thread Rolf Eike Beer
Brad King wrote: > On 04/11/2013 04:05 PM, Yngve Inntjore Levinsen wrote: > > On 11. april 2013 21:31, Matthew Woehlke wrote: > >>> Where do I submit the merge request? Open a bug report? > >> > >> I would recommend following the 'share a topic' instructions at > >> http://www.cmake.org/Wiki/CMake

Re: [CMake] patch proposal for PythonInterp

2013-04-12 Thread Brad King
On 04/11/2013 04:05 PM, Yngve Inntjore Levinsen wrote: > On 11. april 2013 21:31, Matthew Woehlke wrote: >>> Where do I submit the merge request? Open a bug report? >> >> I would recommend following the 'share a topic' instructions at >> http://www.cmake.org/Wiki/CMake/Git/Develop. > > Thanks for

Re: [CMake] patch proposal for PythonInterp

2013-04-11 Thread Yngve Inntjore Levinsen
On 11. april 2013 21:31, Matthew Woehlke wrote: >> Where do I submit the merge request? Open a bug report? > > I would recommend following the 'share a topic' instructions at > http://www.cmake.org/Wiki/CMake/Git/Develop. Thanks for the link, but I feel this is more for module keepers, and this i

Re: [CMake] patch proposal for PythonInterp

2013-04-11 Thread Matthew Woehlke
Matthew On 2013-04-11 14:58, Yngve Inntjore Levinsen wrote: I have now finished a patch which I am quite sure does not break old logic, while fixing this problem. It should be said that I know little about code conventions and it is perhaps not as pretty as it could be, so please feel free to c

Re: [CMake] patch proposal for PythonInterp

2013-04-11 Thread Yngve Inntjore Levinsen
On 21. mars 2013 18:30, Rolf Eike Beer wrote: > Yngve Inntjore Levinsen wrote: >> > On 21. mars 2013 12:00, Rolf Eike Beer wrote: >>> > > Am 21.03.2013 11:03, schrieb Yngve Inntjore Levinsen: > >> Hi, > >> > >> I have a suggestion for the PythonInterp. On a system I am compiling >>

Re: [CMake] patch proposal for PythonInterp

2013-03-21 Thread Rolf Eike Beer
Yngve Inntjore Levinsen wrote: > On 21. mars 2013 12:00, Rolf Eike Beer wrote: > > Am 21.03.2013 11:03, schrieb Yngve Inntjore Levinsen: > >> Hi, > >> > >> I have a suggestion for the PythonInterp. On a system I am compiling my > >> code on, I need to find the python binary which is newer than 2.5

Re: [CMake] patch proposal for PythonInterp

2013-03-21 Thread Yngve Inntjore Levinsen
On 21. mars 2013 12:00, Rolf Eike Beer wrote: > Am 21.03.2013 11:03, schrieb Yngve Inntjore Levinsen: >> Hi, >> >> I have a suggestion for the PythonInterp. On a system I am compiling my >> code on, I need to find the python binary which is newer than 2.5. >> However, the default /usr/bin/python is

Re: [CMake] patch proposal for PythonInterp

2013-03-21 Thread Rolf Eike Beer
Am 21.03.2013 11:03, schrieb Yngve Inntjore Levinsen: Hi, I have a suggestion for the PythonInterp. On a system I am compiling my code on, I need to find the python binary which is newer than 2.5. However, the default /usr/bin/python is 2.4. If I then set the variable (which is not documented

[CMake] patch proposal for PythonInterp

2013-03-21 Thread Yngve Inntjore Levinsen
Hi, I have a suggestion for the PythonInterp. On a system I am compiling my code on, I need to find the python binary which is newer than 2.5. However, the default /usr/bin/python is 2.4. If I then set the variable (which is not documented in the header by the way) PythonInterp_FIND_VERSION to 2.