Re: [CMake] FindX11.cmake needs some work for 2.6.0

2008-04-17 Thread Alan W. Irwin
On 2008-04-14 15:56-0700 Alan W. Irwin wrote: Furthermore, making X11_LIBRARIES fullpath would benefit the PLplot build (and presumably other builds as well). When first setting up the CMake-based build system for PLplot, I either copied from our previous autotools-based build system or I may ha

Re: [CMake] FindX11.cmake needs some work for 2.6.0

2008-04-15 Thread Bill Hoffman
Alan W. Irwin wrote: You should never use -L directly (in TARGET_LINK_LIBRARIES) . link_directories should be used. Our use case is we have a large number of libraries and plugins, but only four of those (IIRC) use X11_LIBRARIES. I prefer to use -L directly in TARGET_LINK_LIBRARIES rath

Re: [CMake] FindX11.cmake needs some work for 2.6.0

2008-04-14 Thread Alan W. Irwin
On 2008-04-14 21:55-0400 Bill Hoffman wrote: Alan W. Irwin wrote: On some platforms, X11_LIBRARIES derived by FindX11.cmake is going to be a mixture of full pathnames for libraries and a series of -l flags which is not a recommended form for CMake 2.6.x. To see this, look at the FindX11.cmake

Re: [CMake] FindX11.cmake needs some work for 2.6.0

2008-04-14 Thread Bill Hoffman
Alan W. Irwin wrote: On some platforms, X11_LIBRARIES derived by FindX11.cmake is going to be a mixture of full pathnames for libraries and a series of -l flags which is not a recommended form for CMake 2.6.x. To see this, look at the FindX11.cmake logic for CMake-2.6.0-RC-8. OK, -l flags ar

[CMake] FindX11.cmake needs some work for 2.6.0

2008-04-14 Thread Alan W. Irwin
On some platforms, X11_LIBRARIES derived by FindX11.cmake is going to be a mixture of full pathnames for libraries and a series of -l flags which is not a recommended form for CMake 2.6.x. To see this, look at the FindX11.cmake logic for CMake-2.6.0-RC-8. The preliminary version of X11_LIBRARIES