Re: [CMake] Building arguments to target_comple_definitions()

2018-10-12 Thread Chuck Atkins
> So in CMake parlance, what type is the last argument to > target_compile_definitions? Is it a list, string or something else? > It's a series of VISIBILITY_SPECIFIER DEF1 DEF2 ... DEFN, so the visibility specifier followed by a list of definitions, optionally followed by another visibility spec

Re: [CMake] Putting the git commit hash in a cmake variable

2018-10-12 Thread Ben Boeckel
Sorry if this shows up oddly on the list; I was forwarded the original in order to reply. As such, please keep me in Cc. > I'd like to set a CMake variable to the current git commit short hash. > This variable will be used as part of the version string for my > project (ex: "1.0.1+git.${SHORT_HASH

Re: [CMake] Controlling order of includes with INTERFACE_INCLUDE_DIRECTORIES for an IMPORTED target

2018-10-12 Thread David Jobet
> what version of CMake are you using? I'm using cmake version 3.10.0. > Which seems at odds with your observations/comments, unless I'm > misunderstanding what you're saying. Well, what's for sure is that the above invocation does not compile, but if at our root CMakeLists.txt we add include_dir

Re: [CMake] Controlling order of includes with INTERFACE_INCLUDE_DIRECTORIES for an IMPORTED target

2018-10-12 Thread Craig Scott
On Fri, Oct 12, 2018 at 6:42 PM David Jobet wrote: > Hello, > > we embed in our source a copy of an ICC build of LLVM, that we import : > > add_library(global_llvm_external STATIC IMPORTED) > set_property(TARGET global_llvm_external APPEND PROPERTY > INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_CURRENT_

[CMake] Controlling order of includes with INTERFACE_INCLUDE_DIRECTORIES for an IMPORTED target

2018-10-12 Thread David Jobet
Hello, we embed in our source a copy of an ICC build of LLVM, that we import : add_library(global_llvm_external STATIC IMPORTED) set_property(TARGET global_llvm_external APPEND PROPERTY INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_CURRENT_SOURCE_DIR}/icc/include) set_property(TARGET global_llvm_external

Re: [CMake] Putting the git commit hash in a cmake variable

2018-10-12 Thread Elvis Stansvik
Den fre 12 okt. 2018 00:24Matt Schulte skrev: > Ah, that's a good tip Elvis. The CONFIGURE_DEPENDS on the .git/index > would do the trick. I can set that up for now. > > In the long run, its not that ideal because it forces a reconfigure on > every commit (which is annoying for developers at thei