[CMake] are target_compile_definitions not transitive in cmake 3.12.1?

2018-08-30 Thread Mario Emmenlauer
Sorry if this has been discussed before, I searched the mailing list and google but could not find this exact issue (only [1] and [2] that refer to library dependencies). I have a case where it seems target_compile_definitions() is not transitive (it is not passed down via libraries), is that pos

Re: [CMake] find_package with COMPONENTS never honors REQUIRED

2018-08-30 Thread Eric Noulard
Le jeu. 30 août 2018 à 20:03, George PF a écrit : > > The documentation is intriguing about REQUIRED COMPONENTS interaction > > That's... one way to put it. > Yeah you know. Kind of ironic here :-) > > So it is possible that the failure behavior when specifying COMPONENTS > is up to the mo

Re: [CMake] find_package with COMPONENTS never honors REQUIRED

2018-08-30 Thread George PF
> The documentation is intriguing about REQUIRED COMPONENTS interaction That's... one way to put it. > "A package-specific list of required components may be listed after the > ``COMPONENTS`` option (or after the ``REQUIRED`` option if present). > Additional optional components may be listed

Re: [CMake] find_package with COMPONENTS never honors REQUIRED

2018-08-30 Thread Eric Noulard
Le jeu. 30 août 2018 à 18:01, George PF a écrit : > Hi, > > once COMPONENTS is added to a find_package statement, any REQUIRED > statement ceases to have an effect: > > cmake_minimum_required(VERSION 3.12) > > # find_package(FailsCorrectly REQUIRED) > > find_package(Qt REQUIRED COMPON

[CMake] find_package with COMPONENTS never honors REQUIRED

2018-08-30 Thread George PF
Hi, once COMPONENTS is added to a find_package statement, any REQUIRED statement ceases to have an effect: cmake_minimum_required(VERSION 3.12) # find_package(FailsCorrectly REQUIRED) find_package(Qt REQUIRED COMPONENTS REQUIRED Qt5XYZ REQUIRED) find_package(Qt REQUIRED COM

Re: [CMake] Specify extra files for display in IDE

2018-08-30 Thread Daniel Eiband
Hi Eric, Thank you for your answers! Visual Studio supports the source_group command, but it cannot be used to add sources. It only controls where source files of targets are displayed. > I do very often add non source file (like README.md) to any targets This is what I also do for non-b

Re: [CMake] Build flags not applied during compiler testing on Ubuntu

2018-08-30 Thread Richard Shaw
On Mon, Aug 27, 2018 at 12:43 PM Brad King wrote: > On 08/25/2018 05:48 PM, Richard Shaw wrote: > > set(CMAKE_EXE_LINKER_FLAGS "-T${CMAKE_SOURCE_DIR}/stm32_flash.ld") > > > > The build dir is the binary directory, not the source directory... > > Toolchain files cannot reference variables like CMA

Re: [CMake] Specify extra files for display in IDE

2018-08-30 Thread Eric Noulard
Le jeu. 30 août 2018 à 12:32, Daniel Eiband a écrit : > Hi, > > > > I’m currently migrating a code base from a proprietary MSBuild based > generator to CMake 3.11 which is shipped with Visual Studio. There are two > aspects to this task: > > > > 1) Integration of custom build steps > > 2) Present

[CMake] Specify extra files for display in IDE

2018-08-30 Thread Daniel Eiband
Hi, I'm currently migrating a code base from a proprietary MSBuild based generator to CMake 3.11 which is shipped with Visual Studio. There are two aspects to this task: 1) Integration of custom build steps 2) Presentation in the IDE The first aspect of integrating all of our custom build step