[CMake] FindPythonLibs patches for version searching and frameworks

2015-09-14 Thread David Gobbi
Hi All, I've attached three suggested patches for cmake. The first is trivial, it simply adds Python 3.5 and 3.6 to the search list. The second removes the long-deprecated PYTHON_INCLUDE_PATH as a suggestion for PYTHON_INCLUDE_DIR. The third does two important things: 1) it fixes bugs for searc

Re: [CMake] fixup_bundles on macosx for non-.app target

2015-09-14 Thread Michael Jackson
Sorry for the delay. https://github.com/dream3d/DREAM3D/tree/develop/Support/cmp/OSX_Tools the CompleteTool.cmake.in calls the CompleteTool.sh.in files through a custom cmake command after they are "Configured" through "configure_file". I think you can figure out what is going on. There may b

Re: [CMake] Need help with COMPILE_DEFINITIONS_

2015-09-14 Thread Hendrik Sattler
Am 14. September 2015 22:25:00 MESZ, schrieb Pau Garcia i Quiles : >Hello, > >Have you tried > >set_property(TARGET ${PrjName0} PROPERTY COMPILE_DEFINITIONS_DEBUG >-DATEST) That would be the right thing for add_definitions() but not here. He could try with generator expressions though. > >On M

Re: [CMake] Need help with COMPILE_DEFINITIONS_

2015-09-14 Thread Pau Garcia i Quiles
Hello, Have you tried set_property(TARGET ${PrjName0} PROPERTY COMPILE_DEFINITIONS_DEBUG -DATEST) ? On Mon, Sep 14, 2015 at 9:35 PM, Carl Poirier wrote: > Hi folks, > > I need some help setting the COMPILE_DEFINITIONS_. I'm using the > Visual Studio 2008 generator. I use this command to do

[CMake] Need help with COMPILE_DEFINITIONS_

2015-09-14 Thread Carl Poirier
Hi folks, I need some help setting the COMPILE_DEFINITIONS_. I'm using the Visual Studio 2008 generator. I use this command to do so which I took in the notes when the feature was added: set_property(TARGET ${PrjName0} PROPERTY COMPILE_DEFINITIONS_DEBUG

Re: [CMake] FindGit.cmake proposal

2015-09-14 Thread Gregor Jasny via CMake
Hello, On 10/09/15 16:34, Daniel Wirtz wrote: > i've now quite often encountered the need to access basic git > information about the source tree from within cmake. > i've attached the current FindGit.cmake module shipped with CMake > enhanced by two functions: getGitRevision and getGitBranch. > i

[CMake] Libraries for a Target and/or its Dependents

2015-09-14 Thread Wojciech Mamrak
Hello, The docs say [1]: "Libraries and targets following PRIVATE are linked to, but are not made part of the link interface." If so, why does this snippet: add_library(private_lib STATIC ...) add_library(public_lib STATIC ...) target_link_libraries(Test PRIVATE private_lib