On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote:
>>> > Shall the test be located in
>>> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
>>> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
>>> > Usually, there's been a folder with bugid (`/4380543/`) for each te
On Thu, 2 Jun 2022 05:25:54 GMT, Tejesh R wrote:
> > I can see no reason why the test is for Windows only.
> >
> > The original bug
> > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all
> > the operating systems as affected. Then
> > [JDK-8134640](https://bugs.openjdk.j
> This test verifies that dragging from one InternalFrame and a drop target in
> another InternalFrame functions properly.
> This fix moves an unstable closed applet based test to open regression based
> java test, but updated to be more comprehensive with some stabilisation
> improvements. The
On Fri, 20 May 2022 07:51:28 GMT, Tejesh R wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Following the process to convert a closed test to open, created a PR in
>> closed space and got it reviewed, now updating
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote:
>>> > > > I wonder why the test is Windows-specific if it allows changing Look
>>> > > > and Feels.
>>> > > > The only Look and Feel which ignores the background is Nimbus, other
>>> > > > L&Fs on Windows at least paint the yellow and green
On Thu, 2 Jun 2022 00:36:28 GMT, Sergey Bylokhov wrote:
> BTW I think that the usage of
> `return icons.toArray(EMPTY_TRAY_ARRAY);`
> is slower than any of other cases: presized or zero. So if we would like to
> use a similar pattern the zero version is better.
Why is it? It's the same as `icon
On Thu, 19 May 2022 16:15:05 GMT, Jayathirth D V wrote:
> > > I dont see an internal PR to remove the applet based closed test. Also
> > > why https://bugs.openjdk.java.net/browse/JDK-8286822 is created as
> > > enhancement ?
> > > If this test is failing intermittently how many times we have s
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote:
> > > I can see no reason why the test is for Windows only.
> > > The original bug
> > > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all
> > > the operating systems as affected. Then
> > > [JDK-8134640](https://bug
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Removed windows specific jtreg
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://git.
On Wed, 1 Jun 2022 09:45:32 GMT, Alexey Ushakov wrote:
> Another bug needs to be filed for tests having lower performance with the
> Metal pipeline as compared to OpenGL pipeline.
I've filed [JDK-8287694](https://bugs.openjdk.java.net/browse/JDK-8287694)
-
PR: https://git.openjdk.
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Wed, 1 Jun 2022 20:50:47 GMT, Phil Race wrote:
> Malgun is now not appearing in the font menu of Font2DTest when I use ko +
> UTF-8 !?
> It appears if I use -Dfile.encoding=ko instead
Are you implying it used to appear earlier? with what configuration or patch?
It is same for me but I haven'
On Thu, 2 Jun 2022 00:08:48 GMT, Sergey Bylokhov wrote:
> Time: 21313400
> Time: 4036200
> Time: 1140613100
> Time: 839499200
These are some extreme numbers, on my system it is more like 8 to 10 times
slower depending on the run:
Time: 13250900
Time: 10126200
Time: 113548000
Time: 113630100
Bu
On Wed, 1 Jun 2022 20:21:40 GMT, Alexey Ushakov wrote:
> Commit command buffer after MTL_OP_MASK_OP operation
All test run is fine with this change.
-
Marked as reviewed by aghaisas (Committer).
PR: https://git.openjdk.java.net/jdk/pull/8981
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Removed whitespaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://git.openjdk.jav
On Wed, 1 Jun 2022 19:40:34 GMT, Harshitha Onkar wrote:
>> With the proposed fix, JList's focus ring color follows accent color
>> changes. Previously the focus ring for JList was not prominently visible and
>> did not follow accent color changes.
>>
>> While investing a similar issue related
The NSAccessibilityShouMinuAction action does not show the menu for the text
element.
Steps to reproduce:
1. redefine the accessible context with the addition of the toggle popup
action;
2. run on macOS with VoiceOver enabled;
3. try to call the context menu in the editor by pressing vo+shift
On Thu, 2 Jun 2022 00:55:07 GMT, Sergey Bylokhov wrote:
> Can you please double check how the native applications/components look when
> the colors are "similar".
@mrserb There are different variations in the native applications -
On Reminders App the background color remains the same (light g
On Wed, 16 Mar 2022 05:36:04 GMT, Sergey Bylokhov wrote:
>>> This might be a rookie question:
>>>
>>> When it comes to modifying and restoring a Graphics, I've seen two common
>>> patterns: A. Call `newG = g.create()` and later `newG.dispose()` B. Call
>>> `g.setX(newValue)` and then call `g.s
On Wed, 1 Jun 2022 23:44:23 GMT, Sergey Bylokhov wrote:
> Do we need to update the size value and take into account the low/hi sizes?
Not exactly, the issue is that for some files (but just for some of them) this
call ignores the high icon size parameter and always returns the set of small
an
On Mon, 14 Mar 2022 02:29:47 GMT, Jeremy wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use small icon pointer for icons less than 24 pixels wide - this way we
>> get the 16x16 icon which is better for scaling
On Thu, 2 Jun 2022 17:26:49 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 993:
>>
>>> 991: } else {
>>> 992: fn_DestroyIcon((HICON)hIconSmall);
>>> 993: }
>>
>> Does it mean that we will extract all ima
This test was failing consistently on same machines and at the same time as
#8532.
Test failure is also no longer reproducible after #8320 fix.
This is macOS only test, so corresponding `@requires os.family` tag was added.
Testing is green.
-
Commit messages:
- os.family
- initi
Jeremy,
I hope you are doing well.
As jdk9 rdp1 is next week, do you plan this bug to be ready for this short
window or not ?
Laurent
Le dim. 29 mai 2022, 09:31, Laurent Bourgès a
écrit :
> One more general comment on this bug:
> what is expected when lineTo() does not change last point after
Laurent,
I made a very modest PR here:
https://github.com/openjdk/jdk/pull/8943
I wasn’t aware there was a deadline coming up; thanks for letting me
know.
This passes my current test, but depending on code review feedback it’s
hard to predict if this will be ready by next week.
- Jeremy
On Thu, 2 Jun 2022 08:18:21 GMT, Alexey Ivanov wrote:
>> BTW I think that the usage of
>> `return icons.toArray(EMPTY_TRAY_ARRAY);`
>> is slower than any of other cases: presized or zero. So if we would like to
>> use a similar pattern the zero version is better.
>
>> BTW I think that the usage
On Thu, 2 Jun 2022 18:12:26 GMT, Alexander Zuev wrote:
>>> Does it mean that we will extract all images except on the sides twice? for
>>> 16x16 we will extract 16x16 and 32x32 on the next iteration for 32x32 we
>>> will extract 32x32 and 64x64?
>>
>> No, on the next iteration we will extract
Hi Jeremy,
I quickly tested my modified path with the extra condition and noticed so
difference in my tests + fixed the original reproducer code.
It is quite trivial ~ 3 lines in Stroker so it seems doable to release this
fix on time.
I will look at your test code and see how to test few more ca
Sorry, I corrected 2 typo error:
I quickly tested my modified patch with the extra condition and noticed no
difference in my tests + fixed the original reproducer code.
Laurent
Le ven. 3 juin 2022, 00:00, Laurent Bourgès a
écrit :
> Hi Jeremy,
>
> I quickly tested my modified path with the ext
On Thu, 2 Jun 2022 14:08:31 GMT, Alexander Zuev wrote:
> > Time: 21313400
> > Time: 4036200
> > Time: 1140613100
> > Time: 839499200
>
> These are some extreme numbers, on my system it is more like 8 to 10 times
> slower depending on the run: Time: 13250900 Time: 10126200 Time: 113548000
> Tim
On Thu, 2 Jun 2022 21:50:04 GMT, Sergey Bylokhov wrote:
>>> Can we try to do that via different API:
>>> https://devblogs.microsoft.com/oldnewthing/20140501-00/?p=1103 probably it
>>> will work better?
>>
>> No, during initial implementation i tried it and it worked even worse and
>> less sta
On Thu, 2 Jun 2022 12:25:18 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 1 Jun 2022 20:21:40 GMT, Alexey Ushakov wrote:
> Commit command buffer after MTL_OP_MASK_OP operation
Doesn't seem specific to ovals .. [why] was nothing else affected ?
-
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8981
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
It looks for a "maxp" table which is absent for this font.
Are you sure ? I know that is
On Thu, 2 Jun 2022 23:07:37 GMT, Phil Race wrote:
> Doesn't seem specific to ovals .. [why] was nothing else affected ?
Yes, you're right it's not only ovals. I've mentioned them because of my
reproducer. The following missing frames also was caused by this problem:
LinGrad3RotatedOvalAA : 9,1
On Wed, 1 Jun 2022 20:21:40 GMT, Alexey Ushakov wrote:
> Commit command buffer after MTL_OP_MASK_OP operation
This pull request has now been integrated.
Changeset: cbaeb00f
Author:Alexey Ushakov
URL:
https://git.openjdk.java.net/jdk/commit/cbaeb00fcea7fb8942838610c2d68e27d290fb58
St
On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev
wrote:
> This test was failing consistently on same machines and at the same time as
> #8532.
>
> Test failure is also no longer reproducible after #8320 fix.
>
> This is macOS only test, so corresponding `@requires os.family` tag was
> a
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev
wrote:
> This test was failing consistently on same machines and at the same time as
> #8532.
>
> Test failure is also no longer reproducible after #8320 fix.
>
> This is macOS only test, so corresponding `@requires os.family` tag was
> a
On Thu, 2 Jun 2022 22:15:49 GMT, Sergey Bylokhov wrote:
> I still do not see a reason why we cannot request the exact size of the image
> from the windows, so if the small icon and the screen scale is 1.25 we can
> try to extract 20x20
Because for some files - and we can not predict which file
On Fri, 3 Jun 2022 05:12:05 GMT, Alexander Zuev wrote:
>>> > Does it mean that we will extract all images except on the sides twice?
>>> > for 16x16 we will extract 16x16 and 32x32 on the next iteration for 32x32
>>> > we will extract 32x32 and 64x64?
>>>
>>> No, on the next iteration we will
On Thu, 2 Jun 2022 16:07:37 GMT, Artem Semenov wrote:
> The NSAccessibilityShouMinuAction action does not show the menu for the text
> element.
> Steps to reproduce:
> 1. redefine the accessible context with the addition of the toggle popup
> action;
> 2. run on macOS with VoiceOver enabled;
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev
wrote:
> This test was failing consistently on same machines and at the same time as
> #8532.
>
> Test failure is also no longer reproducible after #8320 fix.
>
> This is macOS only test, so corresponding `@requires os.family` tag was
> a
On Thu, 2 Jun 2022 22:29:50 GMT, Sergey Bylokhov wrote:
> I see that the bug description has a test case which produce this exception.
> There are these lines on the stack:
>
> ```
> at
> sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:116)
> at java.awt.Containe
On Thu, 2 Jun 2022 16:07:37 GMT, Artem Semenov wrote:
> The NSAccessibilityShouMinuAction action does not show the menu for the text
> element.
> Steps to reproduce:
> 1. redefine the accessible context with the addition of the toggle popup
> action;
> 2. run on macOS with VoiceOver enabled;
On Fri, 3 Jun 2022 05:38:42 GMT, Tejesh R wrote:
> > I see that the bug description has a test case which produce this
> > exception. There are these lines on the stack:
> > ```
> > at
> > sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:116)
> > at java.awt.Container.
Currently, the logging of the J2DBench differs from run to run. Each time the
order of the parameters is random.
For example:
First run: `with to Default Frame, bounce, 1x1, SrcOver, ident, !extraalpha,
!xormode, !clip, Default, from transvolimg translucent, !touchsrc, Nearest
neighbor`
Next ru
> Create a Regression test for
> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031)
>
> The issue indicates the need for a a getAccessibleDescription being
> implemented for the JFileChooser.
> The test added verifies the same.
> This review is for migrating tests from a closed test
> Create a Regression test for
> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031)
>
> The issue indicates the need for a a getAccessibleDescription being
> implemented for the JFileChooser.
> The test added verifies the same.
> This review is for migrating tests from a closed test
51 matches
Mail list logo
