On Fri, 22 Apr 2022 05:06:55 GMT, Prasanta Sadhukhan
wrote:
>> Test was written based on assumption that we will receive only one
>> `mouseWheelMoved` event with `getWheelRotation() == 20` after
>> `robot.mouseWheel(20)` call, but we can receive 20 events with
>> `getWheelRotation == 1` inst
On Tue, 19 Apr 2022 20:03:57 GMT, Alexander Zvegintsev
wrote:
> Test was written based on assumption that we will receive only one
> `mouseWheelMoved` event with `getWheelRotation() == 20` after
> `robot.mouseWheel(20)` call, but we can receive 20 events with
> `getWheelRotation == 1` instea
On Fri, 22 Apr 2022 07:02:27 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Robot/RobotWheelTest/RobotWheelTest.java line 47:
>>
>>> 45:
>>> 46: private static AtomicInteger wheelRotation = new AtomicInteger();
>>> 47: private static int wheelSign = Platform.isOSX() ? -1 : 1;
>>
> - The hand-crafted methods for addition and multiplication are replaced by
> the "Math" versions.
> - Cleanup: the usage of do/while(false) is removed
Sergey Bylokhov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
> The test was failing due to it tried to place windows too close to left top
> corner, so they got shifted from the dock and top panel on Gnome.
>
> Shifting all test windows fixes the issue.
>
>
> Testing is green on all platforms.
Alexander Zvegintsev has updated the pull request incrementa
On Fri, 22 Apr 2022 05:17:25 GMT, Prasanta Sadhukhan
wrote:
> Is it possible to remove the obsolete "Standard Test Machinery Section" which
> we have removed from other tests?
Sure, updated.
-
PR: https://git.openjdk.java.net/jdk/pull/8326
On Fri, 22 Apr 2022 07:37:09 GMT, Alexander Zvegintsev
wrote:
>> The test was failing due to it tried to place windows too close to left top
>> corner, so they got shifted from the dock and top panel on Gnome.
>>
>> Shifting all test windows fixes the issue.
>>
>>
>> Testing is green on all
On Thu, 21 Apr 2022 20:07:17 GMT, Alisen Chung wrote:
>> added EmbeddedFrame support for macosx in regtesthelpers
>
> Alisen Chung has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge branch '7080150' of github.com:alisenchung/jdk into 7
> The test was failing due to it tried to place windows too close to left top
> corner, so they got shifted from the dock and top panel on Gnome.
>
> Shifting all test windows fixes the issue.
>
>
> Testing is green on all platforms.
Alexander Zvegintsev has updated the pull request incrementa
On Fri, 22 Apr 2022 08:20:50 GMT, Prasanta Sadhukhan
wrote:
> Seems like the test does not finish in standalone mode nor dispose its frame.
fixed
-
PR: https://git.openjdk.java.net/jdk/pull/8326
On Fri, 22 Apr 2022 06:44:36 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Thanks for catching it. I'll make the required changes.
>
> SInce you are hardcoding PassFailFrame column to 35, it seems some word break
> is not perfect in the above instructions.
> Probably, you can put \n break at appr
> The exisiting manual test case tests different html styles of JTabbedPane tab
> title. The tab with "big" as title is seen to be clipped on Aqua LAF for
> larger font-size. In other LAFs it is observed that bigger font-size can be
> accommodated without clipping.
>
> The following approaches
On Thu, 21 Apr 2022 17:15:20 GMT, Phil Race wrote:
> This fix moves a closed test to open but updated to be more comprehensive in
> testing multiple pipelines and with some stabilisation improvements.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pu
On Thu, 21 Apr 2022 13:24:15 GMT, Alexander Zvegintsev
wrote:
> Those tests were failing on Solaris, which is no longer supported.
>
> They pass as they are, but decreasing of delays reduce execution time
> significantly:
>
> e.g. proposed changes drops execution time from ~5min to ~2 min
>
On Fri, 22 Apr 2022 10:24:18 GMT, Alexander Zvegintsev
wrote:
>> The test was failing due to it tried to place windows too close to left top
>> corner, so they got shifted from the dock and top panel on Gnome.
>>
>> Shifting all test windows fixes the issue.
>>
>>
>> Testing is green on all
On Fri, 22 Apr 2022 16:44:07 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed that bigger font-size can be
>
On Thu, 21 Apr 2022 13:24:15 GMT, Alexander Zvegintsev
wrote:
> Those tests were failing on Solaris, which is no longer supported.
>
> They pass as they are, but decreasing of delays reduce execution time
> significantly:
>
> e.g. proposed changes drops execution time from ~5min to ~2 min
>
On Thu, 21 Apr 2022 09:14:14 GMT, Toshio Nakamura wrote:
> Japanese logical fonts are drawn with wrong size since Java 18.
> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` (and
> `sun.awt.windows.WFontConfiguration`) seems to expect the native encoding
> instead of the
> The test was failing due to it tried to place windows too close to left top
> corner, so they got shifted from the dock and top panel on Gnome.
>
> Shifting all test windows fixes the issue.
>
>
> Testing is green on all platforms.
Alexander Zvegintsev has updated the pull request incrementa
On Fri, 22 Apr 2022 08:38:09 GMT, Prasanta Sadhukhan
wrote:
>> Alisen Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch '7080150' of github.com:alisenchung/jdk into 7080150
>> - fixed merge conflict
>
> test/jdk/java
On Wed, 13 Apr 2022 11:02:05 GMT, Srinivas Mandalika
wrote:
> Create an automated test for
> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
> AccessibleValue implementation only accept Integers
> The AccessibleValue implementations of the following components:
>
> java.awt.Scr
On Fri, 22 Apr 2022 17:52:20 GMT, Alexander Zvegintsev
wrote:
>> The test was failing due to it tried to place windows too close to left top
>> corner, so they got shifted from the dock and top panel on Gnome.
>>
>> Shifting all test windows fixes the issue.
>>
>>
>> Testing is green on all
On Thu, 21 Apr 2022 22:03:17 GMT, Alexander Zuev wrote:
> Clean up imports;
> Close and dispose frame before exiting the test;
test/jdk/java/awt/List/SingleModeDeselect/SingleModeDeselect.java line 66:
> 64: throw new RuntimeException("Test failed:
> List.getSelectedIndex() ret
Added a background to the test to prevent the file from dragging onto the
desktop and creating an extra file.
-
Commit messages:
- added background to prevent file creation during drag and drop
Changes: https://git.openjdk.java.net/jdk/pull/8370/files
Webrev: https://webrevs.openj
…xception: Index 4096 out of bounds for length 4096
Adapted from
https://github.com/openjdk/jfx/commit/7b7050c46299c0e6771ae02fbb5ceaf22104d3e4
# Testing done
Build locally on linux and ran jdk_imageio tests.
-
Commit messages:
- 7131823: Loading some animated GIFs fails with
Arr
Removed passing tests from problem list
-
Commit messages:
- removed other tests from problem list
- removed tests from ProblemList
Changes: https://git.openjdk.java.net/jdk/pull/8368/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8368&range=00
Issue: https://bugs.o
On Fri, 22 Apr 2022 17:38:28 GMT, Alisen Chung wrote:
> Removed passing tests from problem list
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8368
> Clean up imports;
> Close and dispose frame before exiting the test;
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Use one tyr/catch instead of two
Generic code cleanup
-
Changes:
- all: https://git.openjdk.jav
On Fri, 22 Apr 2022 17:38:28 GMT, Alisen Chung wrote:
> Removed passing tests from problem list
When these tests were added to the problem list all of them fail at least once
in a couple of iterations, see
[JDK-8198693](https://bugs.openjdk.java.net/browse/JDK-8198693). Please make
sure that
On Fri, 22 Apr 2022 20:04:32 GMT, Dan Lutker wrote:
> …xception: Index 4096 out of bounds for length 4096
>
> Adapted from
> https://github.com/openjdk/jfx/commit/7b7050c46299c0e6771ae02fbb5ceaf22104d3e4
>
> # Testing done
> Build locally on linux and ran jdk_imageio tests.
The fix looks fine
On Fri, 22 Apr 2022 19:41:44 GMT, Alisen Chung wrote:
> Added a background to the test to prevent the file from dragging onto the
> desktop and creating an extra file.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8370
On Thu, 14 Apr 2022 06:50:10 GMT, Prasanta Sadhukhan
wrote:
> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used
> to have double height compared to normal JComboBox.
> The issue is still observed for macos for Aqua L&F where still double height
> is seen.
> Fix is to
On Fri, 22 Apr 2022 17:38:28 GMT, Alisen Chung wrote:
> Removed passing tests from problem list
Yeah, these modal tests were VERY unstable. I can't think of anything we fixed
which would make them stable again,
so we should repeat these tests maybe 100 times to make sure they pass before
remo
On Fri, 22 Apr 2022 17:54:49 GMT, DamonGuy wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use one tyr/catch instead of two
>> Generic code cleanup
>
> test/jdk/java/awt/List/SingleModeDeselect/SingleModeDesele
On Thu, 21 Apr 2022 17:47:12 GMT, Alexander Zvegintsev
wrote:
> Looks like this test was written based on assumption that SystemTray is
> supported on all platforms.
>
> However on Linux it may not be true.
>
> Availability of SystemTray is detected by getting owner of `_NET_SYSTEM_TRAY`
>
On Fri, 22 Apr 2022 17:49:26 GMT, Alisen Chung wrote:
>> test/jdk/java/awt/regtesthelpers/UtilInternal.java line 81:
>>
>>> 79: Method get_target =
>>> window_peer_class.getMethod("getTarget", new Class[0]);
>>> 80: System.out.println("get_target = " + get_target);
>>> 8
On Fri, 22 Apr 2022 21:57:23 GMT, Alexander Zuev wrote:
>> Clean up imports;
>> Close and dispose frame before exiting the test;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use one tyr/catch instead of two
> Generic
On Fri, 22 Apr 2022 16:44:07 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed that bigger font-size can be
>
On Thu, 21 Apr 2022 18:50:16 GMT, Alexander Zuev wrote:
>> Clear the kCGEventFlagMaskSecondaryFn flag if it is set before posting
>> keyboard events to the system queue.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Ad
On Fri, 22 Apr 2022 23:15:51 GMT, Sergey Bylokhov wrote:
> Probably we should think about care of the big font in the aqua L&F and
> decrease the size we know it is too big?
@mrserb since point size are estimates will this pose a problem while
decreasing the size of the text?
"to decrease the
On Wed, 20 Apr 2022 19:24:25 GMT, XenoAmess wrote:
>> These are the changes that too many to be reviewed in 8186958, thus split
>> some of them out.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add more replaces
src/demo/
On Fri, 22 Apr 2022 17:52:20 GMT, Alexander Zvegintsev
wrote:
>> The test was failing due to it tried to place windows too close to left top
>> corner, so they got shifted from the dock and top panel on Gnome.
>>
>> Shifting all test windows fixes the issue.
>>
>>
>> Testing is green on all
On Fri, 22 Apr 2022 07:36:43 GMT, Sergey Bylokhov wrote:
>> Description of the new version of the fix:
>> While I have worked on this change and tried to consider the comments, I
>> have found that the usages of the "safeAdd/safeMult" in the LCMSImageLayout
>> class are incorrect. Both methods
On Fri, 22 Apr 2022 16:44:07 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed that bigger font-size can be
>
On Fri, 22 Apr 2022 23:56:05 GMT, Phil Race wrote:
> This is just to fix a complaint about the test. Whether we want to make that
> policy change of ignoring font sizes that are "too big" is a separate issue.
> And the best we could do is some estimate based on metrics of the font, which
> pro
45 matches
Mail list logo
