RFR: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE

2022-04-18 Thread Prasanta Sadhukhan
Test was failing in the past owing to NPE while accessing JMenu probably owing to fact the test did not wait for UI to be visible before starting the test, so added a delay after the frame is made visible. Also, added disposal of frame. Also, it seems JDK-8213535 fix might be having a positive im

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 04:12:56 GMT, Prasanta Sadhukhan wrote: >> javax/swing/JButton/8151303/PressedIconTest.java was failing few times in >> macos M1 system owing t color profile issue. >> >> java.lang.RuntimeException: Colors are different! >> at PressedIconTest.main(PressedIconTest.java:88)

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-18 Thread Prasanta Sadhukhan
On Fri, 15 Apr 2022 09:57:53 GMT, Prasanta Sadhukhan wrote: > javax/swing/JButton/8151303/PressedIconTest.java was failing few times in > macos M1 system owing t color profile issue. > > java.lang.RuntimeException: Colors are different! > at PressedIconTest.main(PressedIconTest.java:88) > >

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-04-18 Thread Dmitry Batrak
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill [v2]

2022-04-18 Thread Ajit Ghaisas
On Tue, 12 Apr 2022 04:15:56 GMT, Ajit Ghaisas wrote: >> Alexey Ushakov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill >> >> Extracted try/catch logic of SurfaceD

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-18 Thread Jayathirth D V
On Fri, 15 Apr 2022 09:57:53 GMT, Prasanta Sadhukhan wrote: > javax/swing/JButton/8151303/PressedIconTest.java was failing few times in > macos M1 system owing t color profile issue. > > java.lang.RuntimeException: Colors are different! > at PressedIconTest.main(PressedIconTest.java:88) > >

Re: RFR: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac

2022-04-18 Thread Jayathirth D V
On Thu, 14 Apr 2022 21:12:07 GMT, Alisen Chung wrote: > test passes, so removing from problem list We should add https://bugs.openjdk.java.net/browse/JDK-6447537 also in the PR and decouple test/java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogTest failure into new bug. https://bugs.op

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Alexey Ivanov
On Mon, 18 Apr 2022 05:14:27 GMT, Jayathirth D V wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > src/java.desktop/share/classes/java/awt/

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Alexey Ivanov
On Mon, 18 Apr 2022 05:20:11 GMT, Jayathirth D V wrote: > This PR has a lot of other changes than just correcting spelling mistakes and > a/an combinations. Expanding wildcard imports is not _a lot of other changes_. The build is successful, expanding imports doesn't hinder reviewing other cha

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 04:14:29 GMT, Prasanta Sadhukhan wrote: >> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used >> to have double height compared to normal JComboBox. >> The issue is still observed for macos for Aqua L&F where still double height >> is seen. >> Fix

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-18 Thread Prasanta Sadhukhan
On Thu, 14 Apr 2022 06:50:10 GMT, Prasanta Sadhukhan wrote: > JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used > to have double height compared to normal JComboBox. > The issue is still observed for macos for Aqua L&F where still double height > is seen. > Fix is to

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. > > I also expanded wildcard imports. test/jdk/javax/accessibility/manual/ComboBoxDemo.h

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 13:04:17 GMT, Alexey Ivanov wrote: > > This PR has a lot of other changes than just correcting spelling mistakes > > and a/an combinations. > > Expanding wildcard imports is not _a lot of other changes_. The build is > successful, expanding imports doesn't hinder reviewing

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Alexey Ivanov
On Mon, 18 Apr 2022 13:24:55 GMT, Jayathirth D V wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > test/jdk/javax/accessibility/manual/Comb

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Alexey Ivanov
On Mon, 18 Apr 2022 14:55:04 GMT, Alexey Ivanov wrote: >> test/jdk/javax/accessibility/manual/ComboBoxDemo.html line 63: >> >>> 61: >>> 62: >>> 63: Verify that space and down arrow bring up the >>> drop-down list. >> >> Is this HTML refactoring needed as p

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. > > I also expanded wildcard imports. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Alexey Ivanov
On Mon, 18 Apr 2022 15:13:34 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > Alexey Ivanov has updated the pull reques

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Phil Race
On Mon, 18 Apr 2022 15:13:34 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > Alexey Ivanov has updated the pull reques

Re: RFR: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset

2022-04-18 Thread Zhengyu Gu
On Fri, 15 Apr 2022 18:43:27 GMT, Phil Race wrote: >> Please review this small patch that releases temporary charsets to avoid >> memory leak. >> >> Test: >> >> - [x] jdk_2d > > src/java.desktop/unix/native/common/awt/fontpath.c line 1112: > >> 1110: if (currentUnionSet !=

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 15:13:34 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > Alexey Ivanov has updated the pull reques

Re: RFR: 8283624: Create an automated regression test for RFE-4390885 [v2]

2022-04-18 Thread Manukumar V S
On Fri, 8 Apr 2022 07:14:28 GMT, Manukumar V S wrote: >> Write a regression test for >> [JDK-4390885](https://bugs.openjdk.java.net/browse/JDK-4390885) Enhancement >> Request. >> >> Issue: >> Please add the ability to set the location of a JFileChooser. This might be a >> bug, but JFileChooser

Integrated: 8284521: Write an automated regression test for RFE 4371575

2022-04-18 Thread Manukumar V S
On Thu, 7 Apr 2022 11:08:38 GMT, Manukumar V S wrote: > Write an automated regression test for > [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575) > > Issue: > As part of the Merlin focus project, JComponent.setRequestFocusEnabled was > deprecated and its implementation was change