Integrated: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException

2022-04-15 Thread Prasanta Sadhukhan
On Fri, 15 Apr 2022 05:26:11 GMT, Prasanta Sadhukhan wrote: > This test used to fail in nightly testing few years back and it seems it > fails because we used to run in samevm mode at that time. > Several iterations of this test pass in CI testing in all platforms (link in > JBS) so removing f

RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-15 Thread Prasanta Sadhukhan
javax/swing/JButton/8151303/PressedIconTest.java was failing few times in macos M1 system owing t color profile issue. java.lang.RuntimeException: Colors are different! at PressedIconTest.main(PressedIconTest.java:88) Test is now passing in all mac M1 systems in CI (link in jBS) so can be remo

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

2022-04-15 Thread ExE Boss
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote: >> I've stared at the javadoc for Class.isAssignableFrom and Class.isInstance >> and if a non-null instance is used to get a non-null class they are PROBABLY >> the same but it is far from clear. The implementations of both are at least

Integrated: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java

2022-04-15 Thread Alexey Ivanov
On Thu, 14 Apr 2022 20:25:56 GMT, Alexey Ivanov wrote: > A quick fix for the > `javax/swing/text/html/parser/Parser/8078268/bug8078268.java` which replaces > `Thread.sleep` in a loop with `CountDownLatch.await`. > > The code is shorter and clearer. > > The test fails on the builds without the

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-15 Thread Alexey Ivanov
On Fri, 15 Apr 2022 01:18:58 GMT, Phil Race wrote: > but what happens if a user pastes > a few lines of text from windows Notepad - and it contains \r\n ? This is handled: The text is converted by `PasteAction` somehow, the model contains only `\n` as the result. If it weren't handled, there w

Re: RFR: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

2022-04-15 Thread Alexey Ivanov
On Thu, 14 Apr 2022 14:22:18 GMT, Alexander Zvegintsev wrote: > The SimpleWindowActivationTest test does not fail even without > modifications(multiple CI test runs are green). > So just remove it from ProblemList would be enough. > > However I did some clean up and added some delays for "ext

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-15 Thread Phil Race
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object) if >> endOfLine

RFR: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac

2022-04-15 Thread Alisen Chung
test passes, so removing from problem list - Commit messages: - remove test from ProblemList Changes: https://git.openjdk.java.net/jdk/pull/8254/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8254&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8198622 Sta

Integrated: 8283704: Add sealed modifier to java.awt.MultipleGradientPaint

2022-04-15 Thread Phil Race
On Fri, 1 Apr 2022 19:18:39 GMT, Phil Race wrote: > Along the same lines as other recent additions of the sealed modifier but > this one is quite simple. > Only MultiGradientPaint is touched. The two extant sub-classes it permits are > already final > > CSR for review : https://bugs.openjdk.ja

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-15 Thread Phil Race
On Fri, 15 Apr 2022 09:57:53 GMT, Prasanta Sadhukhan wrote: > javax/swing/JButton/8151303/PressedIconTest.java was failing few times in > macos M1 system owing t color profile issue. > > java.lang.RuntimeException: Colors are different! > at PressedIconTest.main(PressedIconTest.java:88) > >

Re: RFR: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac

2022-04-15 Thread Phil Race
On Thu, 14 Apr 2022 21:12:07 GMT, Alisen Chung wrote: > test passes, so removing from problem list Hmm .. so no idea why it passes now ? 4 years since this bug was filed but the info then was minimal. Can you see if it reproduces with JDK 11 ? If "it fails", then try later JDKs one by one unt

Re: RFR: 8284699: Include all image types to the J2DBench.ColorConvertOpTests

2022-04-15 Thread Phil Race
On Mon, 11 Apr 2022 21:06:08 GMT, Sergey Bylokhov wrote: > The J2DBench.ColorConvertOp tests are used to track the performance of the > littlecms library in the JDK. The new version of the littlecms will add > support for the premultiplied alpha. But right now the J2DBench does not test > the

Re: RFR: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset

2022-04-15 Thread Phil Race
On Mon, 11 Apr 2022 18:05:09 GMT, Zhengyu Gu wrote: > Please review this small patch that releases temporary charsets to avoid > memory leak. > > Test: > > - [x] jdk_2d src/java.desktop/unix/native/common/awt/fontpath.c line 1112: > 1110: if (currentUnionSet != charset) {