Integrated: 8282716: [macos] Enable javax/swing/JScrollPane/TestMouseWheelScroll.java on macos

2022-04-12 Thread Prasanta Sadhukhan
On Wed, 6 Apr 2022 10:11:33 GMT, Prasanta Sadhukhan wrote: > The test was failing on macos and was excluded in macos because the > viewposition was not changed after mouse wheel scroll. Seems like mouse wheel > scroll direction is opposite in macos compared to windows etc so if we try to > do

Re: RFR: 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill [v2]

2022-04-12 Thread Alexey Ushakov
On Tue, 12 Apr 2022 04:15:56 GMT, Ajit Ghaisas wrote: >> Alexey Ushakov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill >> >> Extracted try/catch logic of SurfaceD

RFR: 8196465: javax/swing/JComboBox/8182031/ComboPopupTest.java fails on Linux

2022-04-12 Thread Prasanta Sadhukhan
Test was seen to be failing in linux CI system although passing locally. Added waitForIdle(). Test is now passing in all CI systems including linux and mac. Several iterations of the test in CI run is ok (link in JBS) - Commit messages: - 8196465: javax/swing/JComboBox/8182031/Comb

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v4]

2022-04-12 Thread Srinivas Mandalika
> Create a regression test for JDK-4699544 > > The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements > the accessibility interface javax.accessibility.AccessibleComponent is > derived from java.awt.AccessibleAWTComponent, which returns null for > getAccessibleAt() because

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v3]

2022-04-12 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 01:26:15 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Frame on EDT, Line length <= 80 characters > > test/jdk/javax/accessibility/4699544/JRo

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v2]

2022-04-12 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) > > The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return > BoundedRangeModel.getMaximum() from getMaximumAccessibleValue() in their > AccessibleValue implementation. > The real

RFR: 8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails

2022-04-12 Thread Prasanta Sadhukhan
Test was failing in CI system in nightly testing. Saw it failed with HeadlessException in macos-x64 and mascos-aarch64 and with GTKL&F not supported in linux-x64 in headless CI system. Made the test headful and test now passes in all platforms (link in JBS) - Commit messages: - 8194

Re: RFR: 8196465: javax/swing/JComboBox/8182031/ComboPopupTest.java fails on Linux

2022-04-12 Thread Alexander Zvegintsev
On Tue, 12 Apr 2022 08:46:09 GMT, Prasanta Sadhukhan wrote: > Test was seen to be failing in linux CI system although passing locally. > Added waitForIdle(). > Test is now passing in all CI systems including linux and mac. Several > iterations of the test in CI run is ok (link in JBS) Marked

Integrated: 8196465: javax/swing/JComboBox/8182031/ComboPopupTest.java fails on Linux

2022-04-12 Thread Prasanta Sadhukhan
On Tue, 12 Apr 2022 08:46:09 GMT, Prasanta Sadhukhan wrote: > Test was seen to be failing in linux CI system although passing locally. > Added waitForIdle(). > Test is now passing in all CI systems including linux and mac. Several > iterations of the test in CI run is ok (link in JBS) This pu

Re: RFR: 8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails [v2]

2022-04-12 Thread Prasanta Sadhukhan
> Test was failing in CI system in nightly testing. > Saw it failed with HeadlessException in macos-x64 and mascos-aarch64 and with > GTKL&F not supported in linux-x64 in headless CI system. > Made the test headful and test now passes in all platforms (link in JBS) Prasanta Sadhukhan has updated

Integrated: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception

2022-04-12 Thread lawrence . andrews
On Fri, 25 Mar 2022 21:06:12 GMT, lawrence.andrews wrote: > We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can ma

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v8]

2022-04-12 Thread Alexey Ivanov
On Mon, 11 Apr 2022 18:17:34 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user ca

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-12 Thread Alexey Ivanov
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object) if >> endOfLine

Re: RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v2]

2022-04-12 Thread lawrence . andrews
> Fixed the following issue. > 1) Removed yes/no since test was failing due to "Parser error due to yesno in > @run main/manual=yesno" > 2) After removing yes/no test run( just shows the UI and gets dispose > immediately). User cannot interact with the test UI and mark the test pass or > failed.

Re: RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v3]

2022-04-12 Thread lawrence . andrews
> Fixed the following issue. > 1) Removed yes/no since test was failing due to "Parser error due to yesno in > @run main/manual=yesno" > 2) After removing yes/no test run( just shows the UI and gets dispose > immediately). User cannot interact with the test UI and mark the test pass or > failed.

RFR: 8284775: Simplify String.substring(_, length()) calls

2022-04-12 Thread Andrey Turbanov
Default `to` index for String.substring method call is length of the String. We can simplify code a bit, by omitting default value. - Commit messages: - [PATCH] Unnecessary string length argument for String.substring in java.desktop - [PATCH] Unnecessary string length argument for

Re: RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v4]

2022-04-12 Thread lawrence . andrews
> Fixed the following issue. > 1) Removed yes/no since test was failing due to "Parser error due to yesno in > @run main/manual=yesno" > 2) After removing yes/no test run( just shows the UI and gets dispose > immediately). User cannot interact with the test UI and mark the test pass or > failed.

Re: RFR: 8284775: Simplify String.substring(_, length()) calls

2022-04-12 Thread Brian Burkhalter
On Tue, 12 Apr 2022 19:38:33 GMT, Andrey Turbanov wrote: > Default `to` index for String.substring method call is length of the String. > We can simplify code a bit, by omitting default value. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8212

Re: RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v4]

2022-04-12 Thread Alexey Ivanov
On Tue, 12 Apr 2022 20:14:26 GMT, lawrence.andrews wrote: >> Fixed the following issue. >> 1) Removed yes/no since test was failing due to "Parser error due to yesno >> in @run main/manual=yesno" >> 2) After removing yes/no test run( just shows the UI and gets dispose >> immediately). User can

Re: RFR: 8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails [v2]

2022-04-12 Thread Alexey Ivanov
On Tue, 12 Apr 2022 13:25:15 GMT, Prasanta Sadhukhan wrote: >> Test was failing in CI system in nightly testing. >> Saw it failed with HeadlessException in macos-x64 and mascos-aarch64 and >> with GTKL&F not supported in linux-x64 in headless CI system. >> Made the test headful and test now pas

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v11]

2022-04-12 Thread Phil Race
On Tue, 5 Apr 2022 17:30:31 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java line 74: >> >>> 72: >>> 73: Thread.currentThread().interrupt(); >>> 74: ImageIcon i = new >>> ImageIcon("https://openjdk.java.net/images/openjdk.png";); >> >> This is

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v14]

2022-04-12 Thread Phil Race
On Fri, 8 Apr 2022 08:51:30 GMT, Tejesh R wrote: >> Removed the println() line from the Interrupted catch block. Since >> waitForID() Interrupt indicates completion of Image Loading, println as >> Interrupt handling was not required. > > Tejesh R has updated the pull request incrementally with

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v8]

2022-04-12 Thread Sergey Bylokhov
On Tue, 12 Apr 2022 13:48:23 GMT, Alexey Ivanov wrote: > I like this approach better, in which a test can be easily run without the > need for jtreg, I think it greatly simplifies debugging and updating the test. The new code depends on the PassFailJFrame from the library so it is not a simple

Re: RFR: 8284775: Simplify String.substring(_, length()) calls

2022-04-12 Thread Sergey Bylokhov
On Tue, 12 Apr 2022 19:38:33 GMT, Andrey Turbanov wrote: > Default `to` index for String.substring method call is length of the String. > We can simplify code a bit, by omitting default value. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8212