> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev e
> Fix repeated typo `exeption`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8283426: Fix 'exeption' typo
fix more typos, found by Sean Coffey
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7879/files
> Create a test for JDK-4715496
>
> Issue observed in the above bug is that the
> JTable.AccessibleJTableCell.getAccessible name returns the cell instance
> string instead of the cell text.
> The test is being added to verify the same.
> This review is for migrating tests from a closed test suit
https://bugs.openjdk.java.net/browse/JDK-8280193
Javadoc broke the first sentence at the full stop space (newline) so it
rendered with `Indicates a preference for proportional over non-proportional
(e.g.`
This is an incorrect sentence, and so this change fixes it by replacing the
`e.g.` to `f
On Tue, 18 Jan 2022 14:05:55 GMT, James Nord wrote:
> https://bugs.openjdk.java.net/browse/JDK-8280193
>
>
> Javadoc broke the first sentence at the full stop space (newline) so it
> rendered with `Indicates a preference for proportional over non-proportional
> (e.g.`
>
> This is an incorrec
On Tue, 18 Jan 2022 14:05:55 GMT, James Nord wrote:
> https://bugs.openjdk.java.net/browse/JDK-8280193
>
>
> Javadoc broke the first sentence at the full stop space (newline) so it
> rendered with `Indicates a preference for proportional over non-proportional
> (e.g.`
>
> This is an incorrec
On Mon, 14 Mar 2022 02:29:47 GMT, Jeremy wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> test/jdk/javax/swing/ImageIc
> Create a test for JDK-4715496
>
> Issue observed in the above bug is that the
> JTable.AccessibleJTableCell.getAccessible name returns the cell instance
> string instead of the cell text.
> The test is being added to verify the same.
> This review is for migrating tests from a closed test suit
On Tue, 18 Jan 2022 14:05:55 GMT, James Nord wrote:
> https://bugs.openjdk.java.net/browse/JDK-8280193
>
>
> Javadoc broke the first sentence at the full stop space (newline) so it
> rendered with `Indicates a preference for proportional over non-proportional
> (e.g.`
>
> This is an incorrec
> Create a test for JDK-4715496
>
> Issue observed in the above bug is that the
> JTable.AccessibleJTableCell.getAccessible name returns the cell instance
> string instead of the cell text.
> The test is being added to verify the same.
> This review is for migrating tests from a closed test suit
On Wed, 23 Mar 2022 07:31:23 GMT, Andrey Turbanov wrote:
>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8283426: Fix 'exeption' typo
> fix more typos, found by Sean Coffey
Marked as re
On Wed, 23 Mar 2022 06:19:14 GMT, Srinivas Mandalika
wrote:
>> Create a regression test for CCC8000326
>>
>> Issue is identified by
>> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
>> identifies that after focus moves into JMenuBar, whose focus traversal key
>> is di
[JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
linux machine. This was one of the four culprits that caused a 25-30% build
time regression over the last two years.
The problem here was that t
> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with three additional
commits since the last revision:
- Me
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Tue, 22 Mar 2022 11:30:31 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> Changes requested by aivanov (Reviewer).
@aivanov-jdk , could you please review now
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 13:55:11 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed apostrophe in comment o
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
scale stroke width at higher scalings
-
Changes:
- all: https://git.openjdk.java
On Wed, 23 Mar 2022 18:19:58 GMT, Alisen Chung wrote:
> I don't have a monitor that can go higher than 175%, so I'm not able to test
> the code well... Can you try the recent change to see if it works at 200+%?
> If not, I'll try using the area approach.
You can pass `-Dsun.java2d.uiScale=2.0`
On Wed, 23 Mar 2022 18:23:54 GMT, Alexey Ivanov wrote:
> > I don't have a monitor that can go higher than 175%, so I'm not able to
> > test the code well... Can you try the recent change to see if it works at
> > 200+%? If not, I'll try using the area approach.
>
> You can pass `-Dsun.java2d.u
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
> Fix repeated typo `exeption`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8283426: Fix 'exeption' typo
Co-authored-by: Alexey Ivanov <[email protected]>
-
Changes:
- all: https:
Used setOpaque() method to set correct background of platform window
Extracted setting background to the particular method in PlatformWindow.
Provided appropriate implementation in CPlatformWindow.
-
Commit messages:
- 8273355: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1
On Wed, 23 Mar 2022 19:35:22 GMT, Phil Race wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% build time
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
> time regression over the last two years.
>
> The problem her
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Thu, 17 Mar 2022 21:47:12 GMT, lawrence.andrews
wrote:
> 1) Removed =yesno since it was throwing Error: Not a test or directory
> containing tests
> 2) Test was just printing the "Test passes" on the printer and user did not
> had any option to mark the test as pass or fail and test was alw
> 1) Removed =yesno since it was throwing Error: Not a test or directory
> containing tests
> 2) Test was just printing the "Test passes" on the printer and user did not
> had any option to mark the test as pass or fail and test was always passing.
> so created test UI with test instruction and
On Wed, 23 Mar 2022 22:51:17 GMT, Phil Race wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed minor spelling
>
> test/jdk/java/awt/print/PrinterJob/InitToBlack.java line 172:
>
>> 170: if (!CountDo
On Wed, 23 Mar 2022 18:25:31 GMT, Alisen Chung wrote:
> Can you try the recent change to see if it works at 200+%?
Sure, if it still helps here's a screenshot at 250% scaling. It shows
`TitledBorder` constructed with:
* top: The JDK's `EtchedBorder` with the latest commit
* bottom: a custom
On Wed, 23 Mar 2022 22:37:55 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore HIGHEST for entire lib, just set SIZE to two files
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
> time regression over the last two years.
>
> The problem her
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Wed, 23 Mar 2022 23:13:04 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 487:
>>
>>> 485: LIBFONTMANAGER_OPTIMIZATION := HIGHEST
>>> 486:
>>> 487: ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang), )
>>
>> Can we have a note here that the de-opt is possi
On Wed, 23 Mar 2022 20:01:54 GMT, Alexey Ushakov wrote:
> Used setOpaque() method to set correct background of platform window
> Extracted setting background to the particular method in PlatformWindow.
> Provided appropriate implementation in CPlatformWindow.
src/java.desktop/macosx/classes/sun
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Tue, 22 Mar 2022 15:30:09 GMT, Manukumar V S wrote:
> Create a regression test for
> [JDK-4231298](https://bugs.openjdk.java.net/browse/JDK-4231298)
> Issue:
> When a JComboBox first drops down, the renderer is called for
> every element in the list, even those elements that will not
> actual
On Sun, 13 Mar 2022 13:42:15 GMT, Manukumar V S wrote:
> Write a regression test for
> [JDK-4164779](https://bugs.openjdk.java.net/browse/JDK-4164779) : JSplitPane
> keyboard navigation does not support F6 and Ctrl+Tab
>
>
> Issue:
> The specified keyboard support for JSplitPane also requires
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comment to show we don't care about these files.
>
> Do we really want to change the product performanc
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan
wrote:
> If we press " ´ " (on U.S. keyboard layout it is the [+] button just before
> the [delete] button), and then press "s" , 2 "´" characters are entered in a
> text field instead of "´s" with "Finish" keyboard layout.
> This is because
On Fri, 21 Jan 2022 17:02:38 GMT, Maxim Kartashev wrote:
> These crashes were not reproducible, so the fix is based on a hypothesis that
> there are two possible reasons for them:
> 1. `makeDefaultConfig()` returning `NULL`.
> 2. A race condition when the number of screens changes.
> The race sc
On Thu, 15 Jul 2021 17:29:01 GMT, Nikita Gubarkov wrote:
> It was implemented in JetBrains Runtime a year ago and was ported &
> refactored for this PR
> It includes:
> - Bitmap glyph loading via Freetype
> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
> bilinear-m
On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg wrote:
>> Emmanuel Bourg has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (Java generic font
>> names are usually capitalized)
>> - Te
On Fri, 4 Mar 2022 22:38:33 GMT, Jeremy wrote:
>> Jeremy has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control
>> points in bounding box
>>
>> This is a second follo
On Thu, 27 Jan 2022 21:47:04 GMT, lawrence.andrews
wrote:
>> 1) Test scenario was just showing test instruction with JTextArea. So added
>> the JTextArea as the instruction and method says.
>> 2) JTextArea is filled with contents so that and an Emoji character making
>> sure that screen reade
On Tue, 18 Jan 2022 14:05:55 GMT, James Nord wrote:
> https://bugs.openjdk.java.net/browse/JDK-8280193
>
>
> Javadoc broke the first sentence at the full stop space (newline) so it
> rendered with `Indicates a preference for proportional over non-proportional
> (e.g.`
>
> This is an incorrec
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote:
>> The proposed fix makes fonts with and without fallback components
>> distinguishable (in terms of `equals` method), so that
>> font metrics cache (and other similar code) can handle them separately. This
>> is achieved by adding a new boo
On Mon, 21 Mar 2022 21:41:27 GMT, lawrence.andrews
wrote:
>> This testcase covers both old and new api ( api added in jdk17
>> getAccessibleAction(), getAccessibleActionCount() ,
>> getAccessibleActionDescription )
>>
>> @shurymury
>> @savoptik
>
> lawrence.andrews has updated the pull requ
On Tue, 22 Mar 2022 01:45:30 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8274735: javax.imageio.IIOException: Unsupported Image Type while
>> processing a valid JPEG image
>
> src/java.deskto
On Thu, 17 Mar 2022 21:47:12 GMT, lawrence.andrews
wrote:
> 1) Removed =yesno since it was throwing Error: Not a test or directory
> containing tests
> 2) Test was just printing the "Test passes" on the printer and user did not
> had any option to mark the test as pass or fail and test was alw
On Wed, 23 Mar 2022 18:24:05 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> scale stroke width at higher
On Fri, 11 Mar 2022 14:44:25 GMT, Srinivas Mandalika
wrote:
>> Create a test for
>> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761)
>>
>> The issue observed is in a JFrame with a JTextField and a JScrollPane which
>> contains focused component. When the JScrollPane was
>> is r
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comment to show we don't care about these files.
>
> Do we really want to change the product performanc
On Wed, 15 Dec 2021 02:21:35 GMT, lawrence.andrews
wrote:
> 1) Test scenario was just showing test instruction with JTextArea. So added
> the JTextArea as the instruction and method says.
> 2) JTextArea is filled with contents so that and an Emoji character making
> sure that screen reader ca
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan
wrote:
> If we press " ´ " (on U.S. keyboard layout it is the [+] button just before
> the [delete] button), and then press "s" , 2 "´" characters are entered in a
> text field instead of "´s" with "Finish" keyboard layout.
> This is because
On Thu, 24 Mar 2022 03:29:45 GMT, Phil Race wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added @bug keyword
>
> test/jdk/java/awt/Focus/8282640/ScrollPaneFocusBugTest.java line 102:
>
>> 100: robo
On Fri, 11 Mar 2022 14:44:25 GMT, Srinivas Mandalika
wrote:
>> Create a test for
>> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761)
>>
>> The issue observed is in a JFrame with a JTextField and a JScrollPane which
>> contains focused component. When the JScrollPane was
>> is r
On Wed, 23 Mar 2022 10:12:26 GMT, Srinivas Mandalika
wrote:
>> Create a test for JDK-4715496
>>
>> Issue observed in the above bug is that the
>> JTable.AccessibleJTableCell.getAccessible name returns the cell instance
>> string instead of the cell text.
>> The test is being added to verify t
> Create a regression test for CCC8000326
>
> Issue is identified by
> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
> identifies that after focus moves into JMenuBar, whose focus traversal key is
> disabled by default, it never moves to other focusable component.
>
>
On Tue, 22 Mar 2022 06:29:16 GMT, Manukumar V S wrote:
>> Write a regression test for
>> [JDK-4615365](https://bugs.openjdk.java.net/browse/JDK-4615365) : JSplitPane
>> current and last divider positions incorrect when realized
>>
>> Issue:
>> JSplitPane component with a left and right compone
On Mon, 21 Mar 2022 06:13:24 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing imageio classes javadoc to use @throws
This pull request has now been integrated.
Changeset: e6f707aa
Author:Prasanta Sadhukhan
URL:
Prevailing JDK coding practices use "@throws" rather than "@exception".
Need to refactor remaining 2d, beans,sound classes to use @throws
-
Commit messages:
- Fix
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/7937/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=
69 matches
Mail list logo
