Re: RFR: 8282402: Create a regression test for JDK-4666101 [v2]

2022-03-03 Thread Manukumar V S
On Thu, 3 Mar 2022 06:19:36 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). >> >> DESCRIPTION OF THE ACTUAL PROBLEM : >> In a JEditorPane, the down arrow has no effect after you add text on a line >> preceding a blan

Re: RFR: 8282343: Create a regression test for JDK-4518432

2022-03-03 Thread Manukumar V S
On Thu, 24 Feb 2022 11:46:58 GMT, Manukumar V S wrote: > Create a regression test for > [JDK-4518432](https://bugs.openjdk.java.net/browse/JDK-4518432). > > Issue: Copying from JTree and then changing the data in the component that > was copied from, can cause pastes to use >the n

Integrated: 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents

2022-03-03 Thread Prasanta Sadhukhan
On Wed, 16 Feb 2022 07:44:27 GMT, Prasanta Sadhukhan wrote: > When invalid unicode codepoints 0x and 0x1 are added to an empty > javax.swing.JTextComponent (JTextArea or JTextField), the view cannot be > updated due to a NullPointerException in TextLayout.getBaselineFromGraphic() > ow

Integrated: 6911375: mouseWheel has no effect without vertical scrollbar

2022-03-03 Thread Prasanta Sadhukhan
On Wed, 23 Feb 2022 04:24:41 GMT, Prasanta Sadhukhan wrote: > It is observed that mouseWheel doesn't scroll through a list if there is no > scrollbar even though pressing PageUp/Down using keyboard moves up/down the > list. > Issue stems from the fact that BasicScrollPaneUI.Handler.mouseWheelM

RFR: 8282602: Refactor java/awt classes javadoc to use @throws instead of @exception

2022-03-03 Thread Prasanta Sadhukhan
Prevailing JDK coding practices use "@throws" rather than "@exception". Refactor existing java/awt classes javadoc to use @throws - Commit messages: - Fix - Fix Changes: https://git.openjdk.java.net/jdk/pull/7675/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7675&ran

Re: RFR: 8282402: Create a regression test for JDK-4666101 [v2]

2022-03-03 Thread Alexey Ivanov
On Thu, 3 Mar 2022 06:19:36 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). >> >> DESCRIPTION OF THE ACTUAL PROBLEM : >> In a JEditorPane, the down arrow has no effect after you add text on a line >> preceding a blan

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-03-03 Thread Phil Race
On Tue, 22 Feb 2022 04:38:21 GMT, Tejesh R wrote: >> Issue in painting last row of JTable due to decrement in `MaxRow `during >> computation. Differences in `MaxRow `computation between `TablePrintable` >> and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case >> added to va

Re: RFR: 8282402: Create a regression test for JDK-4666101 [v3]

2022-03-03 Thread Manukumar V S
> Create a regression test for > [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). > > DESCRIPTION OF THE ACTUAL PROBLEM : > In a JEditorPane, the down arrow has no effect after you add text on a line > preceding a blank line. > > Testing: > As the original issue was reported in

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v2]

2022-03-03 Thread Naoto Sato
On Thu, 3 Mar 2022 07:45:46 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-03 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v2]

2022-03-03 Thread Phil Race
On Thu, 3 Mar 2022 17:05:52 GMT, Naoto Sato wrote: > OK, so there is no way to chain the physical fonts. > One other thing I noticed was that `GulimChe` is a `monospaced` font, so I > would also leave it for `monospaced` properties, as `Malgun Gothic` is a > proportional font. Good point. ---

Re: RFR: 8282343: Create a regression test for JDK-4518432

2022-03-03 Thread Alexey Ivanov
On Thu, 24 Feb 2022 11:46:58 GMT, Manukumar V S wrote: > Create a regression test for > [JDK-4518432](https://bugs.openjdk.java.net/browse/JDK-4518432). > > Issue: Copying from JTree and then changing the data in the component that > was copied from, can cause pastes to use >the n

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v2]

2022-03-03 Thread Phil Race
On Thu, 3 Mar 2022 07:45:46 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8282402: Create a regression test for JDK-4666101 [v3]

2022-03-03 Thread Alexey Ivanov
On Thu, 3 Mar 2022 16:16:50 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). >> >> DESCRIPTION OF THE ACTUAL PROBLEM : >> In a JEditorPane, the down arrow has no effect after you add text on a line >> preceding a blan

Integrated: 8282402: Create a regression test for JDK-4666101

2022-03-03 Thread Manukumar V S
On Fri, 25 Feb 2022 15:37:10 GMT, Manukumar V S wrote: > Create a regression test for > [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). > > DESCRIPTION OF THE ACTUAL PROBLEM : > In a JEditorPane, the down arrow has no effect after you add text on a line > preceding a blank lin

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v8]

2022-03-03 Thread Alexey Ivanov
On Tue, 1 Mar 2022 23:27:57 GMT, DamonGuy wrote: >> Html does not fit in JButton at certain sizes because default Insets cause >> html to be displayed off-center. >> >> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable >> clipping if html does not fit, similar to re

Re: RFR: 8282577: ICC_Profile.setTagData() invalidates the profile [v2]

2022-03-03 Thread Phil Race
> As per the bug eval, we are returning a pointer to a native raw LittleCMS > profile and it should be a cooked one. > The simple test fails before the fix with > ~/jdk17/Contents/Home/bin/java SetTagDataValidation > > Exception in thread "main" java.awt.color.CMMEx

Re: RFR: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile [v3]

2022-03-03 Thread Phil Race
> As per the bug eval, we are returning a pointer to a native raw LittleCMS > profile and it should be a cooked one. > The simple test fails before the fix with > ~/jdk17/Contents/Home/bin/java SetTagDataValidation > > Exception in thread "main" java.awt.color.CMMEx

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v9]

2022-03-03 Thread DamonGuy
> Html does not fit in JButton at certain sizes because default Insets cause > html to be displayed off-center. > > Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable > clipping if html does not fit, similar to regular text. AquaButtonUI.java now > detects when html d

Re: RFR: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile [v3]

2022-03-03 Thread Phil Race
On Thu, 3 Mar 2022 21:27:36 GMT, Phil Race wrote: >> As per the bug eval, we are returning a pointer to a native raw LittleCMS >> profile and it should be a cooked one. >> The simple test fails before the fix with >> ~/jdk17/Contents/Home/bin/java SetTagDataValidation >

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v9]

2022-03-03 Thread Alexey Ivanov
On Thu, 3 Mar 2022 21:27:45 GMT, DamonGuy wrote: >> Html does not fit in JButton at certain sizes because default Insets cause >> html to be displayed off-center. >> >> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable >> clipping if html does not fit, similar to re

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v8]

2022-03-03 Thread Alexey Ivanov
On Thu, 3 Mar 2022 20:42:16 GMT, Alexey Ivanov wrote: >> DamonGuy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated test to be headless using BufferedImage. > > test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.j

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v10]

2022-03-03 Thread DamonGuy
> Html does not fit in JButton at certain sizes because default Insets cause > html to be displayed off-center. > > Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable > clipping if html does not fit, similar to regular text. AquaButtonUI.java now > detects when html d

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v2]

2022-03-03 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - adjusted pixels to check for border - typo - reverted old change, swapped order of paintin

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor

2022-03-03 Thread Alisen Chung
On Fri, 11 Feb 2022 23:44:22 GMT, Alisen Chung wrote: > Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping I've updated the fix to stop overdrawing, please review @mrserb @prrace @prsadhuk - PR: https://git.openjdk.java.net/jdk/pull/7449

Re: RFR: 8282343: Create a regression test for JDK-4518432 [v2]

2022-03-03 Thread Manukumar V S
> Create a regression test for > [JDK-4518432](https://bugs.openjdk.java.net/browse/JDK-4518432). > > Issue: Copying from JTree and then changing the data in the component that > was copied from, can cause pastes to use >the new edited data. > > This test verifies that copying from

Re: RFR: 8282234: Create a regression test for JDK-4532513 [v3]

2022-03-03 Thread Manukumar V S
> Create a regression test for > [JDK-4532513](https://bugs.openjdk.java.net/browse/JDK-4532513). > This test verifies that the DefaultCaret doesn't requests focus in mouseClick > and mousePressed causing the associated input verifier to fire twice. > As per [JDK-4532513](https://bugs.openjdk.jav

Re: RFR: 8282234: Create a regression test for JDK-4532513 [v2]

2022-03-03 Thread Manukumar V S
On Wed, 23 Feb 2022 07:13:25 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4532513](https://bugs.openjdk.java.net/browse/JDK-4532513). >> This test verifies that the DefaultCaret doesn't requests focus in >> mouseClick and mousePressed causing the associated input verifier t

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-03 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Revert dialogInput. Add Bolditalic --

RFR: 8282640: Create a test for JDK-4740761

2022-03-03 Thread Srinivas Mandalika
Create a test for [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761) The issue observed is in a JFrame with a JTextField and a JScrollPane which contains focused component. When the JScrollPane was is removed from its parent, focus stays with the the scroller of the removed JScrollP