Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-02-05 Thread Phil Race
On Fri, 4 Feb 2022 22:34:47 GMT, lawrence.andrews wrote: >> This testcase covers both old and new api ( api added in jdk17 >> getAccessibleAction(), getAccessibleActionCount() , >> getAccessibleActionDescription ) >> >> @shurymury >> @savoptik > > lawrence.andrews has updated the pull reques

Re: RFR: 8166050: partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method

2022-02-05 Thread Phil Race
On Thu, 3 Feb 2022 06:59:35 GMT, Prasanta Sadhukhan wrote: > The uninitialized "partialArray" in NPrintWriter.println() can cause NPE in > System.arraycopy . > But it is seen that NPrintWriter class embedded in TagStack class file cannot > be used by application as it is not a public class an

Re: RFR: 8280820: Clean up bug8033699 and bug8075609.java tests: regtesthelpers aren't used

2022-02-05 Thread Phil Race
On Wed, 2 Feb 2022 13:38:36 GMT, Alexey Ivanov wrote: > Removed references to `regtesthelpers` libarary which isn't used. > Organised imports and replaced anonymous classes with lambda expressions. > > Put `waitForIdle` before the test execution starts and moved the frame to the > centre of the

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v2]

2022-02-05 Thread Phil Race
On Thu, 3 Feb 2022 23:35:42 GMT, DamonGuy wrote: >> Html does not fit in JButton at certain sizes because default Insets cause >> html to be displayed off-center. >> >> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable >> clipping if html does not fit, similar to re

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v2]

2022-02-05 Thread Phil Race
On Fri, 4 Feb 2022 16:45:38 GMT, lawrence.andrews wrote: >> 1) Removed =yesno that was causing the test to fail with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> After removing =yesno, test was just passing without user inter

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-02-05 Thread Phil Race
On Thu, 27 Jan 2022 22:11:27 GMT, Harshitha Onkar wrote: > Updated JTable's tableChanged() method docs to explicitly mention the > coordinate system of the rows and columns. Unless your investigation uncovers new information, it seems like this PR will be withdrawn and the bug report closed as

Re: RFR: 8241192: [macosx] Wrong letter typed after ´ symbol when using Finnish layout

2022-02-05 Thread Phil Race
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan wrote: > If we press " ´ " (on U.S. keyboard layout it is the [+] button just before > the [delete] button), and then press "s" , 2 "´" characters are entered in a > text field instead of "´s" with "Finish" keyboard layout. > This is because