On Wed, 2 Feb 2022 09:46:14 GMT, Artem Semenov wrote:
> There are several source files in
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL
> header, need to check if they should be changed to GPL+CP.
@forantar @azuev-java please review.
-
PR: https://git.o
There are several source files in
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL header,
need to check if they should be changed to GPL+CP.
-
Commit messages:
- 8280956 Re-examine copyright headers on files in
src/java.desktop/macosx/native/libawt_lwawt/awt
On Mon, 10 Jan 2022 05:25:51 GMT, Prasanta Sadhukhan
wrote:
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
This pull request has now been int
Removed references to `regtesthelpers` libarary which isn't used.
Organised imports and replaced anonymous classes with lambda expressions.
Put `waitForIdle` before the test execution starts and moved the frame to the
centre of the screen.
The CI with the updated tests is green.
-
On Wed, 2 Feb 2022 13:38:36 GMT, Alexey Ivanov wrote:
> Removed references to `regtesthelpers` libarary which isn't used.
> Organised imports and replaced anonymous classes with lambda expressions.
>
> Put `waitForIdle` before the test execution starts and moved the frame to the
> centre of the
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote:
>> This tests the behaviour of the method JRootPane.setDefaultButton() in
>> different platforms with different LAFs.
>> As per the spec
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul
On Wed, 2 Feb 2022 09:46:14 GMT, Artem Semenov wrote:
> There are several source files in
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL
> header, need to check if they should be changed to GPL+CP.
Looks good to me.
-
Marked as reviewed by kizune (Review
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote:
>> The proposed fix makes fonts with and without fallback components
>> distinguishable (in terms of `equals` method), so that
>> font metrics cache (and other similar code) can handle them separately. This
>> is achieved by adding a new boo
On Tue, 1 Feb 2022 02:44:04 GMT, Sergey Bylokhov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> tagged test case as mac only
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaTableHeaderBorder.java line
>
On Wed, 2 Feb 2022 09:46:14 GMT, Artem Semenov wrote:
> There are several source files in
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL
> header, need to check if they should be changed to GPL+CP.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.
On Wed, 2 Feb 2022 18:32:10 GMT, Phil Race wrote:
> Serialization of Font objects is just serializing the fields liek name and
> style and size but there's no guarantee that it will behave the same .. I
> mean if I serialize Segoe UI on WIndows and try to deserialize it on Linux
> nothing in t
On Tue, 1 Feb 2022 16:11:52 GMT, DamonGuy wrote:
> Html does not fit in JButton at certain sizes because default Insets cause
> html to be displayed off-center.
>
> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
> clipping if html does not fit, similar to regular
Html does not fit in JButton at certain sizes because default Insets cause html
to be displayed off-center.
Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
clipping if html does not fit, similar to regular text. AquaButtonUI.java now
detects when html does not fit,
On Tue, 1 Feb 2022 16:11:52 GMT, DamonGuy wrote:
> Html does not fit in JButton at certain sizes because default Insets cause
> html to be displayed off-center.
>
> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
> clipping if html does not fit, similar to regular
On Wed, 2 Feb 2022 18:38:21 GMT, Harshitha Onkar wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaTableHeaderBorder.java
>> line 108:
>>
>>> 106: final int newHeight = height;
>>> 107:
>>> 108: painter.paint(g, c, newX - 1, newY - 1, newWidth + 1,
>>> newHeight + 1)
On Wed, 2 Feb 2022 07:44:31 GMT, Prasanta Sadhukhan
wrote:
> The JBS says "This is reproducible with the Mac default (Aqua) look and feel;
> using another LAF (Metal for instance) seems to position the ImageView
> correctly." so it seems to be a mac issue not generic, so fixing in shared
> co
On Wed, 2 Feb 2022 23:48:11 GMT, Sergey Bylokhov wrote:
>> @mrserb It is the size of component + border. The component being painted
>> here is `DefaultTableCellHeaderRenderer`.
>>
>> Tested under two cases
>> 1. Decreasing x & y, keeping width & height same as above - Border gets
>> drawn i
On Thu, 3 Feb 2022 01:43:07 GMT, DamonGuy wrote:
> > The JBS says "This is reproducible with the Mac default (Aqua) look and
> > feel; using another LAF (Metal for instance) seems to position the
> > ImageView correctly." so it seems to be a mac issue not generic, so fixing
> > in shared code
The uninitialized "partialArray" in NPrintWriter.println() can cause NPE in
System.arraycopy .
But it is seen that NPrintWriter class embedded in TagStack class file cannot
be used by application as it is not a public class and not an inner class too
and also there's no object of it created in
On Wed, 2 Feb 2022 09:46:14 GMT, Artem Semenov wrote:
> There are several source files in
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL
> header, need to check if they should be changed to GPL+CP.
This pull request has now been integrated.
Changeset: fe547eac
Author
20 matches
Mail list logo
