Re: RFR: 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language [v2]

2022-01-27 Thread Prasanta Sadhukhan
> Devanagiri script was not rendered properly in macos after JDK-8068283 due to > incorporated check of utf16 string encoding should be more than 2 bytes is > not satisfied. > Additional check added in JDK-8132503 to ascertain if utf8 string encoding is > complex or not was also not satisfied b

Integrated: 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language

2022-01-27 Thread Prasanta Sadhukhan
On Thu, 6 Jan 2022 11:03:26 GMT, Prasanta Sadhukhan wrote: > Devanagiri script was not rendered properly in macos after JDK-8068283 due to > incorporated check of utf16 string encoding should be more than 2 bytes is > not satisfied. > Additional check added in JDK-8132503 to ascertain if utf8

Re: RFR: 8278908: [macOS] Unexpected text normalization on pasting from clipboard

2022-01-27 Thread Dmitry Batrak
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote: > The fix just removes the explicit normalization of text obtained from system > clipboard in JDK code, as I've found no > good justification for such a normalization, at least for the latest macOS > version. > The same fix was performed in

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-27 Thread Prasanta Sadhukhan
On Thu, 27 Jan 2022 09:25:04 GMT, Prasanta Sadhukhan wrote: >> A new test case was added to test the fix as there was no corresponding test >> case present for this issue previously. > > test/jdk/javax/swing/JTableHeader/8016524/Bug8016524.java line 114: > >> 112: throw new Runtime

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-27 Thread Prasanta Sadhukhan
On Wed, 26 Jan 2022 00:12:17 GMT, Harshitha Onkar wrote: > A new test case was added to test the fix as there was no corresponding test > case present for this issue previously. Changes requested by psadhukhan (Reviewer). test/jdk/javax/swing/JTableHeader/8016524/Bug8016524.java line 26: > 24

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

2022-01-27 Thread Tejpal Rebari
On Mon, 24 Jan 2022 09:38:09 GMT, Prasanta Sadhukhan wrote: > Few methods and classes were deprecated in JDK-8049700 where it was decided > to add forRemoval in jdk19. > Added "forRemoval" to start the process of removing in near future jdk > release. Marked as reviewed by trebari (Committer

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Sergey Bylokhov
On Wed, 26 Jan 2022 21:38:05 GMT, Alexey Ivanov wrote: > I wonder if a similar problem exist on Windows and Linux. The pixelArray is > allocated as new int[bounds.width*bounds.height] in both. And for macOS too: > CRobot.getRGBPixels allocates the array of size bounds.width*bounds.height, > sh

Re: RFR: 8264666: Reuse Math.multiplyExact/addExact in the LCMSImageLayout class

2022-01-27 Thread Sergey Bylokhov
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote: > - The hand-crafted methods for addition and multiplication are replaced by > the "Math" versions. > - Cleanup: the usage of do/while(false) is removed not now - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

2022-01-27 Thread Kevin Rushforth
On Mon, 24 Jan 2022 09:38:09 GMT, Prasanta Sadhukhan wrote: > Few methods and classes were deprecated in JDK-8049700 where it was decided > to add forRemoval in jdk19. > Added "forRemoval" to start the process of removing in near future jdk > release. This needs a CSR. Please issue the `/csr

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v2]

2022-01-27 Thread lawrence . andrews
> 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader can read Emoji also. > 3) Now user can user arrow keys to navig

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v3]

2022-01-27 Thread lawrence . andrews
> 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader can read Emoji also. > 3) Now user can user arrow keys to navig

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v2]

2022-01-27 Thread lawrence . andrews
On Thu, 27 Jan 2022 19:56:20 GMT, lawrence.andrews wrote: >> 1) Test scenario was just showing test instruction with JTextArea. So added >> the JTextArea as the instruction and method says. >> 2) JTextArea is filled with contents so that and an Emoji character making >> sure that screen reade

RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-27 Thread Harshitha Onkar
Updated JTable's tableChanged() method docs to explicitly mention the coordinate system of the rows and columns. - Commit messages: - updated JTable docs for tableChanged method Changes: https://git.openjdk.java.net/jdk/pull/7253/files Webrev: https://webrevs.openjdk.java.net/?rep

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Sergey Bylokhov
On Thu, 27 Jan 2022 18:46:53 GMT, Phil Race wrote: > But why are X11 and Windows fine with no scale ? Since the coordinates are in the device space, and we pass this coordinates to the OS as is, and the OS returns the images of the requested size we do not need to use a scale there. Unlike mac

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-27 Thread Phil Race
On Thu, 27 Jan 2022 22:11:27 GMT, Harshitha Onkar wrote: > Updated JTable's tableChanged() method docs to explicitly mention the > coordinate system of the rows and columns. src/java.desktop/share/classes/javax/swing/JTable.java line 4423: > 4421: * coordinate system of the view for the r

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Sergey Bylokhov
On Fri, 28 Jan 2022 00:45:46 GMT, Phil Race wrote: > * I still see a need for a safety check in native code I can add some check but which one? In the native we should use the bounds we passed from java side, the problem is that we pass "1 * scale" = 'scale", but allocate the array as "new

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-27 Thread Harshitha Onkar
On Fri, 28 Jan 2022 00:44:07 GMT, Phil Race wrote: >> Updated JTable's tableChanged() method docs to explicitly mention the >> coordinate system of the rows and columns. > > src/java.desktop/share/classes/javax/swing/JTable.java line 4423: > >> 4421: * coordinate system of the view for the

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-27 Thread Phil Race
On Fri, 28 Jan 2022 02:13:46 GMT, Harshitha Onkar wrote: >> src/java.desktop/share/classes/javax/swing/JTable.java line 4423: >> >>> 4421: * coordinate system of the view for the row; the appropriate >>> 4422: * mapping to the view coordinate system is performed by this >>> 4423:

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Phil Race
On Fri, 28 Jan 2022 01:13:56 GMT, Sergey Bylokhov wrote: > > ``` > > * I still see a need for a safety check in native code > > ``` > > > I can add some check but which one? In the native we should use the bounds we > passed from java side, the problem is that we pass "1 * scale" = 'scale", bu

Re: RFR: 8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

2022-01-27 Thread Prasanta Sadhukhan
On Mon, 24 Jan 2022 09:38:09 GMT, Prasanta Sadhukhan wrote: > Few methods and classes were deprecated in JDK-8049700 where it was decided > to add forRemoval in jdk19. > Added "forRemoval" to start the process of removing in near future jdk > release. CSR added .JDK-8280846. Please review -

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-27 Thread Sergey Bylokhov
On Fri, 28 Jan 2022 04:03:00 GMT, Phil Race wrote: >A pointer to the destination in memory where the drawing is to be rendered. >The size of this memory block should be at least (bytesPerRow*height) bytes. >and picWidth * sizeof(jint), is bytes per row. So if it the Java array pixels is just on