RFR: 8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

Few methods and classes were deprecated in JDK-8049700 where it was decided to add forRemoval in jdk19. Added "forRemoval" to start the process of removing in near future jdk release. - Commit messages: - 8264743: Add forRemoval for deprecated classes and method in javax/swing/pla

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

On Mon, 24 Jan 2022 06:00:02 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java >> line 353: >> >>> 351: * File(parent, fileName) except when the parent and child >>> are both >>> 352: * special folders, in which case the Fil

Integrated: 8274751: Drag And Drop hangs on Windows

On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote: > When an object is moved from one window (DnD source) to another window (DnD > target) the first window may also be considered as a DnD target and the > native OS sends corresponding events to it. That event processing clears > isInDoDrag

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by dfuchs (Reviewer). LGTM. I hope in the future IDEs will pick that rule up and offer some help when writing `{@link }` `@see`... - PR: https://git

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

On Mon, 24 Jan 2022 11:00:37 GMT, Daniel Fuchs wrote: > LGTM. I hope in the future IDEs will pick that rule up and offer some help > when writing `{@link }` `@see`... They will do it quicker, if you create new or support existing bugs in their bug trackers. - PR: https://git.open

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

On Mon, 24 Jan 2022 10:51:00 GMT, Alexey Ivanov wrote: >> It is already mentioned in getSystemDisplayName, getSystemTypeDescription, >> getSystemIcon, isRoot. Anyways, I have removed the linkage for the new >> addition as it will not be able to resolve. > > If `ShellFolder` remains mentioned, I

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Is that a wrong bug? If you are talking about module-prefix syntax for links, then it was introduced in JDK 15; JDK-8164408: Add module support for @see, @link and @linkplain javado

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

On Mon, 24 Jan 2022 11:34:04 GMT, Alexey Ivanov wrote: >> Since it is mentioned in other places, I would rather not scrap it. Also, >> since in most places it is mentioned as a non-link value, I chose to modify >> it. > > The `` element does not create a link, it uses monospace font to render

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

On Mon, 24 Jan 2022 11:28:06 GMT, Prasanta Sadhukhan wrote: >> If `ShellFolder` remains mentioned, I'd rather use >> `ShellFolder` as it was done originally. >> >> I guess Sergey challenged the fact of referencing `ShellFolder`. The fact >> that it could be `ShellFolder` rather than `File` is

Re: RFR: 8274751: Drag And Drop hangs on Windows

On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote: > When an object is moved from one window (DnD source) to another window (DnD > target) the first window may also be considered as a DnD target and the > native OS sends corresponding events to it. That event processing clears > isInDoDrag

Re: RFR: 8274751: Drag And Drop hangs on Windows

On Mon, 24 Jan 2022 14:26:33 GMT, svedin wrote: > Will this be backported to java 8 and 11? I will port the fix to Oracle JDK 8, 11 and 17 - PR: https://git.openjdk.java.net/jdk/pull/7125

Re: RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher [v2]

> There is possible NPE, when trying to play AudioClip > > import java.applet.AudioClip; > import java.io.IOException; > import java.net.URL; > > > public class AudioNpe { > public static void main(String[] args) throws IOException, > InterruptedException { > URL url = new > URL("h

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and @link

Integrated: 8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs

On Tue, 11 Jan 2022 15:25:37 GMT, Alexey Ivanov wrote: > Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener: > ‘Constucts’ → ‘Constructs’. > Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the > list’. > > I also organised the imports which replac

Integrated: 8279794: Fix typos in BasicScrollBarUI: Laysouts a vertical scroll bar

On Tue, 11 Jan 2022 15:35:06 GMT, Alexey Ivanov wrote: > Fixed the typo in the layout methods: “Laysouts a…” → “Lays out a…”. > > The doc for `layoutHScrollbar` incorrectly referred to _vertical_ scroll bar > rather than horizontal one. > > > I also expanded the wildcard imports. This pull r

Integrated: 8279798: Javadoc for BasicTabbedPaneUI is inconsistent

On Tue, 11 Jan 2022 15:32:04 GMT, Alexey Ivanov wrote: > A number of methods in BasicTabbedPaneUI uses the imperative form of the verb > in the documentation instead of the third-person form which describes what > the method does. > > For consistency, I updated such descriptions to use the thi

Integrated: 8279861: Clarify 'rect' parameters and description of paintTabBorder method in BasicTabbedPaneUI

On Tue, 11 Jan 2022 15:50:48 GMT, Alexey Ivanov wrote: > The protected methods `paintTab` and `paintFocusIndicator` accept the `rect` > parameter which is documented as _“rectangles”_. I suggest updating this > description to a more descriptive: _“the tab rectangles”_ as the array > contains t

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux

On Mon, 24 Jan 2022 07:49:30 GMT, Maxim Kartashev wrote: > Can you elaborate, please? Do you mean that this custom JDK would > synthetically change `X11GraphicsDevice.screen` at the "right" time? Yes, at the "right" time and the "right" number of monitors. > > I am not sure that it is possible

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links

On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by aivanov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat

Re: Kindly request your attention for a really annoying visual Java bug on Linux Mint

Hello Stefan, On 23/01/2022 18:44, Stefan Reich wrote: Hello Alexey, thanks a lot for investigating and submitting the bug. I don't think I can sign up at bugs.openjdk.java.net directly, right? No, you can't. You can submit a bug report using https://bugrepor

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]

> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since t

Integrated: JDK-8280492: Use cross-module syntax for cross-module links

On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d Stat

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat