Re: RFR: 8274751: Drag And Drop hangs on Windows

2022-01-20 Thread Dmitry Markov
On Wed, 19 Jan 2022 22:55:38 GMT, Sergey Bylokhov wrote: > Is it possible to add a test case for this bug? The test will require some extra actions such as interaction with a native app, presence of a file to move between Java and native app, etc. I do not think it's really worth it. So I adde

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-20 Thread Alexey Ivanov
On Thu, 20 Jan 2022 06:12:29 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-20 Thread Alexey Ivanov
On Thu, 20 Jan 2022 15:11:37 GMT, Alexey Ivanov wrote: > Shall we indent `serialVersionUID`? It's for `BCSChild` but its indentation > suggests it's for the surrounding class. It's right below the class declaration. - PR: https://git.openjdk.java.net/jdk/pull/7004

Re: RFR: 8278472: Invalid value set to CANDIDATEFORM structure

2022-01-20 Thread Alexey Ivanov
On Wed, 19 Jan 2022 23:12:10 GMT, Sergey Bylokhov wrote: > This change was done under https://bugs.openjdk.java.net/browse/JDK-8147842 > where the CFS_CANDIDATEPOS was changed to the CFS_POINT. Please check that > the old bug will not be reproduced again. see > http://hg.openjdk.java.net/jdk9/

Re: RFR: 8278472: Invalid value set to CANDIDATEFORM structure

2022-01-20 Thread Sergey Bylokhov
On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov wrote: > According to the Windows API reference, `dwStyle` of > [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform) > structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So, > `CFS_POINT` is

Re: RFR: 8274751: Drag And Drop hangs on Windows

2022-01-20 Thread Sergey Bylokhov
On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote: > When an object is moved from one window (DnD source) to another window (DnD > target) the first window may also be considered as a DnD target and the > native OS sends corresponding events to it. That event processing clears > isInDoDrag

Re: RFR: 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language

2022-01-20 Thread Phil Race
On Thu, 6 Jan 2022 11:03:26 GMT, Prasanta Sadhukhan wrote: > Devanagiri script was not rendered properly in macos after JDK-8068283 due to > incorporated check of utf16 string encoding should be more than 2 bytes is > not satisfied. > Additional check added in JDK-8132503 to ascertain if utf8

Integrated: 8278472: Invalid value set to CANDIDATEFORM structure

2022-01-20 Thread Alexey Ivanov
On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov wrote: > According to the Windows API reference, `dwStyle` of > [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform) > structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So, > `CFS_POINT` is

Re: RFR: 8274751: Drag And Drop hangs on Windows

2022-01-20 Thread Dmitry Markov
On Thu, 20 Jan 2022 19:29:48 GMT, Sergey Bylokhov wrote: > Just for confirmation - it is not possible to reproduce using the second > forked java app instead of the native app? I could not reproduce the issue doing DnD between two java windows - PR: https://git.openjdk.java.net/jd

Re: RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-20 Thread Sergey Bylokhov
On Sun, 14 Nov 2021 20:02:27 GMT, Andrey Turbanov wrote: > There is possible NPE, when trying to play AudioClip > > import java.applet.AudioClip; > import java.io.IOException; > import java.net.URL; > > > public class AudioNpe { > public static void main(String[] args) throws IOException,

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-20 Thread Sergey Bylokhov
On Thu, 20 Jan 2022 06:12:29 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat