Very small change fixing wrong strings "Falied" in a couple of tests.
-
Commit messages:
- JDK-8280157
Changes: https://git.openjdk.java.net/jdk/pull/7142/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7142&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-828
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote:
> The fix just removes the explicit normalization of text obtained from system
> clipboard in JDK code, as I've found no
> good justification for such a normalization, at least for the latest macOS
> version.
> The same fix was performed in
On Wed, 19 Jan 2022 06:21:04 GMT, Prasanta Sadhukhan
wrote:
>> Fixed the broken link with appropriate link to swing document.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add closing tag
Marked as reviewed by aiv
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
Marked as reviewed by egahlin (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7142
On Tue, 18 Jan 2022 18:59:58 GMT, Alisen Chung wrote:
>> Adjusted the AquaLF scrollbar to account for border inset settings when
>> dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7142
On Wed, 19 Jan 2022 09:19:00 GMT, Matthias Baesken wrote:
> Very small change fixing wrong strings "Falied" in a couple of tests.
This pull request has now been integrated.
Changeset: 8931c122
Author:Matthias Baesken
URL:
https://git.openjdk.java.net/jdk/commit/8931c12258a39cabda2cd
On Fri, 12 Nov 2021 19:48:36 GMT, Alisen Chung wrote:
> Adjusted the AquaLF scrollbar to account for border inset settings when
> dragging the thumb and clicking on the track.
This pull request has now been integrated.
Changeset: 84fa0d8c
Author:Alisen Chung
Committer: Alexey Ivanov
URL:
On Tue, 18 Jan 2022 16:30:07 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review fix
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 120:
>
>> 118: /**
>> 119:
On Tue, 21 Dec 2021 15:18:40 GMT, Alexey Ivanov wrote:
> According to the Windows API reference, `dwStyle` of
> [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
> structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
> `CFS_POINT` is
On Tue, 21 Dec 2021 15:18:40 GMT, Alexey Ivanov wrote:
> According to the Windows API reference, `dwStyle` of
> [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
> structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
> `CFS_POINT` is
According to the Windows API reference, `dwStyle` of
[`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
`CFS_POINT` is wrong here.
There are two instances in `AwtComponent::SetCandida
On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov wrote:
> According to the Windows API reference, `dwStyle` of
> [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
> structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
> `CFS_POINT` is
On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov wrote:
> According to the Windows API reference, `dwStyle` of
> [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
> structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
> `CFS_POINT` is
On Sat, 8 Jan 2022 00:42:18 GMT, Alexandre Iline wrote:
> Tests are based on SwingSet2 application.
> Test instructions are loaded from HTML files.
>
> See readme for more info.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6993
On Tue, 18 Jan 2022 17:28:59 GMT, Alexey Ivanov wrote:
>> A number of methods in BasicTabbedPaneUI uses the imperative form of the
>> verb in the documentation instead of the third-person form which describes
>> what the method does.
>>
>> For consistency, I updated such descriptions to use th
On Tue, 18 Jan 2022 17:29:11 GMT, Alexey Ivanov wrote:
>> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener:
>> ‘Constucts’ → ‘Constructs’.
>> Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the
>> list’.
>>
>> I also organised the imports which
On Tue, 18 Jan 2022 17:29:07 GMT, Alexey Ivanov wrote:
>> Fixed the typo in the layout methods: “Laysouts a…” → “Lays out a…”.
>>
>> The doc for `layoutHScrollbar` incorrectly referred to _vertical_ scroll bar
>> rather than horizontal one.
>>
>>
>> I also expanded the wildcard imports.
>
> A
On Sat, 8 Jan 2022 00:42:18 GMT, Alexandre Iline wrote:
> Tests are based on SwingSet2 application.
> Test instructions are loaded from HTML files.
>
> See readme for more info.
This pull request has now been integrated.
Changeset: 5523ddeb
Author:Alexandre Iline
URL:
https://git
On Sun, 14 Nov 2021 20:02:27 GMT, Andrey Turbanov wrote:
> There is possible NPE, when trying to play AudioClip
>
> import java.applet.AudioClip;
> import java.io.IOException;
> import java.net.URL;
>
>
> public class AudioNpe {
> public static void main(String[] args) throws IOException,
On Tue, 11 Jan 2022 15:50:48 GMT, Alexey Ivanov wrote:
> The protected methods `paintTab` and `paintFocusIndicator` accept the `rect`
> parameter which is documented as _“rectangles”_. I suggest updating this
> description to a more descriptive: _“the tab rectangles”_ as the array
> contains t
On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote:
> When an object is moved from one window (DnD source) to another window (DnD
> target) the first window may also be considered as a DnD target and the
> native OS sends corresponding events to it. That event processing clears
> isInDoDrag
Two edits.
-
Commit messages:
- Another year
- year
- Update DigestMD5Base.java
- 8279796: Fix typo: Constucts -> Constructs
Changes: https://git.openjdk.java.net/jdk/pull/7147/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7147&range=00
Issue: https://bugs.openjd
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote:
> Two edits.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7147
On Tue, 18 Jan 2022 17:29:11 GMT, Alexey Ivanov wrote:
>> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener:
>> ‘Constucts’ → ‘Constructs’.
>> Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the
>> list’.
>>
>> I also organised the imports which
On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote:
> When an object is moved from one window (DnD source) to another window (DnD
> target) the first window may also be considered as a DnD target and the
> native OS sends corresponding events to it. That event processing clears
> isInDoDrag
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote:
> Two edits.
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
line 727:
> 725: Handler handler;
> 726: /**
> 727: * Constructs a {@code DoubleClickListener}.
This change is under review
On Wed, 19 Jan 2022 22:57:06 GMT, Sergey Bylokhov wrote:
>> Two edits.
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
> line 727:
>
>> 725: Handler handler;
>> 726: /**
>> 727: * Constructs a {@code DoubleClickListener}.
>
> This chan
> Two edits.
Weijun Wang has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains two new commits
since the last revision:
- year
- Update DigestM
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote:
> Two edits.
This pull request has now been integrated.
Changeset: 98d96a77
Author:Weijun Wang
URL:
https://git.openjdk.java.net/jdk/commit/98d96a770756ffe3e7f5e4b82120e9fb484cad9a
Stats: 2 lines in 1 file changed: 0 ins; 0 de
On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov wrote:
> According to the Windows API reference, `dwStyle` of
> [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform)
> structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So,
> `CFS_POINT` is
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
- 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null"
when compiling
- 8272058: 25 Null pointer dereference defect groups in 4 files
On Thu, 20 Jan 2022 00:28:55 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 4616c13c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/4616c13c2f1ced8a8bdeed81f0469523932e91b5
Stats: 1732
On Fri, 22 Oct 2021 19:01:27 GMT, Phil Race wrote:
> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests
>
> The jtreg javax.sound tests are written in such a way that if a needed audio
> device
> or other platform resource is not available, they just exit with a "pass
On Thu, 13 Jan 2022 08:25:22 GMT, Andrey Turbanov wrote:
> Method `Class.isAssignableFrom` is often used in form of:
>
> if (clazz.isAssignableFrom(obj.getClass())) {
> Such condition could be simplified to more shorter and performarnt code
>
> if (clazz.isInstance(obj)) {
>
> Repl
On Thu, 13 Jan 2022 07:44:48 GMT, Prasanta Sadhukhan
wrote:
> Test is timing out on slower windows11 CI system. Increased the timeout and
> also adjusted autodelay time to more consistent time with other headful tests
> which makes test pass in windows11.
> Test job link in JBS.
This pull req
On Mon, 17 Jan 2022 06:25:59 GMT, Prasanta Sadhukhan
wrote:
> Fixed the broken link with appropriate link to swing document.
This pull request has now been integrated.
Changeset: 1022cbdf
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.java.net/jdk/commit/1022cbdf987af846e79b92d
On Tue, 18 Jan 2022 17:29:07 GMT, Alexey Ivanov wrote:
>> Fixed the typo in the layout methods: “Laysouts a…” → “Lays out a…”.
>>
>> The doc for `layoutHScrollbar` incorrectly referred to _vertical_ scroll bar
>> rather than horizontal one.
>>
>>
>> I also expanded the wildcard imports.
>
> A
On Tue, 18 Jan 2022 17:28:59 GMT, Alexey Ivanov wrote:
>> A number of methods in BasicTabbedPaneUI uses the imperative form of the
>> verb in the documentation instead of the third-person form which describes
>> what the method does.
>>
>> For consistency, I updated such descriptions to use th
On Tue, 11 Jan 2022 15:50:48 GMT, Alexey Ivanov wrote:
> The protected methods `paintTab` and `paintFocusIndicator` accept the `rect`
> parameter which is documented as _“rectangles”_. I suggest updating this
> description to a more descriptive: _“the tab rectangles”_ as the array
> contains t
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
42 matches
Mail list logo
