Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 05:10:57 GMT, Prasanta Sadhukhan wrote: >> Fixed the broken link with appropriate link to swing document. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Fix other links src/java.desktop/share/cl

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Prasanta Sadhukhan
On Tue, 18 Jan 2022 11:41:10 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix other links > > src/java.desktop/share/classes/javax/swing/package-info.java line 143: > >> 141: * at

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 11:48:27 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/package-info.java line 143: >> >>> 141: * at the Java Developer Connection SM >>> 142: * >> href="https://www.oracle.com/java/technologies/java-foundation-classes.html"; >>> 143:

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Prasanta Sadhukhan
On Tue, 18 Jan 2022 11:58:27 GMT, Alexey Ivanov wrote: >> Maybe we can use >> https://www.oracle.com/java/technologies/foundation-classes-faq.html > > Yeah, this looks better. JFC is Swing, so the FAQ page uses an outdated term. > Related links at the bottom of the page leads to J2SE 1.4.2 as a

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v4]

2022-01-18 Thread Prasanta Sadhukhan
> Fixed the broken link with appropriate link to swing document. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Remove JFC link - Changes: - all: https://git.openjdk.java.net/jdk/pull/7104/files - new: https:/

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 12:07:34 GMT, Prasanta Sadhukhan wrote: > In fact, I think the "JavaSE Training" link also is not relevant in this > swing package, maybe it should be put in overall parent overview page. Yeah, I agree it's not relevant for Swing. Do you refer to [Java SE at a Glance](htt

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 12:22:44 GMT, Alexey Ivanov wrote: >> Yes, the page looks outdated.. I don't think any new content has been added >> post jdk1.4.2. >> I can remove the link. >> In fact, I think the "JavaSE Training" link also is not relevant in this >> swing package, maybe it should be put

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Prasanta Sadhukhan
On Tue, 18 Jan 2022 12:25:56 GMT, Alexey Ivanov wrote: >>> In fact, I think the "JavaSE Training" link also is not relevant in this >>> swing package, maybe it should be put in overall parent overview page. >> >> Yeah, I agree it's not relevant for Swing. >> >> Do you refer to [Java SE at a >

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v4]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 12:18:55 GMT, Prasanta Sadhukhan wrote: >> Fixed the broken link with appropriate link to swing document. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Remove JFC link Marked as reviewed by aiv

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 12:26:20 GMT, Prasanta Sadhukhan wrote: > I guess in same way, it's more relevant to > https://docs.oracle.com/en/java/javase/17/docs/api/index.html page Yep! - PR: https://git.openjdk.java.net/jdk/pull/7104

RFR: 8274751: Drag And Drop hangs on Windows

2022-01-18 Thread Dmitry Markov
When an object is moved from one window (DnD source) to another window (DnD target) the first window may also be considered as a DnD target and the native OS sends corresponding events to it. That event processing clears isInDoDragDropLoop flag, which is currently used to indicate DnD operation,

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v5]

2022-01-18 Thread Prasanta Sadhukhan
> Fixed the broken link with appropriate link to swing document. Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision: - Update copyright year - Remove unneeded mentions - Changes: - all: https://git.openjdk.java.net/

Re: RFR: 8274751: Drag And Drop hangs on Windows

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 12:51:56 GMT, Dmitry Markov wrote: > When an object is moved from one window (DnD source) to another window (DnD > target) the first window may also be considered as a DnD target and the > native OS sends corresponding events to it. That event processing clears > isInDoDrag

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v5]

2022-01-18 Thread Alexey Ivanov
On Tue, 18 Jan 2022 13:03:07 GMT, Prasanta Sadhukhan wrote: >> Fixed the broken link with appropriate link to swing document. > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - Update copyright year > - Remove unneed

Re: [jdk18] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display [v4]

2022-01-18 Thread Alexey Ivanov
On Fri, 14 Jan 2022 17:31:09 GMT, Aleksandr Veselov wrote: >> Perform scaling while converting sizes and coordinates to provide correct >> positions of accessible elements on HiDPI screen and make hit-test work >> properly. It uses FontRenderContext to receive display scale without API >> cha

Integrated: 8280010: Remove double buffering of InputStream for Properties.load

2022-01-18 Thread Andrey Turbanov
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote: > `Properties.load` uses `java.util.Properties.LineReader`. LineReader already > buffers input stream. Hence wrapping InputStream in BufferedInputStream is > redundant. This pull request has now been integrated. Changeset: 9eb50a5e Auth

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v2]

2022-01-18 Thread Alexey Ivanov
On Mon, 17 Jan 2022 05:26:47 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/undo/UndoableEditSupport.java >> line 150: >> >>> 148: >>> 149: /** >>> 150: * Start UndoableEdit. >> >> What does it mean? Is it clear enough for the class which "managing >>

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v2]

2022-01-18 Thread Alexey Ivanov
On Mon, 17 Jan 2022 05:31:00 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat

Re: RFR: 8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs

2022-01-18 Thread Alexey Ivanov
On Wed, 12 Jan 2022 02:40:22 GMT, Sergey Bylokhov wrote: >> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener: >> ‘Constucts’ → ‘Constructs’. >> Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the >> list’. >> >> I also organised the imports whic

Re: RFR: 8279798: Javadoc for BasicTabbedPaneUI is inconsistent [v2]

2022-01-18 Thread Alexey Ivanov
> A number of methods in BasicTabbedPaneUI uses the imperative form of the verb > in the documentation instead of the third-person form which describes what > the method does. > > For consistency, I updated such descriptions to use the third-person form of > the verb. > > I fixed a couple of t

Re: RFR: 8279794: Fix typos in BasicScrollBarUI: Laysouts a vertical scroll bar [v2]

2022-01-18 Thread Alexey Ivanov
> Fixed the typo in the layout methods: “Laysouts a…” → “Lays out a…”. > > The doc for `layoutHScrollbar` incorrectly referred to _vertical_ scroll bar > rather than horizontal one. > > > I also expanded the wildcard imports. Alexey Ivanov has updated the pull request incrementally with one ad

Re: RFR: 8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs [v2]

2022-01-18 Thread Alexey Ivanov
> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener: > ‘Constucts’ → ‘Constructs’. > Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the > list’. > > I also organised the imports which replaced all wildcard imports with > specific class imports.

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2022-01-18 Thread Phil Race
On Wed, 22 Dec 2021 11:13:56 GMT, Tejesh R wrote: >> JListBox is invalid component. CellTableEditor Interface doesn't support >> JComboBox and JTree components. Hence its removed from Documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the l

Re: [jdk18] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display [v4]

2022-01-18 Thread Anton Tarasov
On Fri, 14 Jan 2022 17:31:09 GMT, Aleksandr Veselov wrote: >> Perform scaling while converting sizes and coordinates to provide correct >> positions of accessible elements on HiDPI screen and make hit-test work >> properly. It uses FontRenderContext to receive display scale without API >> cha

[jdk18] Integrated: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display

2022-01-18 Thread Aleksandr Veselov
On Fri, 24 Dec 2021 09:51:14 GMT, Aleksandr Veselov wrote: > Perform scaling while converting sizes and coordinates to provide correct > positions of accessible elements on HiDPI screen and make hit-test work > properly. It uses FontRenderContext to receive display scale without API > changes

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v14]

2022-01-18 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: made suggested changes - Changes: - all: https:

RFR: 8280054: BadSerializationTest and DragGestureEvent/DragGestureRecognizer constructors

2022-01-18 Thread Liam Miller-Cushon
Please consider this enhancement to `test/jdk/java/awt/dnd/BadSerializationTest/BadSerializationTest.java`, which simplifies the process of manually generating serialized test data by using reflection to generate invalid instances of `DragGestureEvent` and `DragGestureRecognizer`, instead of re

Re: RFR: 8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11

2022-01-18 Thread Alexander Zuev
On Thu, 13 Jan 2022 07:44:48 GMT, Prasanta Sadhukhan wrote: > Test is timing out on slower windows11 CI system. Increased the timeout and > also adjusted autodelay time to more consistent time with other headful tests > which makes test pass in windows11. > Test job link in JBS. Marked as rev

Integrated: 6465404: some problems in CellEditor related API docs

2022-01-18 Thread Tejesh R
On Tue, 30 Nov 2021 08:49:19 GMT, Tejesh R wrote: > JListBox is invalid component. CellTableEditor Interface doesn't support > JComboBox and JTree components. Hence its removed from Documentation. This pull request has now been integrated. Changeset: 44fe958c Author:TejeshR13 Committer: P

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v6]

2022-01-18 Thread Prasanta Sadhukhan
> Fixed the broken link with appropriate link to swing document. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Add closing tag - Changes: - all: https://git.openjdk.java.net/jdk/pull/7104/files - new: https:/

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v5]

2022-01-18 Thread Prasanta Sadhukhan
On Tue, 18 Jan 2022 15:10:46 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Remove unneeded mentions > > src/java.desktop/share/classes/javax/swing/package-in