RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-10 Thread Andrey Turbanov
There is possible NPE, when trying to play AudioClip import java.applet.AudioClip; import java.io.IOException; import java.net.URL; public class AudioNpe { public static void main(String[] args) throws IOException, InterruptedException { URL url = new URL("https://file-examples-com

Re: RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-10 Thread Sergey Bylokhov
On Sun, 14 Nov 2021 20:02:27 GMT, Andrey Turbanov wrote: > There is possible NPE, when trying to play AudioClip > > import java.applet.AudioClip; > import java.io.IOException; > import java.net.URL; > > > public class AudioNpe { > public static void main(String[] args) throws IOException,

Re: RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-10 Thread Andrey Turbanov
On Sun, 14 Nov 2021 20:02:27 GMT, Andrey Turbanov wrote: > There is possible NPE, when trying to play AudioClip > > import java.applet.AudioClip; > import java.io.IOException; > import java.net.URL; > > > public class AudioNpe { > public static void main(String[] args) throws IOException,

Re: RFR: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-10 Thread Andrey Turbanov
On Tue, 16 Nov 2021 02:46:45 GMT, Sergey Bylokhov wrote: >> There is possible NPE, when trying to play AudioClip >> >> import java.applet.AudioClip; >> import java.io.IOException; >> import java.net.URL; >> >> >> public class AudioNpe { >> public static void main(String[] args) throws IOEx

Withdrawn: 8233568: [TESTBUG] AWT event tests failing on MacOS

2022-01-10 Thread duke
On Thu, 21 Oct 2021 15:47:36 GMT, Alisen Chung wrote: > Tests passing on macos, so removing from ProblemList This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/6067

Re: RFR: JDK-8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15

2022-01-10 Thread Martin Doerr
On Tue, 4 Jan 2022 14:14:46 GMT, Matthias Baesken wrote: > Hello, please review this adjustment for recent SUSE Linux 15. > The font coding on UNIX, see setOsNameAndVersion in files > > src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java > src/java.desktop/unix/classes/sun/font/MFon

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v12]

2022-01-10 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/re

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v11]

2022-01-10 Thread Alisen Chung
On Fri, 7 Jan 2022 18:35:17 GMT, Alexey Ivanov wrote: >> The test does not fail for me on the build without the fix. It's confirmed >> by the image where scroll bar thumb is painted in the border. > >> The test does not fail for me on the build without the fix. It's confirmed >> by the image wh

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v11]

2022-01-10 Thread Alexey Ivanov
On Fri, 7 Jan 2022 18:35:17 GMT, Alexey Ivanov wrote: >> The test does not fail for me on the build without the fix. It's confirmed >> by the image where scroll bar thumb is painted in the border. > >> The test does not fail for me on the build without the fix. It's confirmed >> by the image wh

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module

2022-01-10 Thread Sergey Bylokhov
On Mon, 10 Jan 2022 05:25:51 GMT, Prasanta Sadhukhan wrote: > The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. src/java.desktop/share/classes/jav

Re: RFR: JDK-8279641: Create manual JTReg tests for Swing accessibility

2022-01-10 Thread Sergey Bylokhov
On Sat, 8 Jan 2022 00:42:18 GMT, Alexandre Iline wrote: > Tests are based on SwingSet2 application. > Test instructions are loaded from HTML files. > > See readme for more info. An initial question, which look and feel are we expected to test? Do we need to cover the default one, or it is up

Re: RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2022-01-10 Thread Sergey Bylokhov
On Tue, 14 Dec 2021 05:44:17 GMT, Prasanta Sadhukhan wrote: > Test seem to be failing in macos12.0.1 (although it does not seem to affect > 12.1) due to keypresses of "a", "a", "d" is not selecting "aad" but "ade" > which seems to point to the fact that 2 exclusive "a" keypress are considered

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2022-01-10 Thread Sergey Bylokhov
On Wed, 22 Dec 2021 11:13:56 GMT, Tejesh R wrote: >> JListBox is invalid component. CellTableEditor Interface doesn't support >> JComboBox and JTree components. Hence its removed from Documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the l

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v12]

2022-01-10 Thread Sergey Bylokhov
On Mon, 10 Jan 2022 16:59:28 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request with a new target base due to a > merge or a rebase. The incremental we

Re: RFR: 8278908: [macOS] Unexpected text normalization on pasting from clipboard

2022-01-10 Thread Sergey Bylokhov
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote: > The fix just removes the explicit normalization of text obtained from system > clipboard in JDK code, as I've found no > good justification for such a normalization, at least for the latest macOS > version. > The same fix was performed in

Re: RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2022-01-10 Thread Prasanta Sadhukhan
On Tue, 14 Dec 2021 05:44:17 GMT, Prasanta Sadhukhan wrote: > Test seem to be failing in macos12.0.1 (although it does not seem to affect > 12.1) due to keypresses of "a", "a", "d" is not selecting "aad" but "ade" > which seems to point to the fact that 2 exclusive "a" keypress are considered

Re: RFR: JDK-8279641: Create manual JTReg tests for Swing accessibility

2022-01-10 Thread Phil Race
On Tue, 11 Jan 2022 05:43:22 GMT, Sergey Bylokhov wrote: > An initial question, which look and feel are we expected to test? Do we need > to cover the default one, or it is up to someone to pass the correct L&F? Need in what context ? Who is "we" ? Test which ever L&Fs your distro wants to ce