RFR: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be aad

2021-12-02 Thread Prasanta Sadhukhan
Test is failing in macosx-12 in aarch64 system. Added stability fixes of delay after frame is visible, making frame to center of screen to make the test stable in macos12-aarch64 system too. Modified test passes in all CI platforms including osx-aarch64 system in osx11 and osx12. -

RFR: 8278119: ProblemList few headful test failing in macosx12-aarch64 system

2021-12-02 Thread Prasanta Sadhukhan
Few tests are failing on macos12-aarch64 systems due to mismatch in color value obtained from robot.getPixelColor and expected color. More details on the failures can be seen in JDK-8277816. Till the root cause is investigated, it is better to problemlist it as it causing failures in CI run. ---

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v10]

2021-12-02 Thread Laurent Bourgès
On Fri, 19 Nov 2021 19:09:54 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

Re: RFR: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-02 Thread Dmitry Batrak
On Wed, 1 Dec 2021 17:34:58 GMT, Phil Race wrote: > FWIW the rendering being present in the non-layout case is likely due to the > magic JRS fall back code .. some day we need to unify this so that at least > we are consistent. That's what I'm working on now - getting rid of `JRSFontCreateFal

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v7]

2021-12-02 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed robot mouse moves, use pixel colors to check -

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v4]

2021-12-02 Thread Alisen Chung
On Wed, 24 Nov 2021 06:07:31 GMT, Sergey Bylokhov wrote: >> Just updated the automation. I added a robot to try to move the thumb into >> the red zone, then had the robot click again to see if the thumb is under >> the cursor. If the behavior is correct, the thumb should have stopped before >>

Re: RFR: JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java

2021-12-02 Thread Lance Andersen
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote: > JDK-8276681: Malformed Javadoc inline tags in JDK source > jdk/internal/net/http/ResponseSubscribers.java Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6486

Re: RFR: JDK-8276681: Additional malformed Javadoc inline tags in JDK source [v2]

2021-12-02 Thread Tim Prinzing
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional comm

Re: RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v2]

2021-12-02 Thread Alexander Zuev
On Mon, 22 Nov 2021 19:13:11 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added bad_malloc handling >> Fixed insets >> Declaration and assignment are now joined > > src/java.desktop/wind

Re: RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

2021-12-02 Thread Alexander Zuev
> Made colorBits and maskBits arrays dynamic so they are allocated on heap > instead of stack. > Added regression test. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Eliminate potential resource leak. - Changes: -

RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-02 Thread Joe Darcy
In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. Therefore, it is now possible to enable the full doclint checks for the java.desktop module if the instances of warnings are suppressed. This patch does this; it would be preferable to address the doc warnings directly, but

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-02 Thread Jonathan Gibbons
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > does this; it wou

Withdrawn: 8274304: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-12-02 Thread duke
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov wrote: > The fix for 8274296 added uiScale=1 to some of the tests to fix the problem > of incorrect pixel color capture by the robot. > In both cases uiScale=1 or uiScale=2 the same call should be made to the > macOS. But if uiScale=1 is set we

Re: RFR: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad" [v2]

2021-12-02 Thread Prasanta Sadhukhan
> Test is failing in macosx-12 in aarch64 system. Added stability fixes of > delay after frame is visible, making frame to center of screen to make the > test stable in macos12-aarch64 system too. > Modified test passes in all CI platforms including osx-aarch64 system in > osx11 and osx12. Pras

RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
Updated sun.awt.util.IdentityArrayList and sun.awt.util.IdentityLinkedList - Commit messages: - Javadoc incorrect for IdentityArrayList, IdentityLinkedList - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openj

Withdrawn: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
On Fri, 3 Dec 2021 06:33:45 GMT, ANUPAM DEV wrote: > The following methods were having improper improper as they mentioned > 'equals()' while comparing two objects. The comments have been changed to > reflect the comparison of two objects using == operator. > > sun.awt.util.IdentityLinkedList#

RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
The documentation for following methods used equals() for object equality: sun.awt.util.IdentityLinkedList#contains sun.awt.util.IdentityArrayList#contains sun.awt.util.IdentityArrayList#indexOf sun.awt.util.IdentityArrayList#lastIndexOf sun.awt.util.IdentityArrayList#remove(java.lang.Object) I h