I missed a few places in https://bugs.openjdk.java.net/browse/JDK-8273168
-
Commit messages:
- [PATCH] Cleanup redundant boxing in java.desktop
Changes: https://git.openjdk.java.net/jdk/pull/5834/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5834&range=00
Issue: htt
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5794
On Wed, 6 Oct 2021 07:29:51 GMT, Andrey Turbanov
wrote:
> I missed a few places in https://bugs.openjdk.java.net/browse/JDK-8273168
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5834
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
looks good to me
-
Marked as reviewed by pbansal (Reviewer).
PR: https://git.openjdk.java.net
8274893: Update java.desktop classes to use try-with-resources
-
Commit messages:
- [PATCH] Use try-with-resources to close resources in java.desktop
- [PATCH] Use try-with-resources to close resources in java.desktop
- [PATCH] Use try-with-resources to close InputStream in java.de
On Wed, 6 Oct 2021 07:29:51 GMT, Andrey Turbanov
wrote:
> I missed a few places in https://bugs.openjdk.java.net/browse/JDK-8273168
Marked as reviewed by pbansal (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5834
StringBuffer is a legacy synchronized class. StringBuilder is a direct
replacement to StringBuffer which generally have better performance
-
Commit messages:
- [PATCH] Cleanup usages of StringBuffer in jdk tools modules
Changes: https://git.openjdk.java.net/jdk/pull/5433/files
Web
On Fri, 1 Oct 2021 22:37:05 GMT, Sergey Bylokhov wrote:
> > I think synthesizeMouseEnteredExitedEventsForAllWindows shouldn't be in
> > deliverMoveResizeEvent since there shouldn't be any mouseEnter/Exit events
> > during a resize or move
>
> Why do you think that if the window is moved/resize
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance
Marked as reviewed by sspitsyn (Reviewer).
-
PR: https://git.openjdk.java.net/jdk
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov wrote:
> The fix for 8274296 added uiScale=1 to some of the tests to fix the problem
> of incorrect pixel color capture by the robot.
> In both cases uiScale=1 or uiScale=2 the same call should be made to the
> macOS. But if uiScale=1 is set we
On Thu, 7 Oct 2021 15:01:48 GMT, Alisen Chung
wrote:
> I think mouseEvents are already posted by macos when the mouse enters the
> window thru fullscreen-resizing (green button) or tiling, so I think we don't
> need to synthesize additional events.
If we do not need to synthesize additional
On Thu, 7 Oct 2021 19:30:41 GMT, Phil Race wrote:
> I don't think "we" have a problem. I think there is a macOS bug.
In both cases, we should execute the same code and request the same number of
pixels(the one pixel) from the macOS. The robot native code should not be
affected by the uiScale p
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov wrote:
> The fix for 8274296 added uiScale=1 to some of the tests to fix the problem
> of incorrect pixel color capture by the robot.
> In both cases uiScale=1 or uiScale=2 the same call should be made to the
> macOS. But if uiScale=1 is set we
On Thu, 7 Oct 2021 22:59:16 GMT, Phil Race wrote:
> We already have several bugs problem listed and I do not want to exclude more
> tests than necessary that work everywhere including hidpi except on some
> specific h/w and are NOT related to hidpi So, in other words, leave it as it
> is. I th
On Mon, 20 Sep 2021 21:36:34 GMT, lawrence.andrews
wrote:
> Problem : Testcase was failing with parser exception
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> Fix : Removed =yesno and run the testcase and Test UI ( instruction and print
> dialog
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov wrote:
> The fix for 8274296 added uiScale=1 to some of the tests to fix the problem
> of incorrect pixel color capture by the robot.
> In both cases uiScale=1 or uiScale=2 the same call should be made to the
> macOS. But if uiScale=1 is set we
On Thu, 7 Oct 2021 23:41:37 GMT, Phil Race wrote:
> Once again, hi-dpi does not matter for these tests. It is not what they are
> trying to test and there is no other "hi-dpi" testing going on anyway on
> these other platforms
Why hiDPI does not matter for the tests like these
PaintNativeOnUp
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev
wrote:
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
I am fine with any solution but think the check will be simpler and safer, and
later we will be able to cha
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov wrote:
> The fix for 8274296 added uiScale=1 to some of the tests to fix the problem
> of incorrect pixel color capture by the robot.
> In both cases uiScale=1 or uiScale=2 the same call should be made to the
> macOS. But if uiScale=1 is set we
19 matches
Mail list logo
