RFR: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

2021-09-25 Thread Andrey Turbanov
No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough. - Commit messages: - [PATCH] Remove reentrant synchronized block in java.awt.Cursor.loadSystemCustomCursorProperties Changes: https://git.openjdk.java.net/jdk/pull/5597/files Webrev: https://webrevs.ope

Re: RFR: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

2021-09-25 Thread Sergey Bylokhov
On Tue, 21 Sep 2021 07:17:43 GMT, Andrey Turbanov wrote: > No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough. Marked as reviewed by serb (Reviewer). Looks fine. - PR: https://git.openjdk.java.net/jdk/pull/5597

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12

2021-09-25 Thread Prasanta Sadhukhan
On Thu, 23 Sep 2021 06:47:33 GMT, Prasanta Sadhukhan wrote: > java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java > is timing out every time on macOS 12 even though the test passed. > Looks like the the main process waits for child process created in t

Re: RFR: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

2021-09-25 Thread Pankaj Bansal
On Tue, 21 Sep 2021 07:17:43 GMT, Andrey Turbanov wrote: > No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough. Looks good to me - Marked as reviewed by pbansal (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5597

Re: RFR: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop [v3]

2021-09-25 Thread Сергей Цыпанов
> This is a continuation of > > - https://bugs.openjdk.java.net/browse/JDK-6736490 > - https://bugs.openjdk.java.net/browse/JDK-8035284 > - https://bugs.openjdk.java.net/browse/JDK-8145680 > - https://bugs.openjdk.java.net/browse/JDK-8251548 > > As mentioned in JDK-6736490: > > _An explicit init

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12

2021-09-25 Thread Sergey Bylokhov
On Thu, 23 Sep 2021 06:47:33 GMT, Prasanta Sadhukhan wrote: > java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java > is timing out every time on macOS 12 even though the test passed. > Looks like the the main process waits for child process created in t

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v2]

2021-09-25 Thread Phil Race
On Wed, 22 Sep 2021 08:05:03 GMT, Alisen Chung wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m line 485: >> >>> 483: } else if([lang isEqualToString:@"ru"]) { >>> 484: // checking for Russian characters >>> 485: offset += 0x0100; >> >> w

Re: RFR: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

2021-09-25 Thread Phil Race
On Tue, 21 Sep 2021 07:17:43 GMT, Andrey Turbanov wrote: > No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough. Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5597

Re: RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class [v7]

2021-09-25 Thread Phil Race
On Tue, 21 Sep 2021 08:01:32 GMT, Alexander Scherbatiy wrote: >> FontManagerFactory class uses reflection to load platform specific >> FontManager classes from "sun.font.fontmanager" property. >> >> Fix proposes creating FontManager platform specific classes directly in the >> similar way as

Re: RFR: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

2021-09-25 Thread Phil Race
On Fri, 24 Sep 2021 04:38:13 GMT, Sergey Bylokhov wrote: > Initially, the bug was discussed here: > https://stackoverflow.com/questions/35264582/why-is-multithreading-slowing-down/35264813 > > The root cause is that if for some reason directly or indirectly the color > transform object is share