Re: RFR: 8273684: Unnecessary Stack usage

2021-09-14 Thread Andrey Turbanov
On Tue, 14 Sep 2021 00:33:32 GMT, Bernd Eckenfels wrote: >Maybe better use addFirst(), for example in CommandProcessor there is a >comment that order matters (did not check it more closely), so it?s probably >best to not reverse orders in any place? In all other places (except HTMLReader), it

RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-14 Thread Masanori Yano
Could you please review the 7001973 fixes? On Windows, CopyAreaOOB.java fails with a blank window. The cause of this problem is that paint() works one time only. Painting area is not guaranteed when showing a window. I think this behavior should be removed for purpose of this test (`@summary:

Re: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1

2021-09-14 Thread Alexey Ushakov
On Mon, 13 Sep 2021 07:11:02 GMT, Sergey Bylokhov wrote: > > in a normal state (when the window is created) we don't need to flush the > > layer content faster than DisplayLink provide. > > But this is exactly related to the performance, no? When the RenderPerf test > is executed it should che

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction

2021-09-14 Thread lawrence . andrews
On Tue, 20 Jul 2021 23:54:20 GMT, lawrence.andrews wrote: > 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v2]

2021-09-14 Thread Artem Semenov
> We've extended the current implementation of TableAccessibility to make sure > that individual cells are voiced when navigating with the keyboard. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: 8271071 accessibility of a table on

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v2]

2021-09-14 Thread Artem Semenov
On Mon, 13 Sep 2021 14:47:30 GMT, Anton Tarasov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8271071 accessibility of a table on macOS lacks cell navigation > > src/java.desktop/macosx/native/libawt_lwawt/awt/a

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v2]

2021-09-14 Thread Anton Tarasov
On Tue, 14 Sep 2021 14:30:40 GMT, Artem Semenov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ColumnAccessibility.m >> line 52: >> >>> 50: } >>> 51: >>> 52: - (NSArray *)accessibilityChildren >> >> Could you please clarify why you removed this method? > > As the analysis of

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v3]

2021-09-14 Thread Artem Semenov
> We've extended the current implementation of TableAccessibility to make sure > that individual cells are voiced when navigating with the keyboard. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: It is not clear why we should manag

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v3]

2021-09-14 Thread Artem Semenov
On Tue, 14 Sep 2021 15:18:57 GMT, Anton Tarasov wrote: >> As the analysis of the a11y table hierarchy in numbers showed, this object >> has no children. From which I conclude that the columns should not have >> children. > > It is not clear why we should manage columns without children. Would i

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v3]

2021-09-14 Thread Anton Tarasov
On Tue, 14 Sep 2021 15:50:34 GMT, Artem Semenov wrote: >> We've extended the current implementation of TableAccessibility to make sure >> that individual cells are voiced when navigating with the keyboard. > > Artem Semenov has updated the pull request incrementally with one additional > commi

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-14 Thread Pankaj Bansal
On Tue, 14 Sep 2021 00:10:26 GMT, lawrence.andrews wrote: >> Problem : >> 1) Test case was failing with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yes >> 2) After removing =yes/no Parser exception is not seen but test UI will sho

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-14 Thread lawrence . andrews
On Tue, 14 Sep 2021 16:38:34 GMT, Pankaj Bansal wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor issue > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 126: > >> 124: instruc

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-14 Thread Chris Plummer
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 988: > 986:

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v4]

2021-09-14 Thread Alisen Chung
> removed support for running demo from applet for J2Ddemo and SwingSet2 > same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed > branch name) Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: alphabetized imports -

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction

2021-09-14 Thread Alexey Ivanov
On Tue, 20 Jul 2021 23:54:20 GMT, lawrence.andrews wrote: > 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she

Re: RFR: 8254841: Enter or Exit events are shouldn't be displayed while resizing

2021-09-14 Thread Pankaj Bansal
On Mon, 13 Sep 2021 18:03:39 GMT, Alisen Chung wrote: > Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. I have some suggestion for test 1. Access the swing components only on EDT thread. 2. The te

RFR: 8254841: Enter or Exit events are shouldn't be displayed while resizing

2021-09-14 Thread Alisen Chung
Added a resizing flag when the window is currently being resized to block mouseEntered and mouseExited events from being posted to that window. - Commit messages: - moved exceptions into test functions - accessing swing components on EDT thread, removed SpuriousExitEnter.java from

Re: RFR: 8254841: Enter or Exit events are shouldn't be displayed while resizing

2021-09-14 Thread Alexander Zuev
On Mon, 13 Sep 2021 18:03:39 GMT, Alisen Chung wrote: > Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/ResizeMouseExitEnterMisfire.java line

Re: RFR: 8254841: Enter or Exit events are shouldn't be displayed while resizing

2021-09-14 Thread Phil Race
On Mon, 13 Sep 2021 18:03:39 GMT, Alisen Chung wrote: > Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. test/jdk/ProblemList.txt line 872: > 870: java/awt/event/MouseEvent/SpuriousExitEnter/Spuri

Re: RFR: 8254841: Enter or Exit events are shouldn't be displayed while resizing

2021-09-14 Thread Kevin Rushforth
On Mon, 13 Sep 2021 18:03:39 GMT, Alisen Chung wrote: > Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. > @alisenchung alisenchung force-pushed the alisenchung:8254841 branch from > dd8d591 to e

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v2]

2021-09-14 Thread Alisen Chung
> Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: added bug ID to test -

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v2]

2021-09-14 Thread Sergey Bylokhov
On Tue, 14 Sep 2021 22:05:56 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v2]

2021-09-14 Thread Sergey Bylokhov
On Tue, 14 Sep 2021 22:05:56 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-14 Thread Sergey Bylokhov
On Tue, 14 Sep 2021 00:10:26 GMT, lawrence.andrews wrote: >> Problem : >> 1) Test case was failing with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yes >> 2) After removing =yes/no Parser exception is not seen but test UI will sho

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-14 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote: > Could you please review the 7001973 fixes? > > On Windows, CopyAreaOOB.java fails with a blank window. The cause of this > problem is that paint() works one time only. Painting area is not guaranteed > when showing a window. > > I think

Re: RFR: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

2021-09-14 Thread Sergey Bylokhov
On Thu, 9 Sep 2021 07:19:27 GMT, Prasanta Sadhukhan wrote: > Test fails on macOS12 since the check was only upto macOS11..Extended the > check for BigSurOrAbove. ok - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5434

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-14 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 23:20:52 GMT, Phil Race wrote: > > I suggest using the same order no need to think about which order is > > correct in which file, but simple as this: [#5401 > > (comment)](https://github.com/openjdk/jdk/pull/5401#issuecomment-917305195) > My point is that you can't point t

Re: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 [v2]

2021-09-14 Thread Sergey Bylokhov
On Fri, 10 Sep 2021 19:30:20 GMT, Alexey Ushakov wrote: >> Used setOpaque() method to set correct background of platform window > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 8273355: Lanai: Flickering on tooltip appeara

[email protected]

2021-09-14 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 02:49:01 GMT, Sergey Bylokhov wrote: > As discussed here https://github.com/openjdk/jdk/pull/1813 the test should > skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" > not "GTK". The ID="GTK" can be used instead. This pull request has now been in

Integrated: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7

2021-09-14 Thread Sergey Bylokhov
On Thu, 9 Sep 2021 07:27:10 GMT, Sergey Bylokhov wrote: > This bug was found by the test added by the > https://github.com/openjdk/jdk/pull/5042. The crash is rarely reproduced, and > in the default testrun, I was not able to crash it even once. But I have > found that if the 1000 tests are ex

Integrated: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

2021-09-14 Thread Prasanta Sadhukhan
On Thu, 9 Sep 2021 07:19:27 GMT, Prasanta Sadhukhan wrote: > Test fails on macOS12 since the check was only upto macOS11..Extended the > check for BigSurOrAbove. This pull request has now been integrated. Changeset: febcc72a Author:Prasanta Sadhukhan URL: https://git.openjdk.java.

RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

2021-09-14 Thread Alexander Scherbatiy
FontManagerFactory class uses reflection to load platform specific FontManager classes from "sun.font.fontmanager" property. Fix proposes creating FontManager platform specific classes directly in the similar way as it has been already done for GraphicsEnvironment and AWT Toolkit ([JDK-8130266]

Re: RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

2021-09-14 Thread Prasanta Sadhukhan
On Wed, 15 Sep 2021 05:52:54 GMT, Alexander Scherbatiy wrote: > FontManagerFactory class uses reflection to load platform specific > FontManager classes from "sun.font.fontmanager" property. > > Fix proposes creating FontManager platform specific classes directly in the > similar way as it ha