Re: [cfe-users] clangd --clang-tidy: // NOLINT only works sometimes

2020-01-29 Thread Sam McCall via cfe-users
+clangd-dev The issue here is that the warned construct (CURL_GLOBAL_SSL|CURL_GLOBAL_WIN32) is inside a macro. clangd checks for the NOLINT comment only where the code is spelled (on the macro definition), clang-tidy checks both the spelling location and the expansion location (curl_global_init ca

Re: [cfe-users] clangd --clang-tidy: // NOLINT only works sometimes

2020-01-26 Thread David Blaikie via cfe-users
+Sam in case he's got some thoughts or can rope in others who might. On Sun, Jan 26, 2020 at 1:03 PM tastytea via cfe-users < cfe-users@lists.llvm.org> wrote: > Hi, > I recently started using clangd (9.0.1) with --clang-tidy. I noticed > that suppressing diagnostics only sometimes works. > > For

[cfe-users] clangd --clang-tidy: // NOLINT only works sometimes

2020-01-26 Thread tastytea via cfe-users
Hi, I recently started using clangd (9.0.1) with --clang-tidy. I noticed that suppressing diagnostics only sometimes works. For example: using std::array; // NOLINT(misc-unused-using-decls) works with clang-tidy and clangd, but curl_global_init(CURL_GLOBAL_ALL); // NOLINT(hicpp-signed-bitw