https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/74235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maddobun updated
https://github.com/llvm/llvm-project/pull/70798
>From 0572afa42e4e6ca1d1de0e9df045828552cb4480 Mon Sep 17 00:00:00 2001
From: Leo Zhu
Date: Wed, 8 Nov 2023 11:10:13 -0500
Subject: [PATCH 1/3] Convert URI to uppercase drive letter during parsing
---
clang-to
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 6d5d35e1273f595e8a0382053d5183cbce7a9d8a Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 1/3] [clang-tidy] Add bugprone-move-shared-pointer-contents
check.
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 6d5d35e1273f595e8a0382053d5183cbce7a9d8a Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 1/4] [clang-tidy] Add bugprone-move-shared-pointer-contents
check.
@@ -0,0 +1,51 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,51 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,39 @@
+//===--- MoveSharedPointerContentsCheck.h - clang-tidy --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,51 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -25,6 +25,7 @@ add_clang_library(clangTidyBugproneModule
ImplicitWideningOfMultiplicationResultCheck.cpp
InaccurateEraseCheck.cpp
IncorrectEnableIfCheck.cpp
+ MoveSharedPointerContentsCheck.cpp
pizzud wrote:
Done, bad merge.
https://github.com/llvm/
@@ -0,0 +1,51 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -118,6 +119,7 @@ Clang-Tidy Checks
:doc:`bugprone-posix-return `, "Yes"
:doc:`bugprone-redundant-branch-condition
`, "Yes"
:doc:`bugprone-reserved-identifier `, "Yes"
+ :doc:`bugprone-shared-pointer-contents-move
`, "Yes"
pizzud wrote:
Done.
h
@@ -107,6 +107,7 @@ Clang-Tidy Checks
:doc:`bugprone-misplaced-pointer-arithmetic-in-alloc
`, "Yes"
:doc:`bugprone-misplaced-widening-cast `,
:doc:`bugprone-move-forwarding-reference
`, "Yes"
+ :doc:`bugprone-move-shared-pointer-contents
`, "Yes"
@@ -0,0 +1,75 @@
+// RUN: %check_clang_tidy %s bugprone-move-shared-pointer-contents %t --
-config="{CheckOptions:
{bugprone-move-shared-pointer-contents.SharedPointerClasses:
'std::shared_ptr;my::OtherSharedPtr;'}}"
+
+// Some dummy definitions we'll need.
+
+namespace std {
+
pizzud wrote:
Try searching for `unresolvedLookupExpr` & `UnresolvedLookupExpr` in the
clang-tidy directory. There is a high probability that another check has done
something related/similar.
>
> https://github.com/llvm/llvm-project/blob/2b7191c8993b5608ddb8b89c049717b497265796/clang-tools-ext
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Juergen Ributzka (ributzka)
Changes
CodeGen options do not affect the AST, so they usually can be ignored.
The only exception to the rule is when a PCM is created with
`-gmodules`.
In that case the Clang module format is switched to object
Author: Owen Pan
Date: 2023-12-04T16:33:20-08:00
New Revision: 924f6ca1bdc49efe776d7f5cfd43d421b65346ba
URL:
https://github.com/llvm/llvm-project/commit/924f6ca1bdc49efe776d7f5cfd43d421b65346ba
DIFF:
https://github.com/llvm/llvm-project/commit/924f6ca1bdc49efe776d7f5cfd43d421b65346ba.diff
LOG:
bcl5980 wrote:
AMDGPU can not unorll this case:
https://godbolt.org/z/4Pq3bnzTT
But the same code in X86 looks can unroll:
https://godbolt.org/z/zr8aTG1KW
We may need to continue debug on it.
https://github.com/llvm/llvm-project/pull/74268
___
cfe-
xiangzh1 wrote:
> AMDGPU can not unorll this case:
>
> https://godbolt.org/z/4Pq3bnzTT
>
> But the same code in X86 looks can unroll:
>
> https://godbolt.org/z/zr8aTG1KW
>
> We may need to continue debug on it.
X86 do very conservative unroll too，its upper bound send to 4 (default is 8),
if
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
This is a minor improvement to #73491.
---
Full diff: https://github.com/llvm/llvm-project/pull/74399.diff
1 Files Affected:
- (modified) clang/tools/clang-format/clang-format-diff.py (+1-2)
`
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
192439db6e3fcccf98c850bda1b970a11c590bbb..ee039e7c50751fabdbaadae73a0a09bc905620f2
clang/
xiangzh1 wrote:
I think we should follow this principle：
if a loop required to be unroll later, we should not distroy the loop count
info.
https://github.com/llvm/llvm-project/pull/74268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
Author: Younan Zhang
Date: 2023-12-05T09:59:42+08:00
New Revision: b3392c447ad7b18a652d2ed63e8ebb7741077a98
URL:
https://github.com/llvm/llvm-project/commit/b3392c447ad7b18a652d2ed63e8ebb7741077a98
DIFF:
https://github.com/llvm/llvm-project/commit/b3392c447ad7b18a652d2ed63e8ebb7741077a98.diff
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From 5333233261a3563f80ed58250c40791bd44a9901 Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH] [clang] Add per-global code model attribute
This adds a per-global cod
https://github.com/heiher edited https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher ready_for_review
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher converted_to_draft
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From 20069f5db5e45e4884397ebda1797d2050283854 Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH] [clang] Add per-global code model attribute
This adds a per-global cod
https://github.com/heiher ready_for_review
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcl5980 wrote:
> I think we should follow this principle： if a loop required to be unroll
> later, we should not distroy the loop count info.
The ideal is right. But I think what nikic say is loop unroll should handle the
case( upper bound unrolling). But It doesn't work. We need to find why l
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From 478cbb52d3ed3c6311389dd48c8d187cb28de18d Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH] [clang] Add per-global code model attribute
This adds a per-global cod
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72079
>From 478cbb52d3ed3c6311389dd48c8d187cb28de18d Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH 1/2] [clang] Add per-global code model attribute
This adds a per-global
https://github.com/heiher ready_for_review
https://github.com/llvm/llvm-project/pull/72079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcl5980 wrote:
https://godbolt.org/z/cMeE61bhf
Loop unroll with -unroll-runtime can partial unroll the case.
@nikic It looks if we don't avoid the transform, it will become a runtime
unroll.
@xiangzh1 's solution looks fine to me if we do not involve loopInfo in
simplifycfg.
https://github.co
https://github.com/EsmeYi updated
https://github.com/llvm/llvm-project/pull/70642
>From 7ba6a651bb84befdcd1566352d5340880591789d Mon Sep 17 00:00:00 2001
From: esmeyi
Date: Mon, 30 Oct 2023 06:00:18 -0400
Subject: [PATCH 1/7] Add support for parsing auxiliary symbols of XCOFF object
file for o
https://github.com/EsmeYi updated
https://github.com/llvm/llvm-project/pull/74415
>From f6d0ef8357540c61a9c20774e3b170a8db5b72ca Mon Sep 17 00:00:00 2001
From: esmeyi
Date: Tue, 5 Dec 2023 00:44:04 -0500
Subject: [PATCH] Exploit STMW and LMW in 32-bit big-endian mode.
---
llvm/lib/Target/Powe
xiangzh1 wrote:
> So where is the different X86 can partial unroll but AMDGPU can not unroll at
> all?
> https://godbolt.org/z/cMeE61bhf Loop unroll with -unroll-runtime can partial
> unroll the case. @nikic It looks if we don't avoid the transform, it will
> become a runtime unroll. The case
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Chuanqi Xu (ChuanqiXu9)
Changes
Close https://github.com/llvm/llvm-project/issues/72383
It looks incorrect or odd for the BMIs to dependent on the real files. It
prevents we moving the BMIs and the distributed builds. And it looks
Author: Vlad Serebrennikov
Date: 2023-12-05T11:23:32+04:00
New Revision: d11d38cb095b7f86d4c1298ea9806099d2fc4bd6
URL:
https://github.com/llvm/llvm-project/commit/d11d38cb095b7f86d4c1298ea9806099d2fc4bd6
DIFF:
https://github.com/llvm/llvm-project/commit/d11d38cb095b7f86d4c1298ea9806099d2fc4bd6.
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH] [clang] Add per-global code model attribute
This patch adds a per-glob
https://github.com/heiher edited https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shivam Gupta (xgupta)
Changes
The issue with size_t comes when we are trying to add -Wtype-limits to -Wextra
for GCC compatibility in review https://reviews.llvm.org/D142826.
Example of issue (false positive) -
$ cat clang/test/Sema/type
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH 1/2] [clang] Add per-global code model attribute
This patch adds a per-
@@ -3369,6 +3369,33 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static void handleCodeModelAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
+ StringRef CM;
+ StringRef Str;
+ SourceLocation LiteralLoc;
+ bool Ok = false;
+ // Check tha
@@ -57,6 +57,15 @@ global variable or function should be in after translation.
let Heading = "section, __declspec(allocate)";
}
+def CodeModelDocs : Documentation {
+ let Category = DocCatVariable;
+ let Content = [{
+The ``model`` attribute allows you to specify a specifi
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/5] Fix clang to recognize new C23 modifiers %w and %wf when
pri
Author: Yonggang Luo
Date: 2023-12-05T15:49:31+08:00
New Revision: 8cfdd37088d662338ec85ac15721dddf3f6d8db6
URL:
https://github.com/llvm/llvm-project/commit/8cfdd37088d662338ec85ac15721dddf3f6d8db6
DIFF:
https://github.com/llvm/llvm-project/commit/8cfdd37088d662338ec85ac15721dddf3f6d8db6.diff
serge-sans-paille wrote:
Much better! You can remove the useless `import os` then :-)
https://github.com/llvm/llvm-project/pull/74399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1714,6 +1714,8 @@ class ConstraintRefersToContainingTemplateChecker
// Friend, likely because it was referred to without its template arguments.
void CheckIfContainingRecord(const CXXRecordDecl *CheckingRD) {
CheckingRD = CheckingRD->getMostRecentDecl();
+if (!C
https://github.com/EsmeYi updated
https://github.com/llvm/llvm-project/pull/74415
>From f6d0ef8357540c61a9c20774e3b170a8db5b72ca Mon Sep 17 00:00:00 2001
From: esmeyi
Date: Tue, 5 Dec 2023 00:44:04 -0500
Subject: [PATCH 1/2] Exploit STMW and LMW in 32-bit big-endian mode.
---
llvm/lib/Target/
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH 1/3] [clang] Add per-global code model attribute
This patch adds a per-
https://github.com/EsmeYi updated
https://github.com/llvm/llvm-project/pull/74415
>From f6d0ef8357540c61a9c20774e3b170a8db5b72ca Mon Sep 17 00:00:00 2001
From: esmeyi
Date: Tue, 5 Dec 2023 00:44:04 -0500
Subject: [PATCH 1/3] Exploit STMW and LMW in 32-bit big-endian mode.
---
llvm/lib/Target/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haocong Lu (Luhaocong)
Changes
According to https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2844.pdf,
default argument promotions for _FloatN types has been removed.
A warning is needed to notice user to promote _Float16 to double expli
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Karl-Johan Karlsson (karka228)
Changes
In gcc there exist a modifier option -Wformat-signedness that turns on
additional signedness warnings in the already existing -Wformat warning.
This patch implements that support in clang.
---
Full
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 383e35048e16c85ab26bc46822d3ceb11fd4d3f2
a80bf9d03f19d48c0aca4af7758dc49516da8825 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andreas Schwab (andreas-schwab)
Changes
- [Bazel] Add support for targeting Linux riscv64
- [Driver] Add riscv64-suse-linux triple
---
Full diff: https://github.com/llvm/llvm-project/pull/74441.diff
2 Files Affected:
- (modified) clang
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 383e35048e16c85ab26bc46822d3ceb11fd4d3f2
488ecd555ff5572663d75cd3a92de3ea856d5d57 --
@@ -106,6 +126,210 @@ Error XCOFFDumper::dumpSections(ArrayRef Sections) {
return Error::success();
}
+Error XCOFFDumper::dumpFileAuxSym(XCOFFYAML::Symbol &Sym,
+ const XCOFFSymbolRef &SymbolEntRef) {
+ for (uint8_t I = 1; I <= Sym.NumberOfA
Author: Tom Eccles
Date: 2023-12-05T10:03:57Z
New Revision: 6b8d659062a0f9a7daa641432701dc6996939dc5
URL:
https://github.com/llvm/llvm-project/commit/6b8d659062a0f9a7daa641432701dc6996939dc5
DIFF:
https://github.com/llvm/llvm-project/commit/6b8d659062a0f9a7daa641432701dc6996939dc5.diff
LOG: [f
DonatNagyE wrote:
With Z3 the new functionality does not work, but its absence is handled
gracefully (the new methods return `NULL` and `core.BitwiseShift` emits the
"old" message).
The Z3 solver is very "shaky" ground for me (if I understand it correctly it's
too slow for stand-alone use, an
Author: Owen Pan
Date: 2023-12-05T10:36:14Z
New Revision: 900bb318b5b8c485e57cf810253a656b0fb683bc
URL:
https://github.com/llvm/llvm-project/commit/900bb318b5b8c485e57cf810253a656b0fb683bc
DIFF:
https://github.com/llvm/llvm-project/commit/900bb318b5b8c485e57cf810253a656b0fb683bc.diff
LOG: [cla
https://github.com/serge-sans-paille closed
https://github.com/llvm/llvm-project/pull/74399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
serge-sans-paille wrote:
thanks :bow:
https://github.com/llvm/llvm-project/pull/74399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matthew Devereau
Date: 2023-12-05T10:55:41Z
New Revision: 7788ef4be19fdbcd0c1f5ecf9f5cc52ab8b4ac1e
URL:
https://github.com/llvm/llvm-project/commit/7788ef4be19fdbcd0c1f5ecf9f5cc52ab8b4ac1e
DIFF:
https://github.com/llvm/llvm-project/commit/7788ef4be19fdbcd0c1f5ecf9f5cc52ab8b4ac1e.diff
L
https://github.com/martinboehme approved this pull request.
https://github.com/llvm/llvm-project/pull/74336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Samira Bazuzi
Date: 2023-12-05T12:09:33+01:00
New Revision: 40381d12640932a4e8185d18e5a0da84b4e449c0
URL:
https://github.com/llvm/llvm-project/commit/40381d12640932a4e8185d18e5a0da84b4e449c0
DIFF:
https://github.com/llvm/llvm-project/commit/40381d12640932a4e8185d18e5a0da84b4e449c0.diff
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/74336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matthew Devereau (MDevereau)
Changes
Adds builtins for:
- FCVT
- BFCVT
- FCVTZS
- FCVTZU
- SCVTF
- UCVTF
- BFCVTN
- FCVTN
- SQCVT
- SQCVTU
- UQCVT
- SQCVTN
- SQCVTUN
- UQCVTN
See https://github.com/ARM-software/acle/pull/217
---
Patch is
https://github.com/ostannard created
https://github.com/llvm/llvm-project/pull/74460
This adds support for the AArch64 soft-float ABI. The specification for this
ABI is currently in review at https://github.com/ARM-software/abi-aa/pull/232,
and I won't commit this until that PR is merged.
Bec
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (ostannard)
Changes
This adds support for the AArch64 soft-float ABI. The specification for this
ABI is currently in review at https://github.com/ARM-software/abi-aa/pull/232,
and I won't commit this until that PR is merged.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ecf881838045985f381003cc27569c73a207d0cc
b68ed60a3fe78bc0e9f57b45bed9dd78ed851904 --
ostannard wrote:
This doesn't add any new options, and I'd like to avoid that if possible,
instead it is turned on by `-march=...+nofp`.
https://github.com/llvm/llvm-project/pull/74460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: James Y Knight (jyknight)
Changes
This causes current mainline to now report "18.0.0git" instead of "18.0.0".
Fixes #53825
---
Full diff: https://github.com/llvm/llvm-project/pull/74469.diff
3 Files Affected:
- (modified) clang/CMakeLi
@@ -106,6 +126,210 @@ Error XCOFFDumper::dumpSections(ArrayRef Sections) {
return Error::success();
}
+Error XCOFFDumper::dumpFileAuxSym(XCOFFYAML::Symbol &Sym,
+ const XCOFFSymbolRef &SymbolEntRef) {
+ for (uint8_t I = 1; I <= Sym.NumberOfA
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/74469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -650,6 +652,7 @@ if (CLANG_ENABLE_BOOTSTRAP)
CLANG_VERSION_MAJOR
CLANG_VERSION_MINOR
CLANG_VERSION_PATCHLEVEL
+CLANG_VERSION_SUFFIX
zmodem wrote:
There's currently nothing in clang/include/clang/Basic/Version.inc.in using
this. Should we ad
https://github.com/zmodem approved this pull request.
lgtm!
https://github.com/llvm/llvm-project/pull/74469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
[clang][NFC] Refactor expected directives in C++ DRs 600-699
This patch continues the work started with
https://github.com/llvm/llvm-project/commit/ea5b1ef016d020c37f903d6c7d4f623be975dab8.
See that c
https://github.com/DonatNagyE approved this pull request.
Reasonable semi-automatic refactoring + a small change to fix a nasty crash.
It's good to see that you separated the NFC and the bugfix into two commits,
it'll make the git history nicer.
It's a bit unfortunate that there are many locat
@@ -1,13 +1,15 @@
-// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix -verify %s
-
-// expected-no-diagnostics
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix,debug.ExprInspection
-verify %s
// Test functions that are called "memcpy" but aren't the memcpy
// we're
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/74345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,DonatNagyE
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/72107
>From ab102e949994a44
Author: DonatNagyE
Date: 2023-12-05T16:17:35+01:00
New Revision: dfdedaf6dae0b4e54c64c740f8d22567447e0f8d
URL:
https://github.com/llvm/llvm-project/commit/dfdedaf6dae0b4e54c64c740f8d22567447e0f8d
DIFF:
https://github.com/llvm/llvm-project/commit/dfdedaf6dae0b4e54c64c740f8d22567447e0f8d.diff
LO
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,DonatNagyE
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE closed
https://github.com/llvm/llvm-project/pull/72107
___
@@ -4178,8 +4178,29 @@ void CodeGenModule::emitMultiVersionFunctions() {
}
llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD);
-if (auto *IFunc = dyn_cast(ResolverConstant))
+if (auto *IFunc = dyn_cast(ResolverConstant)) {
ResolverCon
@@ -4178,8 +4184,22 @@ void CodeGenModule::emitMultiVersionFunctions() {
}
llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD);
-if (auto *IFunc = dyn_cast(ResolverConstant))
+if (auto *IFunc = dyn_cast(ResolverConstant)) {
ResolverCon
DanielKristofKiss wrote:
> Hmm the build fails with:
>
> ⚠️ Warning: Checkout failed! checking out commit
> "af600cbf98ce1bf55c51ef88ddf94cd9114181c2": exit status 128 (Attempt 3/3) 🚨
> Error: checking out commit "af600cbf98ce1bf55c51ef88ddf94cd9114181c2": exit
> status 128
>
> Would any
elizabethandrews wrote:
> > Hmm the build fails with:
> > ⚠️ Warning: Checkout failed! checking out commit
> > "af600cbf98ce1bf55c51ef88ddf94cd9114181c2": exit status 128 (Attempt 3/3) 🚨
> > Error: checking out commit "af600cbf98ce1bf55c51ef88ddf94cd9114181c2": exit
> > status 128
> > Woul
@@ -14270,6 +14318,113 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind GetConversionKind(QualType FromType,
+
@@ -1914,6 +1914,17 @@ class StringLiteral final
llvm_unreachable("Unsupported character width!");
}
+ // Get code unit but preserve sign info.
+ int64_t getCodeUnitS(size_t I, uint64_t ByteWidth) const {
cor3ntin wrote:
```suggestion
int64_t getCod
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/73099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
Modulo comment I'm happy with the StringLiteral aspect of the patch and
generally the rest of the patch looks good to me, but I'm not familiar enough
with the peculiarities of C to provide an in-depth review
https://github.com/llvm/llvm-project/pull/73099
@@ -13816,7 +13862,9 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
VDecl->setStorageClass(SC_Extern);
// C99 6.7.8p4. All file scoped initializers need to be constant.
-if (!getLangOpts().CPlusPlus && !VDecl->isInvalidDecl())
@@ -237,19 +240,18 @@ void ParseOpenACCClauseList(Parser &P) {
} // namespace
-// Routine has an optional paren-wrapped name of a function in the local scope.
-// We parse the name, emitting any diagnostics
-ExprResult Parser::ParseOpenACCRoutineName() {
-
+ExprResult Parser:
@@ -268,6 +270,71 @@ ExprResult Parser::ParseOpenACCRoutineName() {
return getActions().CorrectDelayedTyposInExpr(Res);
}
+void Parser::ParseOpenACCCacheVar() {
+ ExprResult ArrayName = ParseOpenACCIDExpression();
+ // FIXME: Pass this to Sema.
+ (void)ArrayName;
+
+ //
@@ -268,6 +270,71 @@ ExprResult Parser::ParseOpenACCRoutineName() {
return getActions().CorrectDelayedTyposInExpr(Res);
}
+void Parser::ParseOpenACCCacheVar() {
cor3ntin wrote:
Maybe it would be nice to do like C and C++, ie citing the standard + grammar
p
@@ -268,6 +270,71 @@ ExprResult Parser::ParseOpenACCRoutineName() {
return getActions().CorrectDelayedTyposInExpr(Res);
}
+void Parser::ParseOpenACCCacheVar() {
+ ExprResult ArrayName = ParseOpenACCIDExpression();
+ // FIXME: Pass this to Sema.
+ (void)ArrayName;
+
+ //
@@ -268,6 +270,71 @@ ExprResult Parser::ParseOpenACCRoutineName() {
return getActions().CorrectDelayedTyposInExpr(Res);
}
+void Parser::ParseOpenACCCacheVar() {
+ ExprResult ArrayName = ParseOpenACCIDExpression();
+ // FIXME: Pass this to Sema.
+ (void)ArrayName;
+
+ //
@@ -268,6 +270,71 @@ ExprResult Parser::ParseOpenACCRoutineName() {
return getActions().CorrectDelayedTyposInExpr(Res);
}
+void Parser::ParseOpenACCCacheVar() {
+ ExprResult ArrayName = ParseOpenACCIDExpression();
+ // FIXME: Pass this to Sema.
+ (void)ArrayName;
+
+ //
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67157
>From 5c42d3e5286e041e22776fa496d884454640ffec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Fri, 22 Sep 2023 17:22:53 +0200
Subject: [PATCH] [analyzer] Move alpha checker EnumCastOutOfRan
DonatNagyE wrote:
(Force pushed the branch because I wanted to rebase it onto a recent main and
fix the merge conflicts. Is there a better workflow than this?)
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@li
901 - 1000 of 390598 matches
Mail list logo
