Sirraide wrote:
>
> I was testing with `noreturn` earlier. It's hard to compare, because (at
> least in C23):
>
> ```
> ../clang/test/Sema/attr-nolock-wip.cpp:15:19: error: 'noreturn' attribute
> cannot be applied to types
>15 | void noret(int) [[noreturn]];
> | ^
Sirraide wrote:
> Adapted from `test/Sema/initialize-noreturn.c`
Seeing as that test does check that we’re issuing an error for this, and seeing
that this seems to be handled in `isFunctionConversion()`, it really just seems
like that function is supposed to error if there is a conversion (i.e
Sirraide wrote:
> Just tried. In C mode, it works to do nothing about effect changes in
> isFunctionConversion (!).
I would maybe try going with that then for now (and maybe add a comment about
that too); I’m not sure my function pointer example is really the same
situation, but I remember fi
Sirraide wrote:
Seeing as there are now two places where we want to adjust function types but
also preserve sugar, I’ve gone ahead and added a generic `adjustType()`
function that handles all of the sugar and takes a `function_ref` to perform
the actual adjustment.
The intent here is that, i
Sirraide wrote:
List of issues that may be fixed by this:
- #71858
https://github.com/llvm/llvm-project/pull/84934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prabhuk wrote:
> I am debugging an assertion failure regression in one of our projects that
> uses the FlatMap data structure implemented here:
>
> https://pigweed.googlesource.com/pigweed/pigweed/+/refs/heads/main/pw_containers/public/pw_containers/flat_map.h#180
>
> The regression was that t
llvmbot wrote:
@llvm/pr-subscribers-backend-loongarch
Author: Fangrui Song (MaskRay)
Changes
GCC ports only supports one of the options, with -mstrict-align
preferred by newer ports. And they reject adding such aliases
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111555).
We should not s
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mehdi Amini (joker-eph)
Changes
Clang has a custom separate pipeline integrated with libc++ that only runs in
release mode. It means that changes which touches only clang won't run the
clang tests in the configuration used by LLVM premerg
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load instruction
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-llvm-ir
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the inte
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load inst
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load instr
https://github.com/yonghong-song created
https://github.com/llvm/llvm-project/pull/85358
Alexei added may_goto insn in [1]. The asm syntax for may_goto looks like
may_goto
The instruction represents a conditional branch but the condition is implicit.
Later in bpf kernel verifier, the 'may_g
https://github.com/quic-areg created
https://github.com/llvm/llvm-project/pull/85359
Defines a subset of attributes and emits them to a section called
.hexagon.attributes.
The current attributes recorded are the attributes needed by llvm-objdump to
automatically determine target features and
llvmbot wrote:
@llvm/pr-subscribers-objectyaml
@llvm/pr-subscribers-mc
@llvm/pr-subscribers-clang-driver
Author: None (quic-areg)
Changes
Defines a subset of attributes and emits them to a section called
.hexagon.attributes.
The current attributes recorded are the attributes needed by ll
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c3a1eb6207d85cb37ea29306481b40c9f6402309
b035993b477160d9ac6ef01c8d27e6681682f251 --
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
A name is not a FunctionDeclarationName if it's preceded by an Objective-C
keyword.
---
Full diff: https://github.com/llvm/llvm-project/pull/85361.diff
2 Files Affected:
- (modified) clang/lib/Format/To
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Author: None (dhruvachak)
Changes
A kernel implicit parameter (dyn_ptr) was introduced some time back. This patch
increments the kernel args version for a compiler supporting dyn_ptr. The
version will be used by the runtime to determine wh
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (dhruvachak)
Changes
A kernel implicit parameter (dyn_ptr) was introduced some time back. This patch
increments the kernel args version for a compiler supporting dyn_ptr. The
version will be used by the runtime to determine whether t
T-Gruber wrote:
> In addition to the above-mentioned issues there is also a conceptual problem
> with using `getOriginRegion()` to describe a symbol: it names the region
> where the symbol _originated_ (if it originated as the unknown initial value
> of a symbol), which is not necessarily the
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Jeffrey Byrnes (jrbyrnes)
Changes
I am still working with the user to define the actual rules, so it is still a
WIP. However, this current version contains the main machinery of the feature.
This helps bridge the gap between sch
https://github.com/zmodem approved this pull request.
lgtm, thanks!
Please include a "Fixes #83616" reference in the commit message.
https://github.com/llvm/llvm-project/pull/85300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-clang
Author: Longsheng Mou (CoTinker)
Changes
typedef long long Alignll __attribute__((align (4))); struct S {
int a;
Alignll b;
};
When classify:
a: Lo = Integer, Hi = NoClass
b:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 61671e2500771dfbf502acd86e2ef70cba847a39
8efa87d7b03ebf2cf304e97c5fcebdb4211350b4 --
martinboehme wrote:
> One high level question: is there a simpler path by which we avoid crashing
> on derived types but also don't support them? It seems like there is a lot of
> complexity required in getting this just right. Is it worth it (both in the
> code itself and in terms of runtime
Author: Phoebe Wang
Date: 2024-03-15T22:09:56+08:00
New Revision: f4676b6be6ee0d908c92d64936d17bd6fa3fbda8
URL:
https://github.com/llvm/llvm-project/commit/f4676b6be6ee0d908c92d64936d17bd6fa3fbda8
DIFF:
https://github.com/llvm/llvm-project/commit/f4676b6be6ee0d908c92d64936d17bd6fa3fbda8.diff
L
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
the template arguments of the RHS.
Fixes https://github.com/llvm/llvm-project/issues/85385.
The Finder was missing for this case, for the crash test, the template
parameter TTP was incorrectly considered as no
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
template parameter lists.
Fixes #85406.
- Set the invalid bit for alias template decl where it has multiple written
template parameter lists (as the AST node is ill-formed)
- don't perform CTAD for invalid ali
alexfh wrote:
The internal code was fixed. Thanks everyone for helping to figure this out!
https://github.com/llvm/llvm-project/pull/83997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8c4546f350fbce938d8fbc85d9e353d011f3f673
2576857fe4b5c0b99c1a29c07f92c80498687665 --
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Utkarsh Saxena (usx95)
Changes
Partially addresses https://github.com/llvm/llvm-project/issues/63818 for
control flow in expressions.
A control flow could happen in the middle of an expression due to stmt-expr and
coroutine suspe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Utkarsh Saxena (usx95)
Changes
Partially addresses https://github.com/llvm/llvm-project/issues/63818 for
control flow in expressions.
A control flow could happen in the middle of an expression due to stmt-expr and
coroutine suspensions.
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From 62fa811f49f20c8fb10376faf8f7a1db05bbd401 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From f5c14118e9626b52414e1d97dbee8c2c64686202 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Dave Lee (kastiglione)
Changes
Move CCC_OVERRIDE_OPTIONS support to clangDriver so that it may be used outside
of the clang driver binary.
The override functionality will be used in LLDB, to apply adjustments to
ClangImporter flags.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikolas Klauser (philnik777)
Changes
This re-applies #74110 with the crashing code disabled in C++03. I'll
try to fix the new crash in it's own patch.
---
Full diff: https://github.com/llvm/llvm-project/pull/85427.diff
4 Files Affected:
dhruvachak wrote:
> > The versioning is required to support use cases where code generated by an
> > older compiler is linked with a newer runtime.
>
> Is that supported?
I think compatibility across released versions is not supported in upstream
LLVM. But downstream, there are use cases. For
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
Follow-up to #85350: GCC only supports -m[no-]strict-align for AArch64
and rejects adding -m[no-]unaligned-access aliases. We inapropriated
supported -m[no-]unaligned-access as aliases for non-AArch64 due to a
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Fangrui Song (MaskRay)
Changes
Follow-up to #85350: GCC only supports -m[no-]strict-align for AArch64
and rejects adding -m[no-]unaligned-access aliases. We inapropriated
supported -m[no-]unaligned-access as aliases for non-AArch6
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Alexandros Lamprineas (labrinea)
Changes
This was a limitation which has now been lifted upon request.
Please read the thread below for more details:
https://github.com/llvm/llvm-project/pull/84405#discussion_r1525583647
B
sethp wrote:
@cor3ntin @tbaederr is there anything else you need from me here? I would
expect github's "squash and merge" button to work fine for this change, but I
could rebase if you'd prefer.
https://github.com/llvm/llvm-project/pull/82383
___
cfe
llvmbot wrote:
@llvm/pr-subscribers-backend-webassembly
Author: Alex Voicu (AlexVlx)
Changes
Currently, the builtins used for implementing `va_list` handling
unconditionally take their arguments as unqualified `ptr`s i.e. pointers to AS
0. This does not work for targets where the default
sethp wrote:
Ping @cor3ntin @cjdb —this one definitely needs a rebase from me, but I don't
want to do that if y'all have a review in progress.
https://github.com/llvm/llvm-project/pull/74852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/AtariDreams created
https://github.com/llvm/llvm-project/pull/85465
Only NSObject we can trust the layout of won't change even though we cannot
directly see its @implementation
>From 3c66561377e5bfdbb3eefa658da63f68026e5a2e Mon Sep 17 00:00:00 2001
From: Rose
Date: Fri, 15
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: AtariDreams (AtariDreams)
Changes
Only NSObject we can trust the layout of won't change even though we cannot
directly see its @implementation
---
Full diff: https://github.com/llvm/llvm-project/pull/85465.diff
2 Files Affected:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: AtariDreams (AtariDreams)
Changes
Only NSObject we can trust the layout of won't change even though we cannot
directly see its @implementation
---
Full diff: https://github.com/llvm/llvm-project/pull/85465.diff
2 Files Affected:
- (mod
https://github.com/scythris created
https://github.com/llvm/llvm-project/pull/85470
This resolves an issue in clang-format where `new` and `delete` were
incorrectly formatted as keywords in C files. The fix modifies
`TokenAnnotator::spaceRequiredBetween` to handle `new` and `delete` when used
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: None (scythris)
Changes
This resolves an issue in clang-format where `new` and `delete` were
incorrectly formatted as keywords in C files. The fix modifies
`TokenAnnotator::spaceRequiredBetween` to handle `new` and `delete` when us
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 60fa2b0670b874b702ddb9f81d098af692ea6875
1e815bb2090f7747da027a04f69906063db7b02a --
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Mike Rice (mikerice1969)
Changes
The value of SubExpr is not null since getSubExpr would assert in that case.
Remove the nullptr check. This avoids confusion since SubExpr is used without
check later in the function.
---
Full diff:
Author: Yichen Yan
Date: 2024-03-15T17:16:10-05:00
New Revision: 047b2b241defcad79a6ac0fec9cda092bac0a922
URL:
https://github.com/llvm/llvm-project/commit/047b2b241defcad79a6ac0fec9cda092bac0a922
DIFF:
https://github.com/llvm/llvm-project/commit/047b2b241defcad79a6ac0fec9cda092bac0a922.diff
LO
github-actions[bot] wrote:
@oraluben Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build
https://github.com/AtariDreams created
https://github.com/llvm/llvm-project/pull/85481
The size of 18 only works for x86, but does not work for the other
architectures. This works for Darwin and was retrieved via reading the setjmp.h
header. It would be nice if we could do the equivalent of si
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: AtariDreams (AtariDreams)
Changes
The size of 18 only works for x86, but does not work for the other
architectures. This works for Darwin and was retrieved via reading the setjmp.h
header. It would be nice if we could do the equiv
Author: Dave Lee
Date: 2024-03-15T16:09:56-07:00
New Revision: 8d7ee4691dadd3a9d831108f77d1f4e511191a44
URL:
https://github.com/llvm/llvm-project/commit/8d7ee4691dadd3a9d831108f77d1f4e511191a44
DIFF:
https://github.com/llvm/llvm-project/commit/8d7ee4691dadd3a9d831108f77d1f4e511191a44.diff
LOG:
Author: Paul Kirth
Date: 2024-03-15T16:35:06-07:00
New Revision: 43fc921795bd130a325c013d60f209b5c6128fc7
URL:
https://github.com/llvm/llvm-project/commit/43fc921795bd130a325c013d60f209b5c6128fc7
DIFF:
https://github.com/llvm/llvm-project/commit/43fc921795bd130a325c013d60f209b5c6128fc7.diff
LO
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85465
>From 274838e83e20d073b326387a1d319dd60ad32568 Mon Sep 17 00:00:00 2001
From: Rose
Date: Fri, 15 Mar 2024 16:43:10 -0400
Subject: [PATCH] [ObjC] Expand isClassLayoutKnownStatically to base classes as
long as
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
The diagnostic is a warning in GCC. We make it a DefaultError warning
under -Wmain.
There is a use case to pass customized arguments to main without using
-ffreestanding.
Close #85491
---
Full diff: https
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fd3eaf76ba3392a4406247d996e757ef49f7a8b2
6d61aa1e43bb522412904bdd77c7f1cfc4b42889 --
