[clang] [clang][dataflow] Add a test for result object location on `CXXDefaultArgExpr`. (PR #85072)

2024-03-14 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/85072 >From 7c61dc4872a1ffba8c241aa92bd87863f585e301 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 14 Mar 2024 08:46:06 + Subject: [PATCH] [clang][dataflow] Fix `getResultObjectLocation()` on `CXXD

[clang] [clang][dataflow] Fix `getResultObjectLocation()` on `CXXDefaultArgExpr`. (PR #85072)

2024-03-14 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/85072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix `getResultObjectLocation()` on `CXXDefaultArgExpr`. (PR #85072)

2024-03-14 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/85072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix `getResultObjectLocation()` on `CXXDefaultArgExpr`. (PR #85072)

2024-03-14 Thread via cfe-commits
martinboehme wrote: New commit pushed with fix. I have changed the title and description of the PR accordingly. https://github.com/llvm/llvm-project/pull/85072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clang][Sema] Skip the RequiresExprBodyDecls for lambda dependencies (PR #83997)

2024-03-14 Thread via cfe-commits
alexfh wrote: I guess the reduction could have dropped some important parts of this. Let me try the original code with assertions-enabled clang build... https://github.com/llvm/llvm-project/pull/83997 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] [AArch64] Remove Automatic Enablement of FEAT_F32MM (PR #85203)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jack Styles (Stylie777) Changes When `+sve` is passed in the command line, if the Architecture being targeted is V8.6A/V9.1A or later, `+f32mm` is also added. This enables FEAT_32MM, however at the time of writing no CPU's support

[clang] [llvm] [AArch64] Remove Automatic Enablement of FEAT_F32MM (PR #85203)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff afec257d369a13893b39d02bc630f9f3cec80162 b5a0ad5d4b7ab3510cd00d178da245761e34d32d --

[libclc] libclc: clspv: update gen_convert.cl for clspv (PR #66902)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0f1847cb2c5462a09d65a9b5ac24904ac3c15a0f...5614f89c90cf865c88fbcf95d707e34dfeb18a19 libcl

[clang] [clang][Sema] Skip the RequiresExprBodyDecls for lambda dependencies (PR #83997)

2024-03-14 Thread via cfe-commits
alexfh wrote: It turns out debug build of clang before this patch generated an assertion on the original code as well: ``` assert.h assertion failed at llvm-project/clang/lib/AST/ExprConstant.cpp:15739 in bool clang::Expr::EvaluateAsConstantExpr(EvalResult &, const ASTContext &, ConstantExprKi

[clang] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [X86] Fast AVX-512-VNNI vpdpwssd tuning (PR #85033)

2024-03-14 Thread via cfe-commits
ganeshgit wrote: > This patch needs to be cleanly rebased on trunk (force push is OK in PR > branchs) I think my overnight rebase scripts screwed the fixups. I will close this and I will raise a new pull request. https://github.com/llvm/llvm-project/pull/85033

[clang] [analyzer] Wrap SymbolicRegions by ElementRegions before getting a FieldRegion (PR #85211)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Inside the ExprEngine when we process the initializers, we create a PostInitializer program-point, which will refer to the field being initialized, see `FieldLoc` inside `ExprEngine::Proc

[clang] [clang][OpenMP] Fix directive in ActOnOpenMPTargetParallelForSimdDire… (PR #85217)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes …ctive The function `ActOnOpenMPTargetParallelForSimdDirective` gets the number of capture levels for OMPD_target_parallel_for, whereas the intended directive is OMPD_target_parallel_for_simd. ---

[clang] [llvm] Adapted MemRegion::getDescriptiveName to handle ElementRegions (PR #85104)

2024-03-14 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/85104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adapted MemRegion::getDescriptiveName to handle ElementRegions (PR #85104)

2024-03-14 Thread via cfe-commits
https://github.com/NagyDonat requested changes to this pull request. I strongly suspect that there are some situations where this commit would behave incorrectly (assert on legal code or print incorrect output). See inline comment for explanation and a suggested solution (that I did not test).

[clang] [llvm] Adapted MemRegion::getDescriptiveName to handle ElementRegions (PR #85104)

2024-03-14 Thread via cfe-commits
@@ -720,14 +720,20 @@ std::string MemRegion::getDescriptiveName(bool UseQuotes) const { CI->getValue().toString(Idx); ArrayIndices = (llvm::Twine("[") + Idx.str() + "]" + ArrayIndices).str(); } -// If not a ConcreteInt, try to obtain the variable -// na

[clang] [llvm] Adapted MemRegion::getDescriptiveName to handle ElementRegions (PR #85104)

2024-03-14 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/85104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add `-march=general` option to mirror default configuration (PR #85222)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [NVPTX] Add `-march=general` option to mirror default configuration (PR #85222)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yichen Yan (oraluben) Changes This PR adds `-march=generic` support for the NVPTX backend. This fulfills a TODO introduced in #79873. With this PR, users can explicitly request the default CUDA architecture. This default is regularly upd

[clang] [NVPTX] Add `-march=general` option to mirror default configuration (PR #85222)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 34ba90745fa55777436a2429a51a3799c83c6d4c 9d6fe5f8522ddedde66525e93f4b66e547ddadc6 --

[clang] [analyzer] Fix false double free when including 3rd-party headers with overloaded delete operator as system headers (PR #85224)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ella Ma (Snape3058) Changes Fixes #62985 When 3rd-party header files are included as system headers, their overloaded `new` and `delete` operators are also considered as the std ones. However, those overloaded operator

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 93e423f19fc5317ee208f77d8f36e677db124cc8 4b42f76d5c1e5439311cc8153ef9530be2625840 --

[clang] [llvm] Adapted MemRegion::getDescriptiveName to handle ElementRegions (PR #85104)

2024-03-14 Thread via cfe-commits
NagyDonat wrote: In addition to the above-mentioned issues there is also a conceptual problem with using `getOriginRegion()` to describe a symbol: it names the region where the symbol _originated_ (if it originated as the unknown initial value of a symbol), which is not necessarily the region

[clang] [clang][analyzer]Add C++ polymorphic ptr arithmetic checker (PR #82977)

2024-03-14 Thread via cfe-commits
https://github.com/Discookie closed https://github.com/llvm/llvm-project/pull/82977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
https://github.com/whisperity edited https://github.com/llvm/llvm-project/pull/83985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang] Define ptrauth driver flags and preprocessor features (PR #85232)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4a21e3afa29521192ce686605eb945495455ca5e d0138c7f86e4bc1b883822143a6841646f946ba2 --

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
https://github.com/whisperity edited https://github.com/llvm/llvm-project/pull/83985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -340,6 +340,50 @@ cplusplus C++ Checkers. +.. _cplusplus-ArrayDelete: + +cplusplus.ArrayDelete (C++) +""" +Reports destructions of arrays of polymorphic objects that are destructed as +their base class. If the dynamic type of the array's object is d

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -340,6 +340,50 @@ cplusplus C++ Checkers. +.. _cplusplus-ArrayDelete: + +cplusplus.ArrayDelete (C++) +""" +Reports destructions of arrays of polymorphic objects that are destructed as +their base class. If the dynamic type of the array's object is d

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
https://github.com/whisperity commented: Style nits only. https://github.com/llvm/llvm-project/pull/83985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -340,6 +340,50 @@ cplusplus C++ Checkers. +.. _cplusplus-ArrayDelete: + +cplusplus.ArrayDelete (C++) +""" +Reports destructions of arrays of polymorphic objects that are destructed as +their base class. If the dynamic type of the array's object is d

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -220,11 +220,11 @@ CXXDeleteChecker::PtrCastVisitor::VisitNode(const ExplodedNode *N, /*addPosRange=*/true); } -void ento::registerCXXArrayDeleteChecker(CheckerManager &mgr) { +void ento::registerArrayDeleteChecker(Checke

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -340,6 +340,50 @@ cplusplus C++ Checkers. +.. _cplusplus-ArrayDelete: + +cplusplus.ArrayDelete (C++) +""" +Reports destructions of arrays of polymorphic objects that are destructed as whisperity wrote: ```suggestion """

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -220,11 +220,11 @@ CXXDeleteChecker::PtrCastVisitor::VisitNode(const ExplodedNode *N, /*addPosRange=*/true); } -void ento::registerCXXArrayDeleteChecker(CheckerManager &mgr) { +void ento::registerArrayDeleteChecker(Checke

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
@@ -340,6 +340,50 @@ cplusplus C++ Checkers. +.. _cplusplus-ArrayDelete: + +cplusplus.ArrayDelete (C++) +""" +Reports destructions of arrays of polymorphic objects that are destructed as +their base class. If the dynamic type of the array's object is d

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-14 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. Still LGTM, apply the few suggested changes and then feel free to merge the commit. https://github.com/llvm/llvm-project/pull/83985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 92a09c0 - [clang][nullability] allow _Nonnull etc on nullable class types (#82705)

2024-03-14 Thread via cfe-commits
Author: Sam McCall Date: 2024-03-14T16:45:24+01:00 New Revision: 92a09c0165b87032e1bd05020a78ed845cf35661 URL: https://github.com/llvm/llvm-project/commit/92a09c0165b87032e1bd05020a78ed845cf35661 DIFF: https://github.com/llvm/llvm-project/commit/92a09c0165b87032e1bd05020a78ed845cf35661.diff LO

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes When printing an `_Atomic(some struct type)`, we would later run into an assertion because we do a `Ty->castAs()`, which doesn't work with an `AtomicType`. Not sure how to best write a test for,

[clang] [InstallAPI] capture compatibility versions (PR #85261)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85261.diff 3 Files Affected: - (modified) clang/test/InstallAPI/basic.test (+2-6) - (modified) clang/tools/clang-installapi/Options.cpp (+4)

[clang] 63d53ee - Revert "[Driver] Default riscv*- triples to -fdebug-default-version=4" (#84119)

2024-03-14 Thread via cfe-commits
Author: Fangrui Song Date: 2024-03-14T09:53:38-07:00 New Revision: 63d53ee3b07e3b13e176eb60d8c02dea365c5ddb URL: https://github.com/llvm/llvm-project/commit/63d53ee3b07e3b13e176eb60d8c02dea365c5ddb DIFF: https://github.com/llvm/llvm-project/commit/63d53ee3b07e3b13e176eb60d8c02dea365c5ddb.diff

[clang] Rough first stab at addressing #85120 (PR #85147)

2024-03-14 Thread via cfe-commits
Sirraide wrote: > > @dougsonos I may have some time to look into this since there are probably > > (as always) some annoying edge cases—particularly w/ templates. Would you > > be fine with me committing to this branch or would it be easier for you if > > I made a separate branch for that? Eit

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
@@ -10778,6 +10778,101 @@ def warn_imp_cast_drops_unaligned : Warning< "implicit cast from type %0 to type %1 drops __unaligned qualifier">, InGroup>; +def warn_func_effect_allocates : Warning< + "'%0' function '%1' must not allocate or deallocate memory">, + InGroup; +

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
@@ -3922,6 +3922,42 @@ bool Sema::MergeFunctionDecl(FunctionDecl *New, NamedDecl *&OldD, Scope *S, return true; } + const auto OldFX = Old->getFunctionEffects(); + const auto NewFX = New->getFunctionEffects(); + if (OldFX != NewFX) { +const auto Diffs = FunctionE

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
@@ -3922,6 +3922,42 @@ bool Sema::MergeFunctionDecl(FunctionDecl *New, NamedDecl *&OldD, Scope *S, return true; } + const auto OldFX = Old->getFunctionEffects(); + const auto NewFX = New->getFunctionEffects(); + if (OldFX != NewFX) { +const auto Diffs = FunctionE

[clang] [Clang] C++ Templates: Refactor and fix `TransformLambdaExpr`'s mishandling of TypeLocs (PR #78801)

2024-03-14 Thread via cfe-commits
Sirraide wrote: So as I’ve been looking into this as well, the changes that simplify how `TransformLambdaExpr` make sense (though I think we can go even further here because even `TransformFuncitonProtoType` could probably just take a `bool` and not a callback, but I’ll take another look at th

[clang] b058b7e - [InstallAPI] capture compatibility versions (#85261)

2024-03-14 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-03-14T11:24:16-07:00 New Revision: b058b7e6280a732f6fcbc582f8b6511a36fb96e8 URL: https://github.com/llvm/llvm-project/commit/b058b7e6280a732f6fcbc582f8b6511a36fb96e8 DIFF: https://github.com/llvm/llvm-project/commit/b058b7e6280a732f6fcbc582f8b6511a36fb96e8.diff

[clang] [llvm] [Clang][BPF] Allow sign extension for call parameters with int types (PR #84874)

2024-03-14 Thread via cfe-commits
yonghong-song wrote: @pulehui I will not merge this patch now since it does not really solve the whole riscv issue. As @4ast commented above, the verifier made btf_func_model to jit. ``` struct btf_func_model { u8 ret_size; u8 ret_flags; u8 nr_args; u8 arg_size[M

[clang] [clang][MSVC] Correct mangling of thread-safe static initialization variables. (PR #85300)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Honermann (tahonermann) Changes Static local variables with dynamic initializers depend on implicitly defined guard variables to synchronize thread-safe initialization. These guard variables may have external linkage and therefore re

[clang] [llvm] [HLSL] implement the `isinf` intrinsic (PR #84927)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8c4546f350fbce938d8fbc85d9e353d011f3f673 f5c26f5ce566b33e009dde27caf8d723432e8b34 --

[libclc] b6193a2 - libclc: clspv: update gen_convert.cl for clspv (#66902)

2024-03-14 Thread via cfe-commits
Author: Romaric Jodin Date: 2024-03-14T19:56:34Z New Revision: b6193a2dc2c7e1fb278161873e8f01f728412f4b URL: https://github.com/llvm/llvm-project/commit/b6193a2dc2c7e1fb278161873e8f01f728412f4b DIFF: https://github.com/llvm/llvm-project/commit/b6193a2dc2c7e1fb278161873e8f01f728412f4b.diff LOG:

[clang] 8f9ee39 - [HLSL] Implement `rsqrt` intrinsic (#84820)

2024-03-14 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-03-14T16:49:33-04:00 New Revision: 8f9ee39c58064d3a3291a89509501ebe55d2e788 URL: https://github.com/llvm/llvm-project/commit/8f9ee39c58064d3a3291a89509501ebe55d2e788 DIFF: https://github.com/llvm/llvm-project/commit/8f9ee39c58064d3a3291a89509501ebe55d2e788.diff

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread via cfe-commits
josh11b wrote: Ping! https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstCombine] Canonicalize `(sitofp x)` -> `(uitofp x)` if `x >= 0` (PR #82404)

2024-03-14 Thread via cfe-commits
goldsteinn wrote: > We happen have a back-end where we do not have conversion instructions > between unsigned int and FP, so this patch complicates things. Would it make > sense to enable this canonicalization only if the target wants it? We try to keep InstCombine as target agnostic as possib

[clang] [clang] Fix Clang language extension documentation markup for __builtin_arm_trap. (PR #85310)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Honermann (tahonermann) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85310.diff 1 Files Affected: - (modified) clang/docs/LanguageExtensions.rst (+1-1) ``diff diff --git a/clang/docs/LanguageExtension

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b updated https://github.com/llvm/llvm-project/pull/81556 >From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001 From: Josh L Date: Mon, 12 Feb 2024 22:59:21 + Subject: [PATCH 1/2] Add bazel support for clangd as a library. --- clang-tools-extra/c

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) + +license

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) --

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b updated https://github.com/llvm/llvm-project/pull/81556 >From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001 From: Josh L Date: Mon, 12 Feb 2024 22:59:21 + Subject: [PATCH 1/2] Add bazel support for clangd as a library. --- clang-tools-extra/c

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b edited https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b updated https://github.com/llvm/llvm-project/pull/81556 >From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001 From: Josh L Date: Mon, 12 Feb 2024 22:59:21 + Subject: [PATCH 1/3] Add bazel support for clangd as a library. --- clang-tools-extra/c

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -0,0 +1,46 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(features = ["layering_check"], josh11b

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -18,7 +18,6 @@ #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H -#include "Feature.h" josh11b wrote: Done. https://github.com/llvm/llvm-project/pull/81556 ___ c

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b edited https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b updated https://github.com/llvm/llvm-project/pull/81556 >From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001 From: Josh L Date: Mon, 12 Feb 2024 22:59:21 + Subject: [PATCH 1/4] Add bazel support for clangd as a library. --- clang-tools-extra/c

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b commented: Thank you for the feedback! https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b edited https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) + +license

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) + +license

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
https://github.com/josh11b updated https://github.com/llvm/llvm-project/pull/81556 >From e2b83f086e51d7144d8e6ac1d1850300de55f01f Mon Sep 17 00:00:00 2001 From: Josh L Date: Mon, 12 Feb 2024 22:59:21 + Subject: [PATCH 1/4] Add bazel support for clangd as a library. --- clang-tools-extra/c

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/85316 None >From d57b7d50722fbf6f304da8c8d4d902cbb3c3b14f Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to c

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85316.diff 1 Files Affected: - (modified) clang/lib/Analysis/RetainSummaryManager.cpp (+16-2) ``diff diff --git a/clang/lib/Analysis/

[clang] [llvm] [InstCombine] Canonicalize `(sitofp x)` -> `(uitofp x)` if `x >= 0` (PR #82404)

2024-03-14 Thread via cfe-commits
goldsteinn wrote: > I don't think we really have a strong motivation for this change beyond > "having a canonical form is usually good", so if it's causing issues for some > targets, then probably just not doing it is fine. But if we do want to keep > it, then yeah, this would be a reasonable

[clang] [clang][AArch64] Enable fp128 for aarch64 linux target (PR #85070)

2024-03-14 Thread via cfe-commits
lntue wrote: > Right, I'm more interested in being able to use on aarch64 the `_Float128` > type as standardized by C23, than the clang specific `__float128` extension. > Does this PR help get us there? > > EDIT: in fact, if we could skip propagating the clang-specific extension > further, an

[clang] d192b64 - [HLSL] implement the `isinf` intrinsic (#84927)

2024-03-14 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-03-14T18:07:48-04:00 New Revision: d192b643701062064408dd7be0301f7a5d070c03 URL: https://github.com/llvm/llvm-project/commit/d192b643701062064408dd7be0301f7a5d070c03 DIFF: https://github.com/llvm/llvm-project/commit/d192b643701062064408dd7be0301f7a5d070c03.diff

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/85325 ## Summary This pr fixes a crash when we attempt to instantiate a lambda with an `AnnotatedType`, refactors the code that handles transforming the function type of a lambda, and improves source fidelity for lam

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
Sirraide wrote: I’ll add a release note once I’ve figured out how long this bug has been in Clang. https://github.com/llvm/llvm-project/pull/85325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes ## Summary This pr fixes a crash when we attempt to instantiate a lambda with an `AnnotatedType`, refactors the code that handles transforming the function type of a lambda, and improves source fidelity for lambda

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/85325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -13830,62 +13820,40 @@ TreeTransform::TransformLambdaExpr(LambdaExpr *E) { getSema().AddTemplateParametersToLambdaCallOperator(NewCallOperator, Class, TPL); - // Transform the type of the original lambda's call o

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/85325 >From 907210a3ad3d829a8e49a5c976d129f8653801bf Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 14 Mar 2024 18:24:37 +0100 Subject: [PATCH 1/8] [Clang] Add `dump()` method for `Attr` --- clang/include/clang/

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/85325 >From 907210a3ad3d829a8e49a5c976d129f8653801bf Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 14 Mar 2024 18:24:37 +0100 Subject: [PATCH 1/9] [Clang] Add `dump()` method for `Attr` --- clang/include/clang/

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bde7a6b791872b63456cb4e50e63046728a65196 d6a57b5a5aa123cf38ce3657b764c74c4c5a86f7 --

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/85325 >From 907210a3ad3d829a8e49a5c976d129f8653801bf Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 14 Mar 2024 18:24:37 +0100 Subject: [PATCH 01/10] [Clang] Add `dump()` method for `Attr` --- clang/include/clan

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From 7a88cbf69e455434d4433e52eff9230780ede065 Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From 10d544d35261a6ee6719ea38c22f3117ca8bf422 Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From ea3a9ee76249bd1216bc6aa16dcec6008f12a19b Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-03-14 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From 474d15b0454ecfef5ce4802b2df071daa136122c Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [Clang] Bugfixes and improved support for `AttributedType`s in lambdas (PR #85325)

2024-03-14 Thread via cfe-commits
@@ -3140,13 +3140,35 @@ const FunctionType *ASTContext::adjustFunctionType(const FunctionType *T, return cast(Result.getTypePtr()); } +QualType ASTContext::adjustFunctionResultType(QualType FunctionType, + QualType ResultType) {

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Joshua Batista (bob80905) Changes Previously, the clang compiler with the dxc driver would accept the -enable-16bit-types flag without checking to see if the required conditions are met for proper process

[clang] de1a97d - [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (#84526)

2024-03-14 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-03-14T20:25:57-04:00 New Revision: de1a97db3948608822a6d099cc3460690132e1cb URL: https://github.com/llvm/llvm-project/commit/de1a97db3948608822a6d099cc3460690132e1cb DIFF: https://github.com/llvm/llvm-project/commit/de1a97db3948608822a6d099cc3460690132e1cb.diff

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
Sirraide wrote: > I've probably been staring at this way too long, but here's what's going on. > My test is: My bad, I remember looking into this yesterday or the day before; from what I could tell, it seems I may have forgotten to share what I found here: I think the problem is that the code

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
Sirraide wrote: > the naming of "From" and "To" seems backwards. I noticed that as well; as I recall, swapping the two didn’t seem to change anything. I might open a pr or issue about this to either fix this or at least get some clarification as to whether that was really intended. I got a bit

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
Sirraide wrote: > have you tried maybe simply not setting `Changed` to `true` (perhaps only in > C mode)? It’s worth pointing out that C also warns (and C23 straight-up *errors*) if you replace `nolock` w/ `noreturn` iirc, so either that’s also a bug or that’s intended; I think I was going to

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread via cfe-commits
github-actions[bot] wrote: @josh11b Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] nolock/noalloc attributes (PR #84983)

2024-03-14 Thread via cfe-commits
Sirraide wrote: > swapping the two didn’t seem to change anything In one specific place where this is called in C mode, that is. From what I could see, the ordering seems to be correct for other calls to this function. https://github.com/llvm/llvm-project/pull/84983 ___

<    55   56   57   58   59   60   61   62   63   64   >