[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-llvm-analysis Author: Eric Biggers (ebiggers) Changes This is an updated version of https://github.com/llvm/llvm-project/pull/69000, which hasn't had activity in a few weeks --- Patch is 272.35 KiB, truncated to 20.00

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Thomas Schenker (schenker) Changes Before this PR, readability-container-contains fixits did not handle integer literal suffixes correctly. It e.g. changed ``` MyMap.count(2) != 0U; ``` into ``` MyMap.contains(2)U; ``` With this

[clang] [lldb] [flang] [lld] [llvm] [libc] [compiler-rt] [libcxx] Work around GCC test failure that is caused by enabling optimizations. (PR #73998)

2023-12-02 Thread via cfe-commits
https://github.com/EricWF updated https://github.com/llvm/llvm-project/pull/73998 >From 2e7676bac9fb0c8694dd1ee635508ae4d4a6421d Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Thu, 30 Nov 2023 17:23:37 -0500 Subject: [PATCH 1/3] Work around GCC test failure that is caused by enabling optim

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-02 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/69061 >From 894e8623689abe615600d768ef4fbedea78ab799 Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Sat, 14 Oct 2023 12:02:19 -0400 Subject: [PATCH] Remove warnings from -Wchar-subscripts for known positive cons

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-02 Thread via cfe-commits
https://github.com/wheatman created https://github.com/llvm/llvm-project/pull/74220 …ation limit >From 8990877d381639d8498630fd4e9b30732ab893d6 Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Sat, 2 Dec 2023 22:17:24 -0500 Subject: [PATCH] [clang] assert fail when number of arguments in pa

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (wheatman) Changes …ation limit --- Full diff: https://github.com/llvm/llvm-project/pull/74220.diff 1 Files Affected: - (modified) clang/lib/AST/ExprCXX.cpp (+1) ``diff diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 38f75d606f94e6b552fd74d487b061a1f8f907fa 8990877d381639d8498630fd4e9b30732ab893d6 --

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-02 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/74220 >From 86e187f7f13c5cbb0d1afb9ebbe9c0e7022269a6 Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Sat, 2 Dec 2023 22:17:24 -0500 Subject: [PATCH] [clang] assert fail when number of arguments in pack exceed imp

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-02 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/74215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-02 Thread via cfe-commits
https://github.com/EugeneZelenko requested changes to this pull request. https://github.com/llvm/llvm-project/pull/74215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-02 Thread via cfe-commits
@@ -399,6 +399,10 @@ Changes in existing checks ` diagnositics to highlight the const location +- Improved :doc:`readability-container-contains + ` to correctly handle + interger literals with suffixes in fixits. EugeneZelenko wrote: `fix-its`. https:/

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-02 Thread via cfe-commits
wheatman wrote: This is designed to detect bugs like https://github.com/llvm/llvm-project/issues/71888 with an assert instead of silently changing the meaning of the code. an example of the code which the assert will trigger on is ``` #include #include template constexpr auto static ma

[clang] Fix dr2xx clang test (PR #74223)

2023-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sizov Nikita (snikitav) Changes Currently windows build fails with: ``` # | error: 'cxx98-14-error' diagnostics expected but not seen: # | File C:\ws\src\clang\test\CXX\drs\dr2xx.cpp Line 1297 (directive at C:\ws\src\clang\test\CXX\drs

[libcxx] [flang] [lldb] [compiler-rt] [llvm] [libc] [clang] [lld] Work around GCC test failure that is caused by enabling optimizations. (PR #73998)

2023-12-02 Thread via cfe-commits
https://github.com/EricWF closed https://github.com/llvm/llvm-project/pull/73998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 0fc69b1 - [clangd] Carefully handle PseudoObjectExprs for inlay hints (#71366)

2023-12-02 Thread via cfe-commits
Author: Younan Zhang Date: 2023-12-03T02:27:45-05:00 New Revision: 0fc69b1402d75704744c73e15d278dcc8f437f0e URL: https://github.com/llvm/llvm-project/commit/0fc69b1402d75704744c73e15d278dcc8f437f0e DIFF: https://github.com/llvm/llvm-project/commit/0fc69b1402d75704744c73e15d278dcc8f437f0e.diff

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Aiden Grossman (boomanaiden154) Changes This patch adds in the ability to do a "three dot" git-clang-format between two commits. This looks at the diff between the second commit and the common merge base rather than comparing at th

[clang] ecc080c - [OpenMP] return empty stmt for `nothing` (#74042)

2023-12-03 Thread via cfe-commits
Author: Sandeep Kosuri Date: 2023-12-03T13:33:38+05:30 New Revision: ecc080c07d97f7879ce64e644cac828922a7b0d9 URL: https://github.com/llvm/llvm-project/commit/ecc080c07d97f7879ce64e644cac828922a7b0d9 DIFF: https://github.com/llvm/llvm-project/commit/ecc080c07d97f7879ce64e644cac828922a7b0d9.diff

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-03 Thread via cfe-commits
cor3ntin wrote: Thanks for this PR! Emitting a diag in `TransformTemplateParmRefExpr` would probably a better way to go about it. It's not clear to me that the assert` is an improvement , and adding a diag would not be a lot more work. Would that be something you would be willing to explore?

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-03 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/71077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-03 Thread via cfe-commits
@@ -5992,6 +5992,15 @@ static ExprResult BuildConvertedConstantExpression(Sema &S, Expr *From, /*InOverloadResolution=*/false, /*AllowObjCWritebackConversion=*/false, /*AllowE

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-03 Thread via cfe-commits
https://github.com/cor3ntin commented: Can you add a release note? Thanks. Do we need more tests in other contexts where a converted constant expression is used? https://github.com/llvm/llvm-project/pull/71077 ___ cfe-commits mailing list cfe-commits@

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-03 Thread via cfe-commits
@@ -153,7 +157,10 @@ def main(): else: if len(commits) > 2: die('at most two commits allowed; %d given' % len(commits)) - changed_lines = compute_diff_and_extract_lines(commits, files, opts.staged) + changed_lines = compute_diff_and_extract_lines(commits,

[clang] Fix dr2xx clang test (PR #74223)

2023-12-03 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/74223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-03 Thread via cfe-commits
cor3ntin wrote: @wheatman can you rebase again? I want to make sure CI passes before merging (and the bots were broken earlier today). Thanks. LGTM otherwise https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang][Sema] Add -Wswitch-default warning option (PR #73077)

2023-12-03 Thread via cfe-commits
cor3ntin wrote: @AaronBallman @erichkeane @shafik WDYT? https://github.com/llvm/llvm-project/pull/73077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Remove duplicates in @property using std::set (PR #74235)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Re-implement ObjCPropertyAttributeOrder using std::set for sorting and removing duplicates. (We can't use llvm::SmallSet because it's unordered.) --- Full diff: https://github.com/llvm/llvm-project/pull/74

[clang] 2a3f119 - [clang-format] Fix a bug in `git-clang-format --binary` (#74176)

2023-12-03 Thread via cfe-commits
Author: Owen Pan Date: 2023-12-03T02:07:07-08:00 New Revision: 2a3f1195d61e9fc1837926aa394ea73cc6f90bee URL: https://github.com/llvm/llvm-project/commit/2a3f1195d61e9fc1837926aa394ea73cc6f90bee DIFF: https://github.com/llvm/llvm-project/commit/2a3f1195d61e9fc1837926aa394ea73cc6f90bee.diff LOG:

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-12-03 Thread via cfe-commits
knightXun wrote: > @knightXun code looks reasonable, ping me when you have tests and a release > note :) got it, https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-03 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/69061 >From df15b6239557edaae8b3d7f63915bad494ad674f Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Sat, 14 Oct 2023 12:02:19 -0400 Subject: [PATCH] Remove warnings from -Wchar-subscripts for known positive cons

[clang] [clang][NFC] Refactor expected directives in C++ DRs 300-399 (PR #74243)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. --- Patch is 76.50 KiB, truncated to 20.00 KiB below, full v

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-03 Thread via cfe-commits
wheatman wrote: @cor3ntin done, thanks for taking a look https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc51a36 - [clang][NFC] Refactor expected directives in C++ DRs 300-399 (#74243)

2023-12-03 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-12-03T18:35:49+04:00 New Revision: bc51a36fd67c9ef08259612a1a04db6be51a8b76 URL: https://github.com/llvm/llvm-project/commit/bc51a36fd67c9ef08259612a1a04db6be51a8b76 DIFF: https://github.com/llvm/llvm-project/commit/bc51a36fd67c9ef08259612a1a04db6be51a8b76.

[openmp] [clang] [mlir] [llvm] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-12-03 Thread via cfe-commits
ronlieb wrote: original perf regressions seem recovered enough, thx. appreciate the info message being added for future triage... https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang] Improve bit-field in ref NTTP diagnostic (PR #71077)

2023-12-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9f78edbd20ed922cced9482f7791deb9899a6d82 bc2ea1ab74b613f700b11390a4715a0f2bec10e7 --

[clang] [flang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Eccles (tblah) Changes Enable by default for optimization levels higher than 0 (same behavior as clang). For simplicity, only forward the flag to the frontend driver when it contradicts what is implied by the optimization level. Thi

[flang] [clang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Tom Eccles (tblah) Changes Enable by default for optimization levels higher than 0 (same behavior as clang). For simplicity, only forward the flag to the frontend driver when it contradicts what is implied by the optimization leve

[libc] [llvm] [clang] [libcxx] [compiler-rt] [flang] Ensure `lli --force-interpreter` disables the OrcJIT too (PR #73717)

2023-12-03 Thread via cfe-commits
https://github.com/lhames approved this pull request. LGTM too. Thanks @allight! https://github.com/llvm/llvm-project/pull/73717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7882f38 - Fix documentation on PGO/coverage related options. (#73845)

2023-12-03 Thread via cfe-commits
Author: David Li Date: 2023-12-03T14:10:57-08:00 New Revision: 7882f380a234a8c0260b79290406967c851a0df2 URL: https://github.com/llvm/llvm-project/commit/7882f380a234a8c0260b79290406967c851a0df2 DIFF: https://github.com/llvm/llvm-project/commit/7882f380a234a8c0260b79290406967c851a0df2.diff LOG:

[clang] [clang] Exclude non-template classes when checking if constraint refers to containing template arguments (PR #74265)

2023-12-03 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/74265 When checking if the constraint uses any enclosing template parameters for [temp.friend]p9, if a containing record is used as argument, we assume that the constraint depends on enclosing template parameters wi

[clang] [clang] Exclude non-template classes when checking if constraint refers to containing template arguments (PR #74265)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes When checking if the constraint uses any enclosing template parameters for [temp.friend]p9, if a containing record is used as argument, we assume that the constraint depends on enclosing template parameters withou

[clang] [clang] Exclude non-template classes when checking if constraint refers to containing template arguments (PR #74265)

2023-12-03 Thread via cfe-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/74265 >From a8e841657b9816a78f6eb1520c8513454fe0008b Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Tue, 28 Nov 2023 21:19:13 -0500 Subject: [PATCH 1/2] [clang] Exclude non-template classes when checking if

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
https://github.com/xiangzh1 created https://github.com/llvm/llvm-project/pull/74268 Loop header with constant usually can be optimized in unroll, folding branch in such loop header at SimplifyCFG will break unroll optimization. for example: Escape folding "I < ConstNum" with "Cond2" due to loo

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (xiangzh1) Changes Loop header with constant usually can be optimized in unroll, folding branch in such loop header at SimplifyCFG will break unroll optimization. for example: Escape folding "I < ConstNum" with "Cond2" due

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (xiangzh1) Changes Loop header with constant usually can be optimized in unroll, folding branch in such loop header at SimplifyCFG will break unroll optimization. for example: Escape folding "I < ConstNum" with "Cond2" due to loops o

[clang] dff5bb9 - [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (#73250)

2023-12-03 Thread via cfe-commits
Author: David Truby Date: 2023-12-04T02:20:03Z New Revision: dff5bb92d47ef226319ba1b70a334785d7896de8 URL: https://github.com/llvm/llvm-project/commit/dff5bb92d47ef226319ba1b70a334785d7896de8 DIFF: https://github.com/llvm/llvm-project/commit/dff5bb92d47ef226319ba1b70a334785d7896de8.diff LOG: [

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
xiangzh1 wrote: Seems the check fail "dr2xx.cpp Line 1297: conversion from 'T' to 'unsigned long long' is ambiguous" has no relation with this change. https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] 239bcba - Fix [[clang::coro_wrapper]] documentation.

2023-12-03 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2023-12-04T04:11:05+01:00 New Revision: 239bcba65099558e2ec4f57d14ef6ce46b1ae74e URL: https://github.com/llvm/llvm-project/commit/239bcba65099558e2ec4f57d14ef6ce46b1ae74e DIFF: https://github.com/llvm/llvm-project/commit/239bcba65099558e2ec4f57d14ef6ce46b1ae74e.diff

[clang] fix: C++ empty record with align lead to va_list out of sync (PR #72197)

2023-12-03 Thread via cfe-commits
hstk30-hw wrote: I guess the `i8` is from https://github.com/ARM-software/abi-aa/blob/2a70c42d62e9c3eb5887fa50b71257f20daca6f9/cppabi64/cppabi64.rst#41summary-of-differences-from-and-additions-to-the-generic-c-abi > The GC++ABI defines the way in which empty class types are laid out. For the >

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
bcl5980 wrote: We should add TTI check for the condition. I believe don't unroll on X86 is a correct decision. Only like AMDGPU or NVPTX these GPU target with heavy stack cost backend target need this. https://github.com/llvm/llvm-project/pull/74268

[clang] 0f8681b - [clang][AMDGPU] precommit test for ballot on Windows (#73920)

2023-12-03 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2023-12-04T10:43:16+05:30 New Revision: 0f8681b38e51e8a68894042e638eba681f7737f1 URL: https://github.com/llvm/llvm-project/commit/0f8681b38e51e8a68894042e638eba681f7737f1 DIFF: https://github.com/llvm/llvm-project/commit/0f8681b38e51e8a68894042e638eba681f7737f

[clang] 0031efe - Remove warnings from -Wchar-subscripts for known positive constants (#69061)

2023-12-03 Thread via cfe-commits
Author: wheatman Date: 2023-12-04T06:49:37+01:00 New Revision: 0031efe6be19735402656a76b64a173d17f1f935 URL: https://github.com/llvm/llvm-project/commit/0031efe6be19735402656a76b64a173d17f1f935 DIFF: https://github.com/llvm/llvm-project/commit/0031efe6be19735402656a76b64a173d17f1f935.diff LOG:

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-03 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-12-03 Thread via cfe-commits
cor3ntin wrote: Thanks for your first contribution. Maybe the first of many :D https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Please give some time for clang-format folks to review the change as it is not my area of expertise. https://github.com/llvm/llvm-project/pull/74230 ___ cfe-commits mailing list cfe-commit

[clang] [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (PR #74279)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Youngsuk Kim (JOE1994) Changes Merge consecutive AddrSpaceCasts into a single AddrSpaceCast. --- Full diff: https://github.com/llvm/llvm-project/pull/74279.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp (+2

[clang] [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (PR #74279)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Youngsuk Kim (JOE1994) Changes Merge consecutive AddrSpaceCasts into a single AddrSpaceCast. --- Full diff: https://github.com/llvm/llvm-project/pull/74279.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU

[clang] [RISCV][NFC] Use AddTargetFeature to add fast-unaligned-access (PR #74280)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Wang Pengcheng (wangpc-pp) Changes We can reduce some code. --- Full diff: https://github.com/llvm/llvm-project/pull/74280.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Arch/RISCV.cpp (+2-7) ``diff

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
xiangzh1 wrote: > We should add TTI check for the condition. I believe don't unroll on X86 is a > correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy > stack cost need this. > > And I think you need to precommit tests first. In fact, there is no direct/strong relation wit

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
bcl5980 wrote: > > We should add TTI check for the condition. I believe don't unroll on X86 is > > a correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy > > stack cost need this. > > And I think you need to precommit tests first. > > In fact, there is no direct/strong rela

[llvm] [clang] [RISCV] Update the interface of sifive vqmaccqoq (PR #74284)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brandon Wu (4vtomat) Changes The spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf) is updated. --- Patch is 121.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/

[clang] [llvm] [RISCV] Update the interface of sifive vqmaccqoq (PR #74284)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes The spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf) is updated. --- Patch is 121.79 KiB, truncated to 20.00 KiB below, full version: https://gi

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-12-03 Thread via cfe-commits
@@ -367,3 +394,14 @@ clang::dataflow::FieldSet clang::dataflow::getObjectFields(QualType Type) { getFieldsFromClassHierarchy(Type, Fields); return Fields; } + +bool clang::dataflow::containsSameFields( +const clang::dataflow::FieldSet &Fields, +const clang::dataflo

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-12-04 Thread via cfe-commits
martinboehme wrote: > Overall, I love it! I have some comments on some features in the future, but > those are probably not going to be addressed any time soon. First of all, I > think in the future when we reason about the values of the pointers, > synthetic fields might need to have offsets

[clang] 71f2ec2 - [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (#73860)

2023-12-04 Thread via cfe-commits
Author: martinboehme Date: 2023-12-04T09:29:22+01:00 New Revision: 71f2ec2db1295462d61e1407fcc1e715ba5d458b URL: https://github.com/llvm/llvm-project/commit/71f2ec2db1295462d61e1407fcc1e715ba5d458b DIFF: https://github.com/llvm/llvm-project/commit/71f2ec2db1295462d61e1407fcc1e715ba5d458b.diff

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/73860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
https://github.com/xiangzh1 updated https://github.com/llvm/llvm-project/pull/74268 >From 21fef821eb83d0d426a5e2de20469dcdd41598f1 Mon Sep 17 00:00:00 2001 From: Zhang Xiang Date: Mon, 4 Dec 2023 16:25:37 +0800 Subject: [PATCH 1/2] [SimplifyCFG] Pre-commit test for folding branches in simplify

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
https://github.com/xiangzh1 edited https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
https://github.com/xiangzh1 edited https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > > > And I think you need to precommit tests first. Done > > In fact, there is no direct/strong relation with stack cost, it mostly base > > on unroll or not (or other loop optimizations). Maybe we should check > > "unroll" info (e.g #pragma unroll, any targets with this hint s

[clang] [clang][analyzer][NFC] Supplement comments in `evalFtell` of StreamChecker (PR #74291)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74291.diff 1 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+3) ``diff diff --git a/cl

[clang] [libclang/python] Fix some minor typos (PR #74292)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Craig Hesling (linux4life798) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74292.diff 2 Files Affected: - (modified) clang/bindings/python/README.txt (+1-1) - (modified) clang/bindings/python/clang/cindex.py (+1-1)

[clang] a3fe9cb - [clang][dataflow] Retrieve members from accessors called using member… (#73978)

2023-12-04 Thread via cfe-commits
Author: Samira Bazuzi Date: 2023-12-04T10:10:07+01:00 New Revision: a3fe9cb24da302a40c53d187271e472a6432c4f1 URL: https://github.com/llvm/llvm-project/commit/a3fe9cb24da302a40c53d187271e472a6432c4f1 DIFF: https://github.com/llvm/llvm-project/commit/a3fe9cb24da302a40c53d187271e472a6432c4f1.diff

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/73978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes This is a rework of #74176. --- Full diff: https://github.com/llvm/llvm-project/pull/74293.diff 1 Files Affected: - (modified) clang/tools/clang-format/git-clang-format (+3-2) ``diff diff --gi

[clang] 9db6423 - [clang][AMDGPU] fix the return type for ballot (#73906)

2023-12-04 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2023-12-04T15:15:02+05:30 New Revision: 9db642394dee768e8a4404978c0e5d3af07fed17 URL: https://github.com/llvm/llvm-project/commit/9db642394dee768e8a4404978c0e5d3af07fed17 DIFF: https://github.com/llvm/llvm-project/commit/9db642394dee768e8a4404978c0e5d3af07fed1

[clang] [clang][analyzer] Support `fflush` in the StreamChecker (PR #74296)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74296.diff 3 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+16) - (m

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread via cfe-commits
dyung wrote: @bazuzi and @martinboehme this change seems to be causing a test failure on many bots. Can you take a look and revert if you need time to investigate? - https://lab.llvm.org/buildbot/#/builders/139/builds/54773 - https://lab.llvm.org/buildbot/#/builders/216/builds/31319 - https://

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread via cfe-commits
martinboehme wrote: > @bazuzi and @martinboehme this change seems to be causing a test failure on > many bots. Can you take a look and revert if you need time to investigate? > > * https://lab.llvm.org/buildbot/#/builders/139/builds/54773 > * https://lab.llvm.org/buildbot/#/builders/216/builds/

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/74299 Reverts llvm/llvm-project#73978 >From 8e476a4944f7ff27b289620740b1d23aa9c57c88 Mon Sep 17 00:00:00 2001 From: martinboehme Date: Mon, 4 Dec 2023 11:27:14 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"[clang][d

[clang] 3b6d63c - Revert "[clang][dataflow] Retrieve members from accessors called using member…" (#74299)

2023-12-04 Thread via cfe-commits
Author: martinboehme Date: 2023-12-04T11:27:31+01:00 New Revision: 3b6d63c5193bf5e3ce04c71703fc5c681a62f094 URL: https://github.com/llvm/llvm-project/commit/3b6d63c5193bf5e3ce04c71703fc5c681a62f094 DIFF: https://github.com/llvm/llvm-project/commit/3b6d63c5193bf5e3ce04c71703fc5c681a62f094.diff

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes Reverts llvm/llvm-project#73978 --- Full diff: https://github.com/llvm/llvm-project/pull/74299.diff 2 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp (+2-5) - (modified)

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
bcl5980 wrote: We need at lease one more IR test. https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthew Devereau (MDevereau) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74303.diff 1 Files Affected: - (modified) clang/include/clang/Basic/arm_sme.td (+1-1) ``diff diff --git a/clang/include/clang/Basi

[clang] 6d6baef - [X86] Support CFE flags for APX features (#74199)

2023-12-04 Thread via cfe-commits
Author: Shengchen Kan Date: 2023-12-04T19:22:56+08:00 New Revision: 6d6baef5c9bf880a28c3b9861fc5c1f578b6635c URL: https://github.com/llvm/llvm-project/commit/6d6baef5c9bf880a28c3b9861fc5c1f578b6635c DIFF: https://github.com/llvm/llvm-project/commit/6d6baef5c9bf880a28c3b9861fc5c1f578b6635c.diff

[clang] d43c081 - [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (#74279)

2023-12-04 Thread via cfe-commits
Author: Youngsuk Kim Date: 2023-12-04T07:03:09-05:00 New Revision: d43c081aef505b0f1d5e887a365cd69e7f9f37b2 URL: https://github.com/llvm/llvm-project/commit/d43c081aef505b0f1d5e887a365cd69e7f9f37b2 DIFF: https://github.com/llvm/llvm-project/commit/d43c081aef505b0f1d5e887a365cd69e7f9f37b2.diff

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > We need at lease one more IR test. Let me try https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > LoopUnroll supports upper bound unrolling. Why is it not working in this case? for example: #program unroll for (int I = 0; I < LoopCount; ++I) { // ConstNum > 1 if (Cond2) { break; } xxx loop body; } After the branches fodling, the old loop condition "I < LoopCount" changed/

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. --- Patch is 51.63 KiB, truncated to 20.00 KiB below, full v

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > Can you please share the IR before the unroll pass? Sure: **with this patch**: 4523 ; *** IR Dump After LoopDeletionPass on for.body *** 4524 4525 ; Preheader: 4526 entry: 4527 br label %for.body 4528 4529 ; Loop: 4530 for.body:

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: I first guess the trip.count maybe too small, but I changed the iteration Num from 16 to 1600, without this patch, it still not unroll. https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] c556c9c - [clang][NFC] Refactor expected directives in C++ DRs 400-499 (#74311)

2023-12-04 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-12-04T18:00:09+04:00 New Revision: c556c9c3792a322dfc3a9c60be9d7d32cf335235 URL: https://github.com/llvm/llvm-project/commit/c556c9c3792a322dfc3a9c60be9d7d32cf335235 DIFF: https://github.com/llvm/llvm-project/commit/c556c9c3792a322dfc3a9c60be9d7d32cf335235.

[clang] [OpenACC] Implement 'cache' construct parsing (PR #74324)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The 'cache' construct takes a list of 'vars', which are array-section style definitions. This patch implements the parsing, leaving the lower bound and length of the bound as expressions, so that we can va

[clang-tools-extra] bc8cff1 - [clang-tidy] Add new modernize-use-starts-ends-with check (#72385)

2023-12-04 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2023-12-04T15:39:28+01:00 New Revision: bc8cff1d7fb2069aa3f7333e25642f2571049af1 URL: https://github.com/llvm/llvm-project/commit/bc8cff1d7fb2069aa3f7333e25642f2571049af1 DIFF: https://github.com/llvm/llvm-project/commit/bc8cff1d7fb2069aa3f7333e25642f2571049af1.

[clang] 374e828 - [flang] (Re-)Enable alias tags pass by default (#74250)

2023-12-04 Thread via cfe-commits
Author: Tom Eccles Date: 2023-12-04T15:28:15Z New Revision: 374e8288e047da640090629879072e4fa3af31fe URL: https://github.com/llvm/llvm-project/commit/374e8288e047da640090629879072e4fa3af31fe DIFF: https://github.com/llvm/llvm-project/commit/374e8288e047da640090629879072e4fa3af31fe.diff LOG: [f

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-04 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/74215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-04 Thread via cfe-commits
wheatman wrote: I'll change it from a assert to a diagnostic, my thought had been that it is not a fault with the program, but an issue with the compiler so figured it should be an assert. In that case I assume it should be an error and not a warning since I don't believe a correct program cou

[clang-tools-extra] 47a40e8 - Fix #41439: Update the documentation with the correct information. (#69377)

2023-12-04 Thread via cfe-commits
Author: Da-Viper Date: 2023-12-04T17:12:21+01:00 New Revision: 47a40e80c553b07a08f0f17fd68c12ae9b9a2a67 URL: https://github.com/llvm/llvm-project/commit/47a40e80c553b07a08f0f17fd68c12ae9b9a2a67 DIFF: https://github.com/llvm/llvm-project/commit/47a40e80c553b07a08f0f17fd68c12ae9b9a2a67.diff LOG:

[clang] [clang] Substitute alias templates from correct context (PR #74335)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Current context set to where alias was met, not where it is declared caused incorrect access check in case alias referenced private members of the parent class. Fixes https://github.com/llvm/llvm

[clang] e3a97df - [Verifier] Check function attributes related to branch protection (NFC) (#70565)

2023-12-04 Thread via cfe-commits
Author: Momchil Velikov Date: 2023-12-04T16:16:55Z New Revision: e3a97dffee93f03e12b5911869f9a443c39821bc URL: https://github.com/llvm/llvm-project/commit/e3a97dffee93f03e12b5911869f9a443c39821bc DIFF: https://github.com/llvm/llvm-project/commit/e3a97dffee93f03e12b5911869f9a443c39821bc.diff LO

<    37   38   39   40   41   42   43   44   45   46   >