[clang] [llvm] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-07 Thread via cfe-commits
smanna12 wrote: @AaronBallman, @erichkeane I addressed comments in the PR, could you please revisit this PR? Thank you! https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -1775,6 +1775,17 @@ CoroCleanup This pass runs late to lower all coroutine related intrinsics not replaced by earlier passes. +Attributes +== + +coro_only_destroy_when_done +--- + +When the coroutine are marked with coro_only_destroy_when_don

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
https://github.com/h-vetinari commented: > > Presumably there should only be one spelling everywhere. > > Done Missed a few. ;-) https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -O3 -emit-llvm %s -o - | FileCheck %s --check-pre

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
https://github.com/h-vetinari edited https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -318,6 +318,9 @@ def MustProgress : EnumAttr<"mustprogress", [FnAttr]>; /// Function is a presplit coroutine. def PresplitCoroutine : EnumAttr<"presplitcoroutine", [FnAttr]>; +/// The coroutine would only be destroyed when it is done. +def CoroDestroyOnlyWhenComplete : Enum

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -718,6 +718,7 @@ enum AttributeKindCodes { ATTR_KIND_NOFPCLASS = 87, ATTR_KIND_OPTIMIZE_FOR_DEBUGGING = 88, ATTR_KIND_WRITABLE = 89, + ATTR_KIND_CORO_ONLY_DESTROY_WHEN_DONE = 90, h-vetinari wrote: still `_DONE` not `_COMPLETE` (plus all later usages

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
h-vetinari wrote: filename still has `-done` not `-complete` https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,137 @@ +; RUN: opt < %s -passes='cgscc(coro-split),early-cse,dce,simplifycfg' -S | FileCheck %s + +%"struct.std::__n4861::noop_coroutine_promise" = type { i8 } +%struct.Promise = type { %"struct.std::__n4861::coroutine_handle" } +%"struct.std::__n4861::coroutine_handle

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71618 This contains https://github.com/llvm/llvm-project/pull/71622 and so that it is not easy to review this until we have stacked reviews. So the m

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71618 This contains https://github.com/llvm/llvm-project/pull/71622 and so that it is not easy to review this until we have stacked reviews. So the main pur

[clang] a070053 - [clang][dataflow] Replace one remaining call to deprecated `addToFlowCondition()`. (#71547)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-08T05:32:04+01:00 New Revision: a0700532ddcc850ff381e08576590ee26fad1f1e URL: https://github.com/llvm/llvm-project/commit/a0700532ddcc850ff381e08576590ee26fad1f1e DIFF: https://github.com/llvm/llvm-project/commit/a0700532ddcc850ff381e08576590ee26fad1f1e.diff

[clang] [clang][dataflow] Replace one remaining call to deprecated `addToFlowCondition()`. (PR #71547)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64ed4ed - [clang][dataflow] Expand debug dumping of `Value`s. (#71527)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-08T05:41:26+01:00 New Revision: 64ed4edca8e76e2ce2586584fdcb3b906532aa18 URL: https://github.com/llvm/llvm-project/commit/64ed4edca8e76e2ce2586584fdcb3b906532aa18 DIFF: https://github.com/llvm/llvm-project/commit/64ed4edca8e76e2ce2586584fdcb3b906532aa18.diff

[clang] [clang][dataflow] Expand debug dumping of `Value`s. (PR #71527)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SEH] Fix assertin when return scalar value from __try block. (PR #71488)

2023-11-07 Thread via cfe-commits
https://github.com/jyu2-git closed https://github.com/llvm/llvm-project/pull/71488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c79b544 - [SEH] Fix assertin when return scalar value from __try block. (#71488)

2023-11-07 Thread via cfe-commits
Author: jyu2-git Date: 2023-11-07T20:43:40-08:00 New Revision: c79b544d2b988e26f35db829088e0e5088c57498 URL: https://github.com/llvm/llvm-project/commit/c79b544d2b988e26f35db829088e0e5088c57498 DIFF: https://github.com/llvm/llvm-project/commit/c79b544d2b988e26f35db829088e0e5088c57498.diff LOG:

[clang] 5918f62 - [InstCombine] Infer zext nneg flag (#71534)

2023-11-08 Thread via cfe-commits
Author: Nikita Popov Date: 2023-11-08T09:34:40+01:00 New Revision: 5918f62301788b53e7d3a23f3203c483e9d4d791 URL: https://github.com/llvm/llvm-project/commit/5918f62301788b53e7d3a23f3203c483e9d4d791 DIFF: https://github.com/llvm/llvm-project/commit/5918f62301788b53e7d3a23f3203c483e9d4d791.diff

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-11-08 Thread via cfe-commits
tschuett wrote: It could also be a `surface BMI` as it only describes the surface of the module, but it does not contain its content. https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Enums without enumerators (empty) are now excluded from analysis as it's not possible to peroperly determinate new narrowed type, and such enums can be used in diffrent way, like as strong-types. Close

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-08 Thread via cfe-commits
https://github.com/simpal01 edited https://github.com/llvm/llvm-project/pull/71545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 32a3f2a - [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (#71139)

2023-11-08 Thread via cfe-commits
Author: Pravin Jagtap Date: 2023-11-08T15:09:10+05:30 New Revision: 32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c URL: https://github.com/llvm/llvm-project/commit/32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c DIFF: https://github.com/llvm/llvm-project/commit/32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c.diff

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

2023-11-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8c014e5949fdbecc31a82138361f8cdf886768a9 5fca3fdf781dc849db770975b9f7017b091cd112 --

[clang] [clang][Interp] Consider bit width in toAPSInt() (PR #71646)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes In `Interp.h`, when a add/sub/mul fails, we call this code and expect to get an `APSInt` back that can handle more than the current bitwidth of the type. --- Full diff: https://github.com/llvm/llvm-project/p

[clang] e6a94dc - [clang][Interp] Fix creating APSInt from IntegralAP (#71410)

2023-11-08 Thread via cfe-commits
Author: Timm Baeder Date: 2023-11-08T10:48:07+01:00 New Revision: e6a94dca38d77db2678366c55bb7b72cfa312487 URL: https://github.com/llvm/llvm-project/commit/e6a94dca38d77db2678366c55bb7b72cfa312487 DIFF: https://github.com/llvm/llvm-project/commit/e6a94dca38d77db2678366c55bb7b72cfa312487.diff L

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-08 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-08 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-08 Thread via cfe-commits
@@ -3197,6 +3197,26 @@ TEST(TransferTest, AggregateInitialization_NotExplicitlyInitializedField) { }); } +TEST(TransferTest, AggregateInitializationFunctionPointer) { + // This is a crash repro. martinboehme wrote: ```suggestion // This is a repro f

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-08 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement IntegralAP subtraction (PR #71648)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The tests currently fail because they need one of the other open `IntegralAP` PRs. Will update this once they are pushed. --- Full diff: https://github.com/llvm/llvm-project/pull/71648.diff 2 Files Affect

[clang-tools-extra] 3716b5b - [clang-tidy] Improve performance-enum-size to exclude empty enums (#71640)

2023-11-08 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-11-08T11:22:31+01:00 New Revision: 3716b5b4bac6ab41291b6558ad0444cbcca04aa3 URL: https://github.com/llvm/llvm-project/commit/3716b5b4bac6ab41291b6558ad0444cbcca04aa3 DIFF: https://github.com/llvm/llvm-project/commit/3716b5b4bac6ab41291b6558ad0444cbcca04aa3.diff L

[clang-tools-extra] 2626916 - [clangd] Allow hover over 128-bit variable without crashing (#71415)

2023-11-08 Thread via cfe-commits
Author: Björn Pettersson Date: 2023-11-08T11:30:03+01:00 New Revision: 2626916c45f428226052f5e431e510743aba9e75 URL: https://github.com/llvm/llvm-project/commit/2626916c45f428226052f5e431e510743aba9e75 DIFF: https://github.com/llvm/llvm-project/commit/2626916c45f428226052f5e431e510743aba9e75.di

[clang-tools-extra] [clang-tidy] Fix handling of functional cast in google-readability-casting (PR #71650)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Fix issue with constructor call being interpreted as functional cast and considered for a replacement with static cast or being removed as redundant. Closes #57959 --- Full diff: https://github.com/llv

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes There used to be a patch similar to this on Phabricator. I asked a long time ago if I can pick it up but the author told me they will work on it, which never happened. IIRC there also was a problem with thi

[clang] [clang][dataflow][NFC] Fix stale comments. (PR #71654)

2023-11-08 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/71654 None >From 3e889b59ee171c1665b365a933ba3578c4135ed3 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 8 Nov 2023 10:51:50 + Subject: [PATCH] [clang][dataflow][NFC] Fix stale comments. --- clang

[clang] [clang][dataflow][NFC] Fix stale comments. (PR #71654)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71654.diff 1 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/Arena.h (+4-4) ``diff diff --git a/clang/incl

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

2023-11-08 Thread via cfe-commits
https://github.com/nvartolomei updated https://github.com/llvm/llvm-project/pull/71586 >From 0dbdbc35e9dd3f28f8688d8ebf91f977fda98c79 Mon Sep 17 00:00:00 2001 From: Nicolae Vartolomei Date: Tue, 7 Nov 2023 20:25:43 + Subject: [PATCH] [clang-tidy] readability-identifier-naming: add support f

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

2023-11-08 Thread via cfe-commits
https://github.com/nvartolomei edited https://github.com/llvm/llvm-project/pull/71586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

2023-11-08 Thread via cfe-commits
nvartolomei wrote: @PiotrZSL thank you for your time reviewing this change. I have updated the release notes and PR description. I'm new to this project and not familiar with its customs. Apologize for any mistakes. https://github.com/llvm/llvm-project/pull/71586 __

[clang] Fix lit test clang/test/CodeGenHIP/dpp-const-fold.hip. added (PR #71656)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pravin Jagtap (pravinjagtap) Changes during #71139 -nogpulib was missing. --- Full diff: https://github.com/llvm/llvm-project/pull/71656.diff 1 Files Affected: - (modified) clang/test/CodeGenHIP/dpp-const-fold.hip (+1-1) ``d

[clang] [clang][Interp] Implement __builtin_parity (PR #71662)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71662.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/InterpBuiltin.cpp (+16) - (modified) clang/test/AST/Interp/builtin-functions.cpp (+

[llvm] [clang] [SystemZ] Add backchain target-feature (PR #71668)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Leoshkevich (iii-i) Changes GCC supports building individual functions with backchain using the __attribute__((target("backchain"))) syntax, and Clang should too. Clang translates this into the "target-features"="+backchain" attribut

[clang] Revert "Revert "[AMDGPU] const-fold imm operands of (PR #71669)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Pravin Jagtap (pravinjagtap) Changes amdgcn_update_dpp intrinsic (#71139)"" This reverts commit d1fb9307951319eea3e869d78470341d603c8363 and fixes the lit test clang/test/CodeGenHIP/dpp-const-fold.hip -

[clang] [clang] Print static_assert values of arithmetic binary operators (PR #71671)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes These are actually quite useful to print. --- Full diff: https://github.com/llvm/llvm-project/pull/71671.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+4-4) - (modified) clang/test/S

[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Björn Schäpers (HazardyKnusperkeks) Changes Fixes http://llvm.org/PR55487 The code did not match the documentation about Cpp11BracedListStyle. Changed handling of comments after opening braces, which are supposedly function call l

[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)

2023-11-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b44399296a7fa4323ab32739df6dbcfc6068af8f 4548aa1186531fb93a623144278fe72896d47e89 --

[llvm] [clang] [SVE2.1][Clang][LLVM]Int/FP reduce builtin in Clang and LLVM intrinsic (PR #69926)

2023-11-08 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/69926 >From 9578865054e6fe83de496df7842fa991ba9c2541 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Mon, 23 Oct 2023 12:52:48 + Subject: [PATCH 1/2] [SVE2.1][Clang][LLVM]Int/FP reduce builtin in Cl

[clang] [llvm] [SVE2.1][Clang][LLVM]Int/FP reduce builtin in Clang and LLVM intrinsic (PR #69926)

2023-11-08 Thread via cfe-commits
@@ -0,0 +1,285 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s +// RUN: %cla

[clang] d79fff0 - [SystemZ] Add backchain target-feature (#71668)

2023-11-08 Thread via cfe-commits
Author: Ilya Leoshkevich Date: 2023-11-08T15:05:47+01:00 New Revision: d79fff0abb5a8ae6f49f5e3fd4f31d65717c7a37 URL: https://github.com/llvm/llvm-project/commit/d79fff0abb5a8ae6f49f5e3fd4f31d65717c7a37 DIFF: https://github.com/llvm/llvm-project/commit/d79fff0abb5a8ae6f49f5e3fd4f31d65717c7a37.di

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/71677 None >From 700376a265e3f349f5faece740e1823a2f19930c Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH] [clang] Avoid memcopy for small structure with

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (serge-sans-paille) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71677.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGDecl.cpp (+10-9) - (modified) clang/test/CodeGenCXX/auto-var-init.cpp (+19

[clang] [SystemZ] Do not run mbackchain-4.c test without SystemZ target (PR #71678)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Leoshkevich (iii-i) Changes mbackchain-4.c requires running the backend and causes CI failures when this target is not configured. --- Full diff: https://github.com/llvm/llvm-project/pull/71678.diff 1 Files Affected: - (modified)

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 26ab444e88fc8fdd554e5a9381a68b7b5e63b6fd 700376a265e3f349f5faece740e1823a2f19930c --

[clang] [llvm] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-08 Thread via cfe-commits
smanna12 wrote: > > @AaronBallman, @erichkeane I have addressed comments in the PR, could you > > please revisit this PR? Thank you! > > I'm still away at the WG21 meeting, but I've got this on my list of things to > review when I return. Thank you @AaronBallman https://github.com/llvm/llvm

[clang-tools-extra] [clang-tidy] Add AllowImplicitlyDeletedCopyOrMove option to cppcoreguidelines-special-member-functions (PR #71683)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Improved cppcoreguidelines-special-member-functions check with a new option AllowImplicitlyDeletedCopyOrMove, which removes the requirement for explicit copy or move special member functions when they a

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/71677 >From a35d351a8eb811ed59734ea49c8f912771ef5c2e Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH 1/2] [clang] Avoid memcopy for small structure with p

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/71677 >From 388335f795186e06cd9dfc1ef22f882901959d4d Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH 1/2] [clang] Avoid memcopy for small structure with p

[clang] [clang] Avoid memcopy for small structure with padding (PR #71677)

2023-11-08 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/71677 >From d5934a4112166ce0375295b2347e7d5c43fdf5ed Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH 1/2] [clang] Avoid memcopy for small structure with p

[clang] a933e14 - [SystemZ] Do not run mbackchain-4.c test without SystemZ target (#71678)

2023-11-08 Thread via cfe-commits
Author: Ilya Leoshkevich Date: 2023-11-08T15:53:10+01:00 New Revision: a933e1417bbc0a4af24ac3b306b0edecf069263c URL: https://github.com/llvm/llvm-project/commit/a933e1417bbc0a4af24ac3b306b0edecf069263c DIFF: https://github.com/llvm/llvm-project/commit/a933e1417bbc0a4af24ac3b306b0edecf069263c.di

[clang] [clang][Interp] Implement __builtin_bitreverse (PR #71687)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Since the return value of this function is slightly more involved than the void/bool/int/size_t return values we've seen so far, also refactor this. --- Full diff: https://github.com/llvm/llvm-project/pull/7

[clang] [Clang][SME2] Add single and multi min and max builtins (PR #71688)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sam Tebbs (SamTebbs33) Changes Adds the following SME2 builtins: svmin_single_(s8|s16|s32|s64)_x(2|4) svmin_single_(u8|u16|u32|u64)_x(2|4) svmin_single_(f16|f32|f64)_x(2|4) svmin_(s8|s16|s32|s64)_x(2|4) svmin_(u8|u16|u3

[clang] [clang][CodeGen] Ensure consistent `mustprogress` attribute emission across all paths (PR #71452)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Antonio Frighetto (antoniofrighetto) Changes Emission of `mustprogress` attribute was previously occuring only when entering `EmitFunctionBody`. Other paths for function body generation may lack the attribute, potentially leading to subop

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-11-08 Thread via cfe-commits
tdupes wrote: Oh I wasn't aware of that issue, that is the exact bug I am aiming to fix. https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qiu Chaofan (ecnelises) Changes If return type of overriden method is pointer or reference to non-class type, qualifiers cannot be dropped. This also fixes check when qualifier of overriden method's class return type is not subset of supe

[clang] Revert "Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes" (PR #71697)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Arthur Eubanks (aeubanks) Changes This reverts commit 578a4716f549167165a2ec3bac89c86706136d4e. This causes multiple issues. Compile time slowdown due to more path canonicalization, and weird behavior on

[clang-tools-extra] [clang] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-08 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

2023-11-08 Thread via cfe-commits
https://github.com/serge-sans-paille edited https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-11-08 Thread via cfe-commits
https://github.com/tdupes updated https://github.com/llvm/llvm-project/pull/71605 >From 31f45a8665a09bdc5a2da35d0f786451cf7d5319 Mon Sep 17 00:00:00 2001 From: dup Date: Fri, 3 Nov 2023 09:03:24 -0700 Subject: [PATCH] Add container field to remote index Refs grpc method --- clang-tools-extra/

[clang-tools-extra] [clang-tidy] Add AllowStringArrays option to modernize-avoid-c-arrays (PR #71701)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Add AllowStringArrays option, enabling the exclusion of array types with deduced sizes constructed from string literals. This includes only var declarations of array of characters constructed directly f

[clang-tools-extra] [Clangd] Sanitize path before recording into IncludeStructure during buildPreamble (PR #70798)

2023-11-08 Thread via cfe-commits
https://github.com/Maddobun updated https://github.com/llvm/llvm-project/pull/70798 >From 0572afa42e4e6ca1d1de0e9df045828552cb4480 Mon Sep 17 00:00:00 2001 From: Leo Zhu Date: Wed, 8 Nov 2023 11:10:13 -0500 Subject: [PATCH] Convert URI to uppercase drive letter during parsing --- clang-tools-

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
https://github.com/elizabethandrews created https://github.com/llvm/llvm-project/pull/71706 Currently target_clones attribute results in a linker error when there are no multi-versioned function declarations in the calling TU. In the calling TU, the call is generated with the ‘normal’ assembly

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (elizabethandrews) Changes Currently target_clones attribute results in a linker error when there are no multi-versioned function declarations in the calling TU. In the calling TU, the call is generated with the ‘normal’ asse

[clang] [Clang][SME2] Add single and multi min/max by vector builtins (PR #71707)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sam Tebbs (SamTebbs33) Changes Adds the following SME2 builtins: svminnm_single_f(16|32|64)_x(2|4) svminnm_f(16|32|64)_x(2|4) svmaxnm_single_f(16|32|64)_x(2|4) svmaxnm_f(16|32|64)_x(2|4) See [ARM-software/acle#217](https://github.com/ARM-

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch refactors how values are stored inside `IdentifierInfo::ObjcOrBuiltinID` bit-field, and annotates it with `preferred_type`. In order to make the value easier to interpret by debuggers, a ne

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-11-08 Thread via cfe-commits
https://github.com/tdupes updated https://github.com/llvm/llvm-project/pull/71605 >From d2a6bec499b7163cfa97104113d0b7e297fe2f92 Mon Sep 17 00:00:00 2001 From: dup Date: Fri, 3 Nov 2023 09:03:24 -0700 Subject: [PATCH] Add container field to remote index Refs grpc method --- clang-tools-extra/

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
@@ -4098,8 +4098,26 @@ void CodeGenModule::emitMultiVersionFunctions() { } llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD); -if (auto *IFunc = dyn_cast(ResolverConstant)) +if (auto *IFunc = dyn_cast(ResolverConstant)) { ResolverCon

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
https://github.com/elizabethandrews edited https://github.com/llvm/llvm-project/pull/71706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
https://github.com/elizabethandrews edited https://github.com/llvm/llvm-project/pull/71706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [openmp] [llvm] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-11-08 Thread via cfe-commits
dhruvachak wrote: With reference to the performance degradation, this patch introduces an additional allocation/data-submit/deallocation for every kernel (GenericKernelTy::getKernelLaunchEnvironment(), PluginInterface.cpp). Analysis shows that this overhead appears to be the primary reason for

[clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-08 Thread via cfe-commits
elizabethandrews wrote: I ran some tests compiling TU1 and TU2 in various combinations of clang17, trunk and g++. TU1.cpp ``` int foo(); int main() { return foo(); } ``` TU2.cpp ``` #include __attribute__((target_clones("default", "arch=sapphirerapids"))) int foo() { std::cout<<"Hello

[clang] c6cf329 - [CodeGen] Implement post-opt linking option for builtin bitocdes (#69371)

2023-11-08 Thread via cfe-commits
Author: Jacob Lambert Date: 2023-11-08T10:53:49-08:00 New Revision: c6cf32950283f729dfe9a9b2626443d05e2cb1b1 URL: https://github.com/llvm/llvm-project/commit/c6cf32950283f729dfe9a9b2626443d05e2cb1b1 DIFF: https://github.com/llvm/llvm-project/commit/c6cf32950283f729dfe9a9b2626443d05e2cb1b1.diff

[clang] 955dd88 - Revert "Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes" (#71697)

2023-11-08 Thread via cfe-commits
Author: Arthur Eubanks Date: 2023-11-08T11:43:35-08:00 New Revision: 955dd8800b4745784bf6da948ec7992d5b75b4d7 URL: https://github.com/llvm/llvm-project/commit/955dd8800b4745784bf6da948ec7992d5b75b4d7 DIFF: https://github.com/llvm/llvm-project/commit/955dd8800b4745784bf6da948ec7992d5b75b4d7.diff

[clang] [flang] [flang] add fveclib flag (PR #71734)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Tom Eccles (tblah) Changes -fveclib= allows users to choose a vectorized libm so that loops containing math functions are vectorized. This is implemented as much as possible in the same way as in clang. T

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
https://github.com/diggerlin created https://github.com/llvm/llvm-project/pull/71738 copy implement of https://github.com/llvm/llvm-project/pull/71359 to AIX.cpp and add test scenario >From 592e0de1d87ad5dbfc7a1fb80974546ce161c02f Mon Sep 17 00:00:00 2001 From: zhijian Date: Wed, 8 Nov 2023 1

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (diggerlin) Changes copy implement of https://github.com/llvm/llvm-project/pull/71359 to AIX.cpp and add test scenario --- Full diff: https://github.com/llvm/llvm-project/pull/71738.diff 2 Files Affected: - (modified) clang/lib/Dr

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (diggerlin) Changes copy implement of https://github.com/llvm/llvm-project/pull/71359 to AIX.cpp and add test scenario --- Full diff: https://github.com/llvm/llvm-project/pull/71738.diff 2 Files Affected: - (modified) clang

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/71738 >From 592e0de1d87ad5dbfc7a1fb80974546ce161c02f Mon Sep 17 00:00:00 2001 From: zhijian Date: Wed, 8 Nov 2023 11:27:30 -0500 Subject: [PATCH 1/2] [Driver][LTO] Copy fix empty stats filename to AIX --- clang/lib

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/71738 >From 592e0de1d87ad5dbfc7a1fb80974546ce161c02f Mon Sep 17 00:00:00 2001 From: zhijian Date: Wed, 8 Nov 2023 11:27:30 -0500 Subject: [PATCH 1/3] [Driver][LTO] Copy fix empty stats filename to AIX --- clang/lib

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-08 Thread via cfe-commits
@@ -32,6 +32,14 @@ // CHECK-LTO: "-o" "obj/dir{{/|}}save-stats.exe" // CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats" + +// RUN: %clang --target=powerpc-unknown-aix -save-stats -flto -o obj/dir/save-stats %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-AIX-LTO +//

[llvm] [openmp] [clang] ReworkCtorDtor (PR #71739)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes - [NVPTX] Allow the ctor/dtor lowering pass to emit kernels - [OpenMP] Rework handling of global ctor/dtors in OpenMP --- Patch is 57.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/

[clang] [llvm] [openmp] ReworkCtorDtor (PR #71739)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Joseph Huber (jhuber6) Changes - [NVPTX] Allow the ctor/dtor lowering pass to emit kernels - [OpenMP] Rework handling of global ctor/dtors in OpenMP --- Patch is 57.79 KiB, truncated to 20.00 KiB below, full version: https://git

[clang] [llvm] [libc++][hardening] Fix references to old names for hardening modes (PR #71743)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Konstantin Varlamov (var-const) Changes This should fix some builds broken by https://github.com/llvm/llvm-project/pull/70575 --- Full diff: https://github.com/llvm/llvm-project/pull/71743.diff 3 Files Affected: - (modified) clang/cma

[clang] 4a9c71b - [libc++][hardening] Fix references to old names for hardening modes (#71743)

2023-11-08 Thread via cfe-commits
Author: Konstantin Varlamov Date: 2023-11-08T13:16:01-10:00 New Revision: 4a9c71b8c2d01bf4efacf488d46ed2d92e71f355 URL: https://github.com/llvm/llvm-project/commit/4a9c71b8c2d01bf4efacf488d46ed2d92e71f355 DIFF: https://github.com/llvm/llvm-project/commit/4a9c71b8c2d01bf4efacf488d46ed2d92e71f355

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-08 Thread via cfe-commits
https://github.com/jyu2-git created https://github.com/llvm/llvm-project/pull/71748 We got a error: LLVM ERROR: Associative COMDAT symbol '??_7?$T@V6B@' is not a key for its COMDAT Current we create internal alias for vftable when lambd is used. For the test, IR generate: $"??_7?$T@V@@$0A@

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (jyu2-git) Changes We got a error: LLVM ERROR: Associative COMDAT symbol '??_7?$T@V6B@' is not a key for its COMDAT Current we create internal alias for vftable when lambd is used. For the test, IR generate: $"??

[clang] ExtractAPI: use zero-based indices for line/column in symbol graph (PR #71753)

2023-11-08 Thread via cfe-commits
https://github.com/QuietMisdreavus created https://github.com/llvm/llvm-project/pull/71753 Other implementations of the symbol graph format use zero-based indices for source locations, which causes problems when combined with clang's current one-based indices. This commit sets ExtractAPI's sym

[clang] ExtractAPI: use zero-based indices for line/column in symbol graph (PR #71753)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: QuietMisdreavus (QuietMisdreavus) Changes Other implementations of the symbol graph format use zero-based indices for source locations, which causes problems when combined with clang's current one-based indices. This commit sets ExtractAP

[clang] ExtractAPI: use zero-based indices for line/column in symbol graph (PR #71753)

2023-11-08 Thread via cfe-commits
QuietMisdreavus wrote: An unfortunate side effect of changing the source location representation is that it required changing almost all the ExtractAPI tests. 😅 But the overall diff is rather small. cc @daniel-grumberg https://github.com/llvm/llvm-project/pull/71753 _

[clang] [clang-format] Handle variable declarations in BreakAfterAttributes (PR #71755)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Also cleaned up some old test cases. Fixes #71563. --- Full diff: https://github.com/llvm/llvm-project/pull/71755.diff 4 Files Affected: - (modified) clang/docs/ClangFormatStyleOptions.rst (+2-2) - (mo

[clang] 68d618f - [clang-format] Add ability for clang-format-diff to exit with non-0 status (#70883)

2023-11-08 Thread via cfe-commits
Author: Conrad Donahue Date: 2023-11-08T18:13:03-08:00 New Revision: 68d618f908458e7513e2a56be292216ea0e4ef3f URL: https://github.com/llvm/llvm-project/commit/68d618f908458e7513e2a56be292216ea0e4ef3f DIFF: https://github.com/llvm/llvm-project/commit/68d618f908458e7513e2a56be292216ea0e4ef3f.diff

<    1   2   3   4   5   6   7   8   9   10   >