[clang] [clang-format] Option to ignore macro definitions (PR #70338)

2023-11-28 Thread via cfe-commits
https://github.com/tomekpaszek updated https://github.com/llvm/llvm-project/pull/70338 >From 25ca978ef9caf372997f2ebf227fb2b2ca443aa0 Mon Sep 17 00:00:00 2001 From: Tomek Paszek Date: Sat, 11 Nov 2023 19:38:00 +0100 Subject: [PATCH 01/15] Added an option to ignore macro definitions. --- clang

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-11-28 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: DonatNagyE wrote: Note that (if I understand it correctly) after this change the `ArrayBoundV2` check may be triggered at a slightly earlier point of the analysis and thi

[libc] [compiler-rt] [clang] [libcxx] [llvm] [lldb] [flang] [clang-tools-extra] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: > So it's not so much that it's not actually true in the implementation > details, it's that it's not actually true by specification either. +1. I really do not want `-E` to start not expanding, or transforming directives. I do not see a difference between a large embed and a l

[clang-tools-extra] [llvm] [clang] [Clang] Fix linker error for function multiversioning (PR #71706)

2023-11-28 Thread via cfe-commits
elizabethandrews wrote: Thank you reviews! I apologize for the delay in my response. I was OOO last week. I will apply review comments and push an update ASAP. https://github.com/llvm/llvm-project/pull/71706 ___ cfe-commits mailing list cfe-commits@li

[clang] 21361bb - [clang] Remove unused argument. NFC. (#73594)

2023-11-28 Thread via cfe-commits
Author: Juergen Ributzka Date: 2023-11-28T09:19:39-08:00 New Revision: 21361bb8605fd26a06312d80b9fb20a8b41c58ed URL: https://github.com/llvm/llvm-project/commit/21361bb8605fd26a06312d80b9fb20a8b41c58ed DIFF: https://github.com/llvm/llvm-project/commit/21361bb8605fd26a06312d80b9fb20a8b41c58ed.di

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sam Tebbs (SamTebbs33) Changes This patch introduces a warning that is emitted when a Neon builtin is called from a streaming function, as that situation is not supported. Uses work by Kerry McLaughlin. --- Full diff: https://github.com/

[lld] [lldb] [clang] [mlir] [compiler-rt] [clang-tools-extra] [llvm] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-11-28 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange --- libcxx/i

[lld] [lldb] [clang] [mlir] [compiler-rt] [clang-tools-extra] [llvm] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-11-28 Thread via cfe-commits
ZijunZhaoCCK wrote: > Gentle ping. There's outstanding feedback to address on this review. > @ZijunZhaoCCK if you don't think you'll have time to pursue this PR anymore, > it's all good but please let us know so we can assign it to someone else! Sorry for the late reply! I can’t make it a prio

[openmp] [llvm] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-11-28 Thread via cfe-commits
ronlieb wrote: @jdoerfert please respond to our comments about peformance degradation ? https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] 98e674c - [clang] Non-object types are non-trivially relocatable (#69734)

2023-11-28 Thread via cfe-commits
Author: Amirreza Ashouri Date: 2023-11-28T19:44:38+01:00 New Revision: 98e674c9f16d677d95c67bc130e267fae331e43c URL: https://github.com/llvm/llvm-project/commit/98e674c9f16d677d95c67bc130e267fae331e43c DIFF: https://github.com/llvm/llvm-project/commit/98e674c9f16d677d95c67bc130e267fae331e43c.di

[clang] [clang] Non-object types are non-trivially relocatable (PR #69734)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/69734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73463 >From a1d36de81074ad17bc5d22a4c5906f5a0bfa65c4 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Sun, 26 Nov 2023 22:47:51 +0100 Subject: [PATCH 1/2] [Clang] Eagerly instantiate used constexpr function upon d

[clang] a8ac930 - [Flang] Add code-object-version option (#72638)

2023-11-28 Thread via cfe-commits
Author: Dominik Adamski Date: 2023-11-28T19:57:36+01:00 New Revision: a8ac930b99d93b2a539ada7e566993d148899144 URL: https://github.com/llvm/llvm-project/commit/a8ac930b99d93b2a539ada7e566993d148899144 DIFF: https://github.com/llvm/llvm-project/commit/a8ac930b99d93b2a539ada7e566993d148899144.dif

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @zygoloid It took me a while, but I think I got it; what do you think of direction ? (description in the last commit message) It appears I am doing something a bit novel, but I couldn't think of a better way. https://github.com/llvm/llvm-project/pull/73463 _

[clang] [OpenMP] Support for `nothing` in `metadirective` (PR #73690)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-openmp Author: Sandeep Kosuri (sandeepkosuri) Changes - Removed an unnecessary check that was preventing `nothing` to work properly inside `metadirective`. --- Full diff: https://github.com/llvm/llvm-project/pull/73690.diff 4 Files Affected: - (modi

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Currently when parsing a nested requirement we attempt to balance parens if we have a parameter list. This will fail in some cases of ill-formed code and keep going until we fall off the token stream and c

[clang] [clang][CodeGen] Emit atomic IR instead of libcalls for misaligned po… (PR #73176)

2023-11-28 Thread via cfe-commits
Logikable wrote: I believe Clang currently does not properly propagate alignment information for certain IR (e.g. atomicrmw and cmpxchg). Look at the definitions of `CreateAtomic*` in Clang. The patches in https://bugs.llvm.org/show_bug.cgi?id=27168 did not address this (thanks @MaskRay for h

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes The internals manual seems like a more obvious home for the details instead of hiding them away in a header file and relying on doxygen output to document it publicly. --- Full diff: https://github.co

[clang] 17feb33 - [flang][Driver] Let the linker fail on multiple definitions of main() (#73124)

2023-11-28 Thread via cfe-commits
Author: Michael Klemm Date: 2023-11-28T14:20:30-06:00 New Revision: 17feb330aab39c6c0c21ee9b02efb484dfb2261e URL: https://github.com/llvm/llvm-project/commit/17feb330aab39c6c0c21ee9b02efb484dfb2261e DIFF: https://github.com/llvm/llvm-project/commit/17feb330aab39c6c0c21ee9b02efb484dfb2261e.diff

[clang] d462621 - [HLSL] Parameter modifier parsing and AST (#72139)

2023-11-28 Thread via cfe-commits
Author: Chris B Date: 2023-11-28T15:03:10-06:00 New Revision: d4626216943f8c4712bd17a709e439a0ffd0006b URL: https://github.com/llvm/llvm-project/commit/d4626216943f8c4712bd17a709e439a0ffd0006b DIFF: https://github.com/llvm/llvm-project/commit/d4626216943f8c4712bd17a709e439a0ffd0006b.diff LOG:

[compiler-rt] [mlir] [libc] [clang] [llvm] [clang-tools-extra] [flang] [libcxx] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-28 Thread via cfe-commits
=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a3529aa92ee48552946066330f5302

[clang] [clang] Fix error in gcc 7.5. on arm32-linux (PR #73702)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Johnson (steven-johnson) Changes Apparently the gcc 7.5 compiler for arm32-linux fails to implicitly convert to std::optional; this inserts an explicit constructor to unbreak that compiler. [Injection from https://reviews.llvm.org

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Jacob Lambert (lamb-j) Changes In this patch, we add support for checking a heterogeneous archive. We also significantly improve the clang-offload-bundler documentation. --- Patch is 23.51 KiB, truncated

[clang] [clang][DependencyScanner] Include the working directory in the context hash (PR #73719)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Spencer (Bigcheese) Changes The working directory is included in the PCM, but is not currently part of the context hash. This causes problems because different builds of a PCM with exactly the same command line can end up with dif

[clang] 57a0416 - [clang][CodeGen] Handle template parameter objects with explicit address spaces (#69266)

2023-11-28 Thread via cfe-commits
Author: Alex Voicu Date: 2023-11-29T00:15:18Z New Revision: 57a0416e0e8ccd522d4242dbe5d0d7893864a10a URL: https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a DIFF: https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a.diff LOG: [c

[libcxx] [clang-tools-extra] [libc] [flang] [lld] [compiler-rt] [llvm] [libunwind] [mlir] [clang] [libcxxabi] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-11-28 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/17] [libc++] Implement ranges::contains Differential Revision

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes This is an alternative to https://github.com/llvm/llvm-project/pull/73465. It generates the GEP directly. It's not tested well, but it might be a nicer solution rather than adding AST nodes. PTAL --- Fu

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4eb421192479dbecae2621b868e55aaf6d945b02 3e500c2a7c6b7895ebe292a1ed50e04409ba149c --

[clang] 3287ae8 - [clang][ASTImporter] IdentifierInfo of Attribute should be set using 'ToASTContext' (#73290)

2023-11-28 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-11-29T09:33:37+08:00 New Revision: 3287ae8f6520ef81570377c1fb4c7147782a13ef URL: https://github.com/llvm/llvm-project/commit/3287ae8f6520ef81570377c1fb4c7147782a13ef DIFF: https://github.com/llvm/llvm-project/commit/3287ae8f6520ef81570377c1fb4c7147782a13ef.diff LOG:

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Michael Spencer (Bigcheese) Changes `-ivfsoverlay` files are unused when building most modules. Enable removing them by, * adding a way to visit the filesystem tree with extensible RTTI to access each `RedirectingFileSystem`. * Add

[llvm] [clang] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-28 Thread via cfe-commits
lifengxiang1025 wrote: > Yes, you're right. As an alternative can we use the symbol table and find > Bind = LOCAL to add the prefix before hashing? If we choose this method. I think we can't deal with the situation which one symbol is not local linkage type in thin compile, but will be convert

[clang] 4a294b5 - [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (#73160)

2023-11-28 Thread via cfe-commits
Author: Yuxuan Chen Date: 2023-11-28T19:04:29-08:00 New Revision: 4a294b5806417aa88c91aa05735b2d557ea5dfe5 URL: https://github.com/llvm/llvm-project/commit/4a294b5806417aa88c91aa05735b2d557ea5dfe5 DIFF: https://github.com/llvm/llvm-project/commit/4a294b5806417aa88c91aa05735b2d557ea5dfe5.diff L

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dan Klishch (DanShaders) Changes This causes CI failure for PRs updating `AttrDocs.td`. CC @llvm-beanz --- Full diff: https://github.com/llvm/llvm-project/pull/73737.diff 1 Files Affected: - (modified) clang/include/clang/Basic/AttrDocs

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/73018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. That looks reasonable to me modulo nit and @shafik comments. Thanks for fixing this! https://github.com/llvm/llvm-project/pull/73018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II, SourceLocation NameLoc, } } } -// If typo correction failed or was not performed, fall through -[[fallthrough]]; +Result.suppressDiagnostics(); +return nullptr; + cas

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/73737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c6d6a57 - [clang][docs] Fix emphasis syntax in attribute documentation (#73737)

2023-11-28 Thread via cfe-commits
Author: Dan Klishch Date: 2023-11-29T05:34:31+01:00 New Revision: c6d6a57c697452e9320acea86f6631a92ab8017c URL: https://github.com/llvm/llvm-project/commit/c6d6a57c697452e9320acea86f6631a92ab8017c DIFF: https://github.com/llvm/llvm-project/commit/c6d6a57c697452e9320acea86f6631a92ab8017c.diff L

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/73737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/73691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Missing a release note, otherwise LGTM https://github.com/llvm/llvm-project/pull/73691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
@@ -3639,6 +3639,10 @@ ExprResult Parser::ParseRequiresExpression() { // TryParseParameterDeclarationClause). cor3ntin wrote: Yeah, I think we can remove that https://github.com/llvm/llvm-project/pull/73691

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. I am happy with the lexing/sema changes. Please give @AaronBallman the opportunity to look at the code gen bits. https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list cfe-co

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

2023-11-28 Thread via cfe-commits
@@ -34,6 +34,19 @@ PrimType getIntPrimType(const InterpState &S) { llvm_unreachable("Int isn't 16 or 32 bit?"); } +PrimType getLongPrimType(const InterpState &S) { cor3ntin wrote: I don't suppose we can merge with getIntPrimType ? https://github.com/llvm/l

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
@@ -0,0 +1,149 @@ +; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s NMiehlbradt wrote: The other tests in the directory are named this way so I followed the convention. https://github.com/llvm/llvm-project/pull/73611 __

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -8857,7 +8894,9 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { if (NewVD->isConstexpr() && !T->isDependentType() && RequireLiteralType(NewVD->getLocation(), T, - diag::err_constexpr_var_non_literal)) { +

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -2485,12 +2485,12 @@ bool VarDecl::mightBeUsableInConstantExpressions(const ASTContext &C) const { // In C++, const, non-volatile variables of integral or enumeration types // can be used in constant expressions. - if (getType()->isIntegralOrEnumerationType()) + if (

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
https://github.com/NMiehlbradt updated https://github.com/llvm/llvm-project/pull/73611 >From 9fb1d97a4fd3e9a314780f5961d9c394cd6ae20c Mon Sep 17 00:00:00 2001 From: Nicholas Miehlbradt Date: Thu, 26 Oct 2023 00:45:22 + Subject: [PATCH 1/2] [KMSAN] Enable on PowerPC64 Enable -fsanitize=kern

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
@@ -0,0 +1,149 @@ +; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s + +target datalayout = "e-m:e-i64:64-n32:64" +target triple = "powerpc64le--linux" + +define void @Store1(ptr %p, i8 %x) sanitize_memory { +entry: + store i8 %x, ptr %p + ret void +} + +; CHECK

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @shafik I'll let you have the final say :) https://github.com/llvm/llvm-project/pull/68540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @tbaederr ping :) https://github.com/llvm/llvm-project/pull/70053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
NMiehlbradt wrote: @eugenis @ramosian-glider https://github.com/llvm/llvm-project/pull/73611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Don't say "is declared here" for invalid template locations (PR #71264)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: That's a lot of repeated code. Should we have a "NoteTemplateLocation" function(s) of some sort that would do the check and the diag as appropriate? https://github.com/llvm/llvm-project/pull/71264 ___ cfe-commits mailing list cfe-commi

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @knightXun code looks reasonable, ping me when you have tests and a release note :) https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: LGTM too. Please add a release note though https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes This would also fix the overlapping replacements below: $ clang-format a( #else #endif ) = []() { )} The new replacement overlaps with an existing replacement. New replacement: : 38:+7:" " Existin

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
https://github.com/fodinabor created https://github.com/llvm/llvm-project/pull/73756 As per https://github.com/AdaptiveCpp/AdaptiveCpp/issues/1256 - we are missing the `fma` long double variant for Cpp20 compact with MS-STL. See also #49853. -> I'm wondering if we should include this for all l

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (fodinabor) Changes As per https://github.com/AdaptiveCpp/AdaptiveCpp/issues/1256 - we are missing the `fma` long double variant for Cpp20 compact with MS-STL. See also #49853. -> I'm wondering if we should include this for all

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
https://github.com/fodinabor edited https://github.com/llvm/llvm-project/pull/73756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests (PR #73760)

2023-11-29 Thread via cfe-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/73760 This patch explicitly set C++23 in libcxx tests to avoid a test breakage caused by removal of codecvt. >From fc6f7dec3769ce748a097749dd5094081f113eb4 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 29 Nov

[clang] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests (PR #73760)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haowei (zeroomega) Changes This patch explicitly set C++23 in libcxx tests to avoid a test breakage caused by removal of codecvt. --- Full diff: https://github.com/llvm/llvm-project/pull/73760.diff 1 Files Affected: - (modified) clang/

[clang] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests (PR #73760)

2023-11-29 Thread via cfe-commits
zeroomega wrote: We still need PR #73679 landed to clear build failures though. https://github.com/llvm/llvm-project/pull/73760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests (PR #73760)

2023-11-29 Thread via cfe-commits
https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/73760 >From 24f78f125b4f7a9ea4f3488d0acc396b510c86c8 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 29 Nov 2023 00:00:53 -0800 Subject: [PATCH] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests This p

[clang] [Fuchsia] Explicitly set C++ standard C++23 in libcxx tests (PR #73760)

2023-11-29 Thread via cfe-commits
@@ -28,6 +28,7 @@ set(LLVM_STATIC_LINK_CXX_STDLIB ON CACHE BOOL "") set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") +set(LIBCXX_TEST_PARAMS "std=c++23" CACHE STRING "")

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-29 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/72951 >From e62698df942c547f287f0e0fd5863d746d597f53 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 21 Nov 2023 12:07:35 +0800 Subject: [PATCH] [analyzer]:fix valistChecker false negative in windows platform ---

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-29 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-29 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (PR #73765)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Brandon Wu (4vtomat) Changes Extend the multi-lib re-use selection mechanism for RISC-V. This funciton will try to re-use multi-lib if they are compatible. Definition of compatible: - ABI must be the same. - multi-lib is a subset

[clang] [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (PR #73765)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes Extend the multi-lib re-use selection mechanism for RISC-V. This funciton will try to re-use multi-lib if they are compatible. Definition of compatible: - ABI must be the same. - multi-lib is a subs

[clang] [clang] Use current rounding mode for float inc/dec (PR #73770)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Serge Pavlov (spavloff) Changes Increment and decrement are equivalent to adding or subtracting 1. For the floating-point values these operations depend on the current rounding mode. Teach constant evaluator to perform ++ and -- according

[clang] 6e01016 - [OpenMP] Support for `nothing` in `metadirective` (#73690)

2023-11-29 Thread via cfe-commits
Author: Sandeep Kosuri Date: 2023-11-29T15:13:43+05:30 New Revision: 6e0101684e59d5e8b11853a7311c71090547d355 URL: https://github.com/llvm/llvm-project/commit/6e0101684e59d5e8b11853a7311c71090547d355 DIFF: https://github.com/llvm/llvm-project/commit/6e0101684e59d5e8b11853a7311c71090547d355.diff

[clang] 10d6d5f - AArch64: add support for currently released Apple CPUs. (#73499)

2023-11-29 Thread via cfe-commits
Author: Tim Northover Date: 2023-11-29T09:51:42Z New Revision: 10d6d5f224c2e9b5fed025940bc1ac45a4f6f70f URL: https://github.com/llvm/llvm-project/commit/10d6d5f224c2e9b5fed025940bc1ac45a4f6f70f DIFF: https://github.com/llvm/llvm-project/commit/10d6d5f224c2e9b5fed025940bc1ac45a4f6f70f.diff LOG:

[clang] Draft:[analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-29 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Draft:[analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-29 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Replace usage of StringRef::find_last_of with a string literal of size one by the equivalent char literal (PR #73776)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Lucas Duarte Prates (pratlucas) Changes --- Patch is 27.46 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/73776.diff 19 Files Affected: - (modified) clang/test/Driver/aarch64-v95a.c (+5) -

[clang] [llvm] Replace usage of StringRef::find_last_of with a string literal of size one by the equivalent char literal (PR #73776)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Lucas Duarte Prates (pratlucas) Changes --- Patch is 27.46 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/73776.diff 19 Files Affected: - (modified) clang/test/Driver/aarch64-v95a.c (+5) - (m

[clang] [llvm] Replace usage of StringRef::find_last_of with a string literal of size one by the equivalent char literal (PR #73776)

2023-11-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 511218642bc5df7815423de211192dd577eb3a9c bff5119a857124f113d9dc499701ad87941fe1c3 --

[llvm] [clang] [AArch64] Assembly support for the Checked Pointer Arithmetic Extension (PR #73777)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-clang Author: Lucas Duarte Prates (pratlucas) Changes This introduces assembly support for the Checked Pointer Arithmetic Extension (FEAT_CPA), annouced as part of the Armv9.5-A architecture version. The changes include: * New s

[llvm] [clang] [AArch64] Assembly support for the Checked Pointer Arithmetic Extension (PR #73777)

2023-11-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0fac9da7342e7846fbc4464abe5c00086cbf026c bff5119a857124f113d9dc499701ad87941fe1c3 --

[clang] 47df664 - [clang][analyzer] Support `fgets` in the SteamChecker (#73638)

2023-11-29 Thread via cfe-commits
Author: Ben Shi Date: 2023-11-29T19:20:49+08:00 New Revision: 47df664c7acfd8abd082c0252d1793182c92dc3d URL: https://github.com/llvm/llvm-project/commit/47df664c7acfd8abd082c0252d1793182c92dc3d DIFF: https://github.com/llvm/llvm-project/commit/47df664c7acfd8abd082c0252d1793182c92dc3d.diff LOG:

[clang] 15798f4 - Move documentation about -verify from a header to public docs (#73694)

2023-11-29 Thread via cfe-commits
Author: Aaron Ballman Date: 2023-11-29T07:56:08-05:00 New Revision: 15798f4ec4dfa9607f4a7c94b922b80049e1575d URL: https://github.com/llvm/llvm-project/commit/15798f4ec4dfa9607f4a7c94b922b80049e1575d DIFF: https://github.com/llvm/llvm-project/commit/15798f4ec4dfa9607f4a7c94b922b80049e1575d.diff

[llvm] [clang] [RISCV][MC] Always emit relocations for resolved symbols and relax (PR #73793)

2023-11-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Andreu Carminati (andcarminati) Changes If relaxation is not itended, it can be disabled in the linker. Also, we cannot trust Subtarget features here, because it may be empty in case of LTO codegen, preventing relaxations. Also

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73463 >From 001cc1c3a03b80cd6725783edaad84c9013311b6 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Sun, 26 Nov 2023 22:47:51 +0100 Subject: [PATCH 1/3] [Clang] Eagerly instantiate used constexpr function upon d

[clang] 3c00c8c - [AArch64][SME2] Enable CLAMP multi-vector builtins for SME2 (#72272)

2023-11-29 Thread via cfe-commits
Author: Dinar Temirbulatov Date: 2023-11-29T14:32:40Z New Revision: 3c00c8c0fcd64600f7adc4538b2116a91ef60ced URL: https://github.com/llvm/llvm-project/commit/3c00c8c0fcd64600f7adc4538b2116a91ef60ced DIFF: https://github.com/llvm/llvm-project/commit/3c00c8c0fcd64600f7adc4538b2116a91ef60ced.diff

[clang] [clang-format] Add space in Verilog tagged unions (PR #71354)

2023-11-29 Thread via cfe-commits
@@ -4694,8 +4694,15 @@ bool TokenAnnotator::spaceRequiredBefore(const AnnotatedLine &Line, Left.isOneOf(TT_VerilogDimensionedTypeName, Keywords.kw_function)) { return true; } +// In a tagged union expression, there should be a space after the tag. +if

[clang] [clang-format] Add space in Verilog tagged unions (PR #71354)

2023-11-29 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/71354 >From 07ff52a1b082a5094de124bd108866ed5f016d12 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Mon, 6 Nov 2023 03:26:02 + Subject: [PATCH 1/2] [clang-format] Add space in Verilog tagged unions In a tagged union e

[clang] [clang-format] Add spaces around the Verilog implication operator (PR #71352)

2023-11-29 Thread via cfe-commits
@@ -1980,17 +1980,18 @@ TEST_F(TokenAnnotatorTest, UnderstandsVerilogOperators) { // joined operators, we don't have a separate type, so we only test for their // precedence. std::pair JoinedBinary[] = { - {prec::Comma, "<->"}, {prec::Assignment, "+="}, -

[clang] [clang-format] Add spaces around the Verilog implication operator (PR #71352)

2023-11-29 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/71352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3af82b3 - [clang-format] Add spaces around the Verilog implication operator (#71352)

2023-11-29 Thread via cfe-commits
Author: sstwcw Date: 2023-11-29T15:17:59Z New Revision: 3af82b3962c443d43edba1abb50a82fb3048999a URL: https://github.com/llvm/llvm-project/commit/3af82b3962c443d43edba1abb50a82fb3048999a DIFF: https://github.com/llvm/llvm-project/commit/3af82b3962c443d43edba1abb50a82fb3048999a.diff LOG: [clang

[clang] 9fa2d74 - [clang-format] Indent Verilog case statements with comments (#71353)

2023-11-29 Thread via cfe-commits
Author: sstwcw Date: 2023-11-29T15:19:13Z New Revision: 9fa2d74be415a3e30d811c0acc05c45e1c55759e URL: https://github.com/llvm/llvm-project/commit/9fa2d74be415a3e30d811c0acc05c45e1c55759e DIFF: https://github.com/llvm/llvm-project/commit/9fa2d74be415a3e30d811c0acc05c45e1c55759e.diff LOG: [clang

[clang] [clang-format] Indent Verilog case statements with comments (PR #71353)

2023-11-29 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/71353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [STLExtras] Add out-of-line definition of friend operator== for C++20 (PR #72348)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/72348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 953d675 - Fix accsessing "PresentModifierLocs" array beyond its end. (#73579)

2023-11-29 Thread via cfe-commits
Author: jyu2-git Date: 2023-11-29T08:01:57-08:00 New Revision: 953d675c42c254676ca446951bd728abefecf436 URL: https://github.com/llvm/llvm-project/commit/953d675c42c254676ca446951bd728abefecf436 DIFF: https://github.com/llvm/llvm-project/commit/953d675c42c254676ca446951bd728abefecf436.diff LOG:

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73105 >From a835d36f3051daf4d7e20493860a7a104c9640b5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 22 Nov 2023 12:25:20 +0100 Subject: [PATCH] [Clang] Implement P28646R2 Remove Deprecated Arithmetic Conver

[clang] Fix accsessing "PresentModifierLocs" array beyond its end. (PR #73579)

2023-11-29 Thread via cfe-commits
https://github.com/jyu2-git closed https://github.com/llvm/llvm-project/pull/73579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2308R1 - Template Parameter Initialization. (PR #73103)

2023-11-29 Thread via cfe-commits
@@ -62,7 +62,7 @@ namespace ClassNTTP { template constexpr int f() { return a.y; } static_assert(f() == 2); - template int id; + template int id; // expected-note {{passing argument to parameter 'a' here}} cor3ntin wrote: L70. you want me to use a labe

[clang] [Clang] Implement P2308R1 - Template Parameter Initialization. (PR #73103)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73103 >From 4709819fb2e7f45f9429f1a7fc79923abf0f9691 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 22 Nov 2023 11:43:07 +0100 Subject: [PATCH 1/2] [Clang] Implement P2308R1 - Template Parameter Initializat

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73105 >From e18309057cb6977b665ba2d7fcbd313a578eaad5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 22 Nov 2023 12:25:20 +0100 Subject: [PATCH] [Clang] Implement P28646R2 Remove Deprecated Arithmetic Conver

<    34   35   36   37   38   39   40   41   42   43   >