RE: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

2022-10-18 Thread stan li via cfe-commits
Thanks for the suggestion. Updated llvm_unreachable. The static_cast not only check the switch cases all covered, also make sure 2 enums not out of sync. Sent from Mail for Windows From: David Blaikie Sent: Monday, Oc

RE: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

2021-10-21 Thread stan li via cfe-commits
Hi Alex, I’ll take a look. Not sure how long it takes though. Please revert it. I don’t have the permission to commit yet. Could you share more information about the crash? What is the command line to repro the crash and which environment it crashed. Thanks Xiang Sent from Mail

RE: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

2021-10-21 Thread stan li via cfe-commits
Hi Alex, I tried compile your repro on Windows with clang -S But it didn’t crash. Could you share the command line and environment to repro the crash? Thanks Xiang Sent from Mail for Windows From: Alexander Kornien