[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issu

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25370 + "#if 0\n" + " if (a) {\n" + "#else\n" Can you confirm that there is supposed to be only one space here while there are two in the ne

[PATCH] D133954: [clang-format] Fix template arguments in macros

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issu

[PATCH] D128607: [clang-format] NFC Fix uninitialized memory problem

This revision was automatically updated to reflect the committed changes. Closed by commit rG141ad3ba0571: [clang-format] Fix uninitialized memory problem (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128607/new/ https://review

[PATCH] D128709: [clang-format] Handle Verilog attributes

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D128711: [clang-format] Handle Verilog blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now stuff inside begin-end blocks get indented.

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now things inside hierarchies like modules and

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D128714: [clang-format] Handle Verilog case statements

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These statements are like switch statements in

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw updated this revision to Diff 418061. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h Index: clang/lib/For

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 418071. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnot

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:749 + if (Current.isNot(tok::comment) && + Previous.isConditionLParen(/*IncludeSpecial=*/true)) { // Treat the condition inside an if as if it w

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 418073. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/Fo

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 2 inline comments as done. sstwcw added a comment. This is how checking for `while` changes behavior. diff --git a/flang/lib/Evaluate/tools.cpp b/flang/lib/Evaluate/tools.cpp index 68b2a40d48c5..3f811fee9bad 100644 --- a/flang/lib/Evaluate/tools.cpp +++ b/flang/lib/Evaluate/

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked 9 inline comments as done. sstwcw added a comment. I tried formatting the files in `clang-formatted-files.txt`. Besides the files in the list that get changed when formatted with the program built from `main`, none gets changed when I format them with the program built from this pa

[PATCH] D121756: [clang-format] Clean up code looking for if statements NFC

sstwcw updated this revision to Diff 419006. sstwcw retitled this revision from "[clang-format] Clean up code looking for if statements" to "[clang-format] Clean up code looking for if statements NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

sstwcw updated this revision to Diff 419007. sstwcw retitled this revision from "[clang-format] Refactor determineStarAmpUsage" to "[clang-format] Refactor determineStarAmpUsage NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https:/

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 419009. sstwcw retitled this revision from "[clang-format] Take out common code for parsing blocks" to "[clang-format] Take out common code for parsing blocks NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. I ran check-clang after formatting the entire code base with the new version. It turned out it did break some tests. It seems to be because it messed up these comments. diff --git a/clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.fallthrough/p1.cpp b/clang/test/CXX/dcl.dcl

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6740fe483e9: [clang-format] Indent import statements in JavaScript. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

sstwcw added a comment. Maybe it's because I removed the final empty line when I pasted the diff as I thought that LF was a line terminator instead of a line separator. I will try using arc from now on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 420031. sstwcw retitled this revision from "[clang-format] Clean up code looking for if statements NFC" to "[clang-format] Clean up code looking for if statements". sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:252-256 +} else if (OpeningParen.isConditionLParen(/*IncludeFor=*/false) || + (OpeningParen.Previous && +OpeningParen.Previous-

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420652. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLinePar

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420653. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h Index: clang/lib/For

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93182a88788: [clang-format] Handle Verilog numbers and operators (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D126845?

[PATCH] D128711: [clang-format] Handle Verilog blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67480b360ca0: [clang-format] Handle Verilog blocks (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D128712: [clang-format] Handle Verilog modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG6db0c18b1af6: [clang-format] Handle Verilog modules (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

This revision was automatically updated to reflect the committed changes. Closed by commit rGb67ee18e85f3: [clang-format] Handle Verilog user-defined primitives (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D128713?vs=443607&id=448489#toc Repository: rG LLVM Github

[PATCH] D128714: [clang-format] Handle Verilog case statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGc88719483c69: [clang-format] Handle Verilog case statements (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128714/new/ https://reviews.

[PATCH] D128709: [clang-format] Handle Verilog attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG60e12068ffeb: [clang-format] Handle Verilog attributes (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D128709?vs=443611&id=448491#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sstwcw added a comment. It looks like some of the braces in the code should be removed for example those surrounding one-line for bodies. Sorry if it is not my job to point this out, but MyDeveloperDay has not said anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. Any more problems with this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 414347. sstwcw added a comment. Modify initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. @MyDeveloperDay Will you please accept this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list cfe-c

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. How to get this revision committed? I thought it would happen automatically now that it is accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 _

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93b5505b456f: [clang-format] Extract doc for entire configuration structs (authored by sstwcw). Herald added a project: All. Repository: rG LLVM G

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24b3db45c7d: [clang-format] Add option to align compound assignments like `+=` (authored by sstwcw). Changed prior to commit: https://reviews.llv

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

sstwcw added a comment. Yes. I probably forgot to generate the doc. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749 ___ cfe-commits mailing list cf

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We had to add a bunch of keywords for a new langu

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was some duplicate code in determineStarAmp

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw created this revision. sstwcw added a reviewer: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After all these years, having the two functions now serves to confuse people. Reposit

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously several places had code to determine w

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a subscriber: svenvh. sstwcw added a comment. Do we have people who use Verilog and knows the clang-format code base? @svenvh Your email address looks like you work for a hardware company. If you know Verilog would you please have a look at this patch? Repository: rG LLVM Gith

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:534 continue; - parseBlock(/*MustBeDeclaration=*/false, /*AddLevels=*/1u, - /*MunchSemi=*/true, /*UnindentWhitesmithBraces=*/false, - CanContainBracedL

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a comment. Somehow the bot can't create a branch when trying to merge this patch. The error is failure to lock. The error persists after restarting the process. Does anyone know why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 416010. sstwcw edited the summary of this revision. sstwcw added a comment. Add some test cases and use a separate function for the common parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https:/

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 3 inline comments as done. sstwcw added a comment. About the tokens that were only in one function. question, colon, and TT_ConditionalExpr, are for same thing. question was added before they added TT_ConditionalExpr. It looks like now only TT_ConditionalExpr would be enough. k

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2851 -addUnwrappedLine(); -++Line->Level; -parseStructuralElement(); HazardyKnusperkeks wrote: > This is completely missing. Di

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw updated this revision to Diff 416025. sstwcw added a comment. Use the name spaceRequiredBetween. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https://reviews.llvm.org/D121755 Files: clang/lib/Format/TokenAnnotator.cpp clang

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw updated this revision to Diff 416051. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121753/new/ https://reviews.llvm.org/D121753 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/Unwrappe

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:947 + /* C# */ \ + KEYWORD(dollar, 0)

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw updated this revision to Diff 416052. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 4 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:133 Left->ParentBracket != tok::less && -(isKeywordWithCondition(*Line.First) || - CurrentToken->getStartOfNonWhitespace() =

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The options listed in ClangFormat.rst lag behind

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw updated this revision to Diff 416097. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D121890 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rst ==

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw added a comment. If anyone's wondering why all the lines changed. The `--qualifier-alignment` is too long so all the descriptions are moved to the right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D1

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw added inline comments. Comment at: clang/docs/ClangFormat.rst:76 +--output-replacements-xml - Output replacements as XML. +--qualifier-alignment= - If set, overrides the qualifier alignment style determined by the QualifierAlignment style flag +--sort-inc

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang-format] Indent import statements in JavaSc

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have all those fields in AnnotatingP

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked an inline comment as done. sstwcw added a comment. This patch is only intended to reduce the number of times the functionality gets implemented separately. Any change in behavior would be unintended. And we also use the `parseIndentedBlock` in Verilog stuff, so it's not just two

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw marked an inline comment as done. sstwcw added a comment. The issue is #54418. Actually I don't know who I should add as reviewers. The patches for clang-format don't always seem to have the same reviewers. Who are the main developers and how do you decide who you add each time? I give

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a comment. Yes. I am surprised that you asked since everyone asked me to break it apart. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121758/new/ https://reviews.llvm.org/D121758 ___ cfe-c

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

sstwcw added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw added a comment. For the new stuff I have the option of still adding the function `parseIndentedBlock` but only using it in new code. Please be more blunt about whether I should close this revision and do it that way. I guess I might have misunderstood you before from how you reacted w

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 416450. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://reviews.llvm.org/D121754 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/Tok

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfee94803f59d: [clang-format] Copy help options to the doc directory. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https:/

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147 +// know how they can be followed by a star or amp. +// co_await, delete - It doesn't make sense to have them followed by a unary +//

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 416456. sstwcw added a comment. use `isJavascript` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Forma

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw updated this revision to Diff 416458. sstwcw added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 Files: clang/lib/Format/TokenAnnotator.cpp Index: clang/lib/Format/T

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw added a comment. By the way, last time I used a breakpoint on `spaceRequiredBefore` and stepped until return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https://reviews.llvm.org/D121755 __

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:631 + Style.IndentPPDirectives == FormatStyle::PPDIS_AfterHash && Previous.is(tok::hash) && State.FirstIndent > 0 && (State.Line->Type =

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sstwcw marked an inline comment as done. Closed by commit rG8c31b68f4876: [clang-format] Use an enum for context types. NFC (authored by sstwcw). Repository: rG LLVM

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 417115. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://reviews.llvm.org/D121754 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Fo

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:85 + auto Tokens = annotate("x - 0"); + EXPECT_EQ(Tokens.size(), 4u) << Tokens; + EXPECT_TOKEN(Tokens[1], tok::minus, TT_BinaryOperator); --

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_help.py:29 +def get_help_output(): +args = ["clang-format", "--help"] +cmd = subprocess.Popen(args, stdout=subprocess.PIPE, You intentionally did not write `build/bin/clang-format` to

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 417125. sstwcw marked an inline comment as done. sstwcw added a comment. remove unnecessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files: clang/lib/Fo

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:633 (State.Line->Type == LT_PreprocessorDirective || State.Line->Type == LT_ImportStatement)) { Spaces += State.FirstIndent; --

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 417128. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/F

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw added a comment. Allow me another attempt in justifying this patch. Using the macros, it is easier to see when a keyword is not classified as some language's keyword. The author and reviewers didn't notice `final` and `dollar` being in only one place previously. With the old way, when

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 2 inline comments as done. sstwcw added a comment. It turned out this patch does change behavior. - while ( - FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) { + while (FormatTok->isOneOf(tok::identifier, tok::kw_requires, +

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw created this revision. sstwcw added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius, owenpan. Herald added a subscriber: mgorny. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch m

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

sstwcw added a comment. It looks like you forgot to chmod +x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121916/new/ https://reviews.llvm.org/D121916 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:1157 +VerilogExtraKeywords = std::unordered_set( +{kw_always, kw_always_comb, kw_always_ff,kw_always_latch, + kw_assert, kw_assign, kw_assume, kw_automatic, -

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + HazardyKnusperkeks wrote: > Can't we do

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 422049. sstwcw marked 2 inline comments as done. sstwcw added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rs

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. Would you have a look at the parent revision namely D121756 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 ___

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 422496. sstwcw edited the summary of this revision. sstwcw added a comment. abandon alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangForm

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + HazardyKnusperkeks wrote: > sstwcw wrote

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw created this revision. sstwcw added reviewers: curdeius, HazardyKnusperkeks. sstwcw added projects: clang-format, clang-tools-extra. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. About the column limit option in the test Ali

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119625 Files

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

sstwcw added a comment. This isolates the problem that changes the unit test mentioned in https://reviews.llvm.org/D119599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119625/new/ https://reviews.llvm.org/D119625 ___

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw marked 6 inline comments as done. sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:151 + /// When aligning assignments, whether compound assignments like + /// ``+=``'s are aligned along with ``=``'s. curdeius wrote: > You

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 408172. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Fo

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 408177. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:273 AlignTokenSequence(const FormatStyle &Style, unsigned Start, unsigned End, - unsigned Column, F &&Matches, + unsigned Column, unsigned AnchorWidth, F &&Matche

[PATCH] D119649: [clang-format] Correctly format loops and `if` statements even if preceded with comments.

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:379 if (NextLine.First->is(tok::l_brace)) { if ((TheLine->First->isOneOf(tok::kw_if, tok::kw_else, tok::kw_while, tok::kw_for, tok::kw_switch, tok

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// HazardyKnusperkeks wrote: > sstwcw wrote: > > HazardyKnusperkeks wrote: > > > curdeius wrote: > > > > I guess it would be complicated to

  1   2   3   >