[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

serge-sans-paille added a comment. LGTM, as long as it builds fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74385/new/ https://reviews.llvm.org/D74385 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

serge-sans-paille updated this revision to Diff 244150. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Totally different, and much cleaner approach of the issue. Repository: rG LLV

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

serge-sans-paille added a comment. In D74385#1869876 , @nicolas17 wrote: > I don't have commit access, can someone push this for me? Sure, can you just confirm that you're this guy: https://github.com/nicolas17 (I need that for proper email attribution)

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rG53fba65d2204: [ARCMT][NFC] Reduce #include dependencies (authored by nicolas17, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21664cce1db: Fix integration of pass plugins with llvm dylib (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ http

[PATCH] D74602: Fix standalone build interaction with compiler extension

serge-sans-paille created this revision. serge-sans-paille added reviewers: Keruspe, hans, Meinersbur. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. As suggested in https://github.com/llvm/llvm-project/issues/120, don't try to generate the extens

[PATCH] D74602: Fix standalone build interaction with compiler extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG87dac7da68ea: Fix standalone build interaction with compiler extension (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74602/n

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille created this revision. serge-sans-paille added a reviewer: asb. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 244943. serge-sans-paille added a comment. Add test case. This test fails with current master, see https://bugzilla.redhat.com/show_bug.cgi?id=1803698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D747

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 ___ cfe-commits m

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille created this revision. serge-sans-paille added reviewers: Meinersbur, Keruspe. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Use a d

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. Tested without standalone build with polly linked statically and dynamically with success. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 _

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. I'll revert and propose an updated patch then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704 ___ cfe-commits mailing list c

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D7

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. In D71082#1824563 , @rnk wrote: > The simplest one I can think of is to make `__warn_memset_zero_len` a > recognized builtin that generates no code. +1, simple and easy. > I believe we also branched 10.0 between this

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 __

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. >> The simplest one I can think of is to make `__warn_memset_zero_len` a >> recognized builtin that generates no code. > > +1, simple and easy. See https://reviews.llvm.org/D72869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, george.burgess.iv, akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works f

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille updated this revision to Diff 238614. serge-sans-paille added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. In D72869#1824951 , @efriedma wrote: > This is very hacky, Yeah, I know... > but it might be the least-bad alternative. I mean, we could change D71082 > so it doesn't allow system he

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGd293417931d3: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2910 + + if (Arg *A = Args.getLastArg(options::OPT_fnostack_clash_protection, + options::OPT_fstack_clash_

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 238758. serge-sans-paille marked 5 inline comments as done. serge-sans-paille added a comment. Take into account some of the reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://re

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 238868. serge-sans-paille added a comment. Update size computation + test case involving null byte inside the format string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.l

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 239166. serge-sans-paille added a comment. - Harmonize esp/rsp usage as hinted by @craig.topper - Fix argument detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.o

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239197. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Finer grain lower bound computations, and simpler control-flow for the checking function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239242. serge-sans-paille added a comment. More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 239257. serge-sans-paille added a comment. Update warning category Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/ClangCommandLineReferen

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239286. serge-sans-paille added a comment. Take into account review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOpt

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > Linkages which were not interposable before and can be interposable now: > available_externally, linkonce_odr, weak_odr, external, and appending. @MaskRay I understand the motivation behind that sentence, but do we want that change to be non-conditional, i.e

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239598. serge-sans-paille added a comment. - extra test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOptions.d

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > I tried modifying `GlobalValue::maybeSetDsoLocal`: `setDSOLocal(true)` for > ExternalLinkage. Unfortunately that will break 1337 tests. If not so many > tests need fixing, I wish we can place `getParent() && > getParent()->getSemanticInterposition()` logic i

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. In D71566#1832394 , @aaron.ballman wrote: > (There are still some minor whitespace nits to resolve as well.) Strange, everything is passed through clang-format-diff :-/ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239654. serge-sans-paille added a comment. Remove useless assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239809. serge-sans-paille added a comment. Take review into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOpt

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239837. serge-sans-paille added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOptions.def cl

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239857. serge-sans-paille added a comment. Add Release note and doc. @MaskRay can you confirm current state is ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239913. serge-sans-paille added a comment. Remove extra new lines. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239920. serge-sans-paille added a comment. clang-format update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include/clang/Basic/DiagnosticS

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > I feel that we are still behind a complete `-fsemantic-interposition`... I > don't know whether we should mention that the option is experimental. So do I. I can mention that in the -help output and in the changelog. Repository: rG LLVM Github Monorepo

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239996. serge-sans-paille added a comment. Take into account pie/pic interaction with semantic-interposition More test case Remove premature release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240110. serge-sans-paille added a comment. Formatting nits + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineRefere

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/LangOptions.def clang/in

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. In D71566#1839462 , @aaron.ballman wrote: > Continues to LG, do you need me to commit on your behalf? I was waiting for a last LG as I did some changes, thanks for all the quick iteration, I **really** enjoyed working

[PATCH] D71566: New checks for fortified sprintf

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d485ff455ea: Improve static checks for sprintf and __builtin___sprintf_chk (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240486. serge-sans-paille added a comment. Improve & comment examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineRefe

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) +Opts.SemanticInterposition = 1; + MaskRay wrote: > ` Opts

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +// Re

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240813. serge-sans-paille added a comment. @MaskRay should we add a verifier step to check that pie/pic/semanticinterposition module flags are consistent, or leave that to clang ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 240844. serge-sans-paille added a comment. Make some tests more portable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/ClangCommandLine

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240966. serge-sans-paille marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. > I suppose you mean whether "SemanticInterposition" should be invalidated when > "PIC Level" does not exist or "PIE Level" exists. I am a bit inclined to make > it more flexible/orthogonal in the backend, i.e

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241055. serge-sans-paille added a comment. @arichardson doc updated, any other advice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/Cla

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241152. serge-sans-paille added a comment. Update user-level documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLi

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D728

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241254. serge-sans-paille added a comment. take @sfertile review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangComman

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241351. serge-sans-paille added a comment. Fix documentation ordering, thank goes to @arichardson for spotting that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D

[PATCH] D72829: Implement -fsemantic-interposition

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd09f12f32f5: Implement -fsemantic-interposition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.l

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c943e368818: [libclang] Remove redundant return statements in CXType.cpp (authored by emilio, committed by serge-sans-paille). Repository: rG LLV

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

serge-sans-paille added inline comments. Comment at: clang/tools/libclang/CXCursor.cpp:1281 +if (const UsingShadowDecl *Shadow = Using->getFoundDecl()) + if (const auto *TD = dyn_cast_or_null(Shadow->getTargetDecl())) +return MakeCursorTypeRef(TD, Loc, TU); -

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151753/new/ https://reviews.llvm.org/D151753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D153746: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

serge-sans-paille created this revision. serge-sans-paille added a reviewer: weiwang. Herald added a subscriber: hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Whe

[PATCH] D153746: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

This revision was automatically updated to reflect the committed changes. Closed by commit rGf686e4bbc20a: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc6f5c9b588a: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D151753?vs=528999&id=534869#t

[PATCH] D147307: [clang] Consider artificial always inline builtin as inline builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, tstellar, efriedma. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #61691 Repository: rG LLVM

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

serge-sans-paille updated this revision to Diff 510752. serge-sans-paille retitled this revision from "[clang] Consider artificial always inline builtin as inline builtins" to "[clang] Do not require GNUInlineAttr for inline builtins". serge-sans-paille added a comment. DO not require gnu inline

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8745c252bc: [clang] Do not require GNUInlineAttr for inline builtins (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/

[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Memoizing the calls to getPrimaryContext()... LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151051/new/ https://revi

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille updated this revision to Diff 526059. serge-sans-paille retitled this revision from "[clang] Fix comdat for InlineBuiltin declarations" to "[clang] Restrict Inline Builtin to non-static, non-odr linkage". serge-sans-paille edited the summary of this revision. serge-sans-paille a

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. @jyu2 : could you test that patch in your setup ? Also I can't find the bug id associated with your original bug anymore... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGe20931b2ccd1: [clang] Restrict Inline Builtin to non-static, non-odr linkage (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. In D148723#4380165 , @mstorsjo wrote: > This causes failed asserts with `_FORTIFY_SOURCE` with the mingw-w64 headers. > Here's a reduced reproducer: > > $ cat reduced.c > typedef unsigned int size_t; > > void *

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille created this revision. serge-sans-paille added reviewers: dim, Fznamznon. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63007 Repository: rG LLVM Github Monorepo h

[PATCH] D151783: [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

serge-sans-paille created this revision. serge-sans-paille added a reviewer: mstorsjo. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up to https://reviews.llvm.org/D148723 an

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. Companion patch that fixes the issue reported by @mstorsjo : https://reviews.llvm.org/D151783 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 _

[PATCH] D151783: [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG1676b1ff63af: [clang] Use the appropriate definition when checking FunctionDecl… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. > So if isInlineBuiltinDeclaration() simply returns false for C++ code, > everything should just work, without messing with the linkage. Unfortunately not. See the example from `clang/test/CodeGen/inline-builtin-comdat.c` above. There's no C++ involved, the a

[PATCH] D148723: [clang] Fix comdat for InlineBuiltin declarations

serge-sans-paille updated this revision to Diff 523747. serge-sans-paille retitled this revision from "[clang] Enforce external linkage for inline builtin original declaration" to "[clang] Fix comdat for InlineBuiltin declarations". serge-sans-paille edited the summary of this revision. CHANGES

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

serge-sans-paille added a comment. In D147307#4279337 , @jyu2 wrote: > This change seems cause assert: > > https://godbolt.org/z/z9G87Wr37 I can reproduce, investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille created this revision. serge-sans-paille added reviewers: jyu2, efriedma. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise we end up with link once odr because of the

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added a comment. In D148723#4280916 , @efriedma wrote: > This seems like a weird way to fix this. I agree, not a big fan either. But wanting to start the bike shedding in some way. > The point of an "inline builtin" is that the inline

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD) { - if (!FD->isExternallyVisible()) + if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration()) return GV

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5192 - if (const auto *FD = D->getAsFunction()) + if (const auto *FD = D->getAsFunction()) { if (FD->isMultiVersion() && Linkage == GVA_AvailableExternally) erichkea

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille updated this revision to Diff 516645. serge-sans-paille retitled this revision from "[clang] Enforce internal linkage for inline builtin" to "[clang] Enforce external linkage for inline builtin original declaration". serge-sans-paille edited the summary of this revision. serge-s

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. In D148723#4296112 , @efriedma wrote: > Really, I'd prefer to keep isInlineBuiltinDeclaration() targeted as narrowly > as possible; part of that is making it not trigger for C++ inline functions > (which it never did i

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. In D148723#4296111 , @efriedma wrote: > I'm a little concerned that this will explode in unexpected ways... in > particular, it'll fail to link if the function doesn't actually exist > externally. Which it probably do

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille updated this revision to Diff 528999. serge-sans-paille added a comment. Take review into account CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151753/new/ https://reviews.llvm.org/D151753 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/warn-cast-align.c

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille added a comment. In D151753#4383602 , @Fznamznon wrote: > Have you checked that it fixes the non-reduced original example? Just did and it passes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151753/new/ https://reviews.llvm

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16163 +// Dependent alignment cannot be resolved -> bail out. +if (any_of(VD->specific_attrs(), + [](auto *A) { return A->isAlignmentDependent(); })) ---

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM with a minor nit. Thanks for the optimization! Comment at: clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.cpp:124 +if (ND0->getAcc

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Another argument for not having generated file in-tree. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D152771: [docs] Fix LibTooling documentation for OptionsParser change

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. I'm fine with the change. It would be great if this could `literalinclude` these two sample codes (as in https://www.sphinx-doc.org/en/master/usage/restructuredtext/dire

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille created this revision. serge-sans-paille added reviewers: thakis, aaron.ballman, nikic. Herald added a subscriber: hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald adde

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille updated this revision to Diff 480363. serge-sans-paille added a comment. fix test / compile errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 Files: clang/lib/Driver/ToolChains/Gnu.cpp llvm/include/llvm/Option/OptTab

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille updated this revision to Diff 480421. serge-sans-paille added a comment. Also simplify `StrCmpOptionNameIgnoreCase` implementation thanks to the move to StringRef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 Files: clan

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ae18303f97d: Store OptTable::Info::Name as a StringRef (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D139274

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille added a comment. In D139274#3974176 , @thakis wrote: > Reverted in de4b6a1bc64db33643f001ad45fae7b92b4a4688 > for > now. (Note that there was a follow-up fix in > e

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: steakhal, pmatos, asb, jhenderson, abrachet, ormris, martong, phosek, kadircet, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald

<    2   3   4   5   6   7   8   9   >