[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

2017-10-09 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. Please add depended parent. LGTM After the parent commit (LLVM side). https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

2017-10-09 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. after LLVM-SIDE https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-10 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. For my intrinsics ( _mm256_cvtsd_f64, _mm256_cvtsi256_si32 and _mm256_cvtss_f32) - ** LGTM**. Repository: rL LLVM https://reviews.llvm.org/D28503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

2017-04-03 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. Ping https://reviews.llvm.org/D31394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

2017-04-03 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman updated this revision to Diff 93915. https://reviews.llvm.org/D31394 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512dq-builtins.c test/CodeGen/avx512vlbw-builtins.c test/CodeGen/avx512vldq-builtins.c Index: test/CodeGen/avx512vldq-built

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

2017-04-03 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7176 + return CGF.Builder.CreateSExt( + Mask, llvm::VectorType::get(IT, NumberOfElements), "vpmovm2"); +} craig.topper wrote: > Why can't we just use DstTy here to create the SExt? You

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

2017-04-03 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman updated this revision to Diff 93941. https://reviews.llvm.org/D31394 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512dq-builtins.c test/CodeGen/avx512vlbw-builtins.c test/CodeGen/avx512vldq-builtins.c Index: test/CodeGen/avx512vldq-built

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

2017-04-03 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. Thanks :) https://reviews.llvm.org/D31394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27418: [X86][inline-asm] Add support for MS 'EVEN' directive

2016-12-05 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. lgtm Repository: rL LLVM https://reviews.llvm.org/D27418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits