[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers marked an inline comment as done. bersbersbers added a comment. > The disadvantage is that it forces everyone else who needs to review or > maintain the file to deal with a style that's different from that of the > directory. "different", yes, but as explained, not necessarily inco

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 505615. bersbersbers added a comment. Made comment extraction more strict, made sure special comments not affected by formatting, added unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 File

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 506336. bersbersbers added a comment. Rebased patch against main branch (previous patch was against 15.0.7 tag) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 Files: clang/docs/ClangFormatStyleOpti

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 506357. bersbersbers added a comment. Fix unit tests, add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. That remaining failing unit test (`Flang.Driver::code-gen-rv64.f90`) appears to be independent of my diff, as it appears in other pipelines as well, compare https://buildkite.com/llvm-project/premerge-checks/builds/141883#0186f8c7-4ac2-43c4-a83d-d101ed0ebf65/6-13797

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers created this revision. bersbersbers added a reviewer: owenpan. bersbersbers created this object with visibility "All Users". bersbersbers added a project: clang-format. Herald added a project: All. bersbersbers requested review of this revision. Herald added a project: clang. Herald ad

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. All, thanks for considering my patch! I'll answer all messages here, and will work on the patch over the weekend most probably. In D145435#4173875 , @owenpan wrote: > Please refer to D125171#4167866

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. In D145435#4179662 , @owenpan wrote: > Are the settings above hypothetical or are they real-world use cases? Real-world - actually, all of them. > IMO, if people really want to have per-file configurations, they can do so

[PATCH] D145435: [clang-format] Choose style (file) from within code for use in IDEs

bersbersbers added a comment. Alright, thanks for your opinions. I will probably maintain this feature in a private working copy and continue to advertise it (compare, e.g., https://github.com/llvm/llvm-project/issues/60917 and https://stackoverflow.com/q/20540017), hoping to convince more peop