[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411571. lichray added a comment. Re-run build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnos

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray created this revision. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given a dependent `T` (maybe an undeduced `auto`), Before: new T(z) --> new T((z)) # changes meaning with more args new T{z} --> new T{z}

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if (InitStyle) { -if (InitStyle == CXXNewExpr::CallInit) + auto InitStyle = E->getInitializationStyle(); + if (Init

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411839. lichray added a comment. Use the right copy of clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411842. lichray added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/lib/AST/StmtPrinter.cpp clang/test/CXX/expr/expr.prim/expr.prim.

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray updated this revision to Diff 411843. lichray marked 2 inline comments as done. lichray added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120608/new/ https://reviews.llvm.org/D120608 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411845. lichray added a comment. Restore the right diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cl

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 411856. lichray added a comment. - Revert some auto's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 3 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > We're also missing `\?` right? `?` does not seem to n

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 4 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > lichray wrote: > > aaron.ballman wrote: > > > We're a

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG136b29312920: [c++2b] Implement P0849R8 auto(x) (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a59eefd3a0: [Clang] Remove redundant init-parens in AST print (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 412289. lichray added a comment. Herald added a project: All. - Add a trigraph test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44eee659f1c5: [AST] Print NTTP args as string-literals when possible (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 399415. lichray added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 399433. lichray added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Pr

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added a comment. Ping. Ready to review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3190788 , @Quuxplusone wrote: > Am I seeing correctly that there's no feature-test macro for `auto(x)`? Oh, no, there isn't, and there wasn't a `__cpp_auto` either. I'll open a core issue. > I basically have to chec

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added a comment. @rsmith Ping. I'm all on you :) You are almost the only one designed these files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 ___

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 396187. lichray marked an inline comment as done. lichray added a comment. Herald added a subscriber: mgorny. - Fix categorizing int64_t chars of negative values - More ArrayRef - Fix and test the EntireContentsOfLargeArray bit Repository: rG LLVM Github M

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:288 + /// template parameters, no matter how many elements there are. + unsigned EntireContentsOfLargeArray : 1; + rsmith wrote: > It lo

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 396408. lichray added a comment. - Put tests in TypePrinterTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h

<    1   2   3