[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.

lichray added a comment. LGTM. @ldionne 's job to confirm. https://reviews.llvm.org/D50543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41347: [libc++] Lift std::errc into a separated header

lichray added a comment. In https://reviews.llvm.org/D41347#1099842, @mclow.lists wrote: > Sorry this took so long. Please update `test/libcxx/double_include.sh.cpp` > and commit. Are you sure? `double_include.sh.cpp` doesn't seem to be testing any intermediate headers. Repository: rCXX

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format mclow.lists wrote: > lichray wrote: > > EricWF wrote: > > > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we'r

[PATCH] D39162: [test] Fix clang-test for FreeBSD

lichray created this revision. Herald added subscribers: krytarowski, emaste. Lit tries to inject the shared library paths, but no action is taken when `platform.system()` is not recognized, results in an environment variable with an empty name, which is illegal. The patch fixes this mechanism

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray updated this revision to Diff 119772. lichray retitled this revision from "[test] Fix clang-test for FreeBSD" to "[test] Fix clang-test for FreeBSD and NetBSD". lichray edited the summary of this revision. https://reviews.llvm.org/D39162 Files: test/Unit/lit.cfg.py Index: test/Unit/l

[PATCH] D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?

lichray added a comment. Isn't it already an UB if someone set `WillHaveBody` and but later `IsCopyDeductionCandidate` being read, vice versa? Repository: rL LLVM https://reviews.llvm.org/D39166 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray marked an inline comment as done. lichray added a comment. In https://reviews.llvm.org/D39162#903179, @zturner wrote: > Please don't throw an exception here. Instead, write this as: > > lit_config.warning('Unable to determine shared library path variable for > platform {}'.format(plat

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray added a comment. In https://reviews.llvm.org/D39162#903186, @joerg wrote: > I think we should special case Darwin and Windows and fall-back to > LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform > left where it doesn't work. If those developers come to us,

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray updated this revision to Diff 119800. https://reviews.llvm.org/D39162 Files: test/Unit/lit.cfg.py Index: test/Unit/lit.cfg.py === --- test/Unit/lit.cfg.py +++ test/Unit/lit.cfg.py @@ -35,13 +35,15 @@ if symbolizer in

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray updated this revision to Diff 119803. lichray edited the summary of this revision. lichray added a comment. Changed to an warning given @zturner 's comments and experiments. https://reviews.llvm.org/D39162 Files: test/Unit/lit.cfg.py Index: test/Unit/lit.cfg.py =

[PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

lichray added a comment. ping? https://reviews.llvm.org/D39162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

lichray added inline comments. Comment at: lib/Analysis/AnalysisDeclContext.cpp:606 -AnalysisDeclContextManager::~AnalysisDeclContextManager() { - if (BdyFrm) -delete BdyFrm; -} +AnalysisDeclContextManager::~AnalysisDeclContextManager() {} Why having emp

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D39284: [c++2a] Decomposed _condition_

lichray created this revision. This feature was discussed but not yet proposed. It allows a structured binding to appear as a //condition// if (auto [ok, val] = f(...)) So the user can save an extra //condition// if the statement can query the value to-be-decomposed instead. Formally, it m

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

lichray created this revision. lichray added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added a subscriber: christof. Avoid buffer overflow by replacing the pointer interface with an array reference interface in C++2a. Tentatively ready on Batavia2018. https://wg21.

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added a comment. Ping. Any more comments? Repository: rCXX libc++ https://reviews.llvm.org/D41458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: include/charconv:158 + +#if !defined(_LIBCPP_COMPILER_MSVC) +static _LIBCPP_INLINE_VISIBILITY int __width(_Tp __v) mclow.lists wrote: > In general, we don't put `_LIBCPP_COMP

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 158404. lichray added a comment. Dropping a lambda Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp test/std/uti

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

This revision was automatically updated to reflect the committed changes. Closed by commit rL338479: [libc++][C++17] Elementary string conversions for integral types (authored by lichray, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D50130: [libc++] Fix build failures after merging

lichray created this revision. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne, christof. - fix a stupid unit test typo - add symbols to Linux abilist Repository: rCXX libc++ https://reviews.llvm.org/D50130 Files: lib/abi/x86_64-unknown-linux-gnu.v1.abilist

[PATCH] D50130: [libc++] Fix build failures after merging

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX338486: [libc++] Fix build failures after merging (authored by lichray, committed by ). Changed prior to com

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added a comment. I will pick up the changes later next week. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format EricWF wrote: > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we're no

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

lichray added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + K-ballo wrote: > Quuxplusone wrote: > > mclow.lists wrote: > > > lichray wrote: > > > > Oh, common, I persuaded the

[PATCH] D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

lichray added inline comments. Comment at: include/array:135 + _LIBCPP_INLINE_VISIBILITY + static void __swap(_StorageT& __lhs, _StorageT& __rhs) { +std::swap_ranges(__lhs, __lhs + _Size, __rhs); Just asking: no compiler is dumb enough to not inline this en

[PATCH] D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

lichray added a comment. BTW, this is https://cplusplus.github.io/LWG/issue2157 , so please update `www` accordingly, and also test `{{}}` cases. https://reviews.llvm.org/D41223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D41347: [libc++] Lift std::errc into a separated header

lichray created this revision. lichray added reviewers: mclow.lists, EricWF. This is needed to implement ``. Repository: rCXX libc++ https://reviews.llvm.org/D41347 Files: include/__errc include/system_error Index: include/system_error ===

[PATCH] D41458: WIP: [libc++][C++17] Elementary string conversions for integral types

lichray created this revision. lichray added reviewers: mclow.lists, EricWF. Herald added a subscriber: mgorny. Progress: std::to_chars for integers Missing: std::from_chars References: https://wg21.link/p0067r5 https://wg21.link/p0682r1 Repository: rCXX libc++ https://reviews.llvm.org/D41

[PATCH] D41458: WIP: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 127996. lichray added a comment. Added std::from_chars Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa/itoa.h lib/CMakeLists.txt src/support/itoa/ src/sup

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 128071. lichray added a comment. Use Marshall's method to generate digits in reversed order in generic to_chars. Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 128393. lichray added a comment. Just include math.h Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa/itoa.h lib/CMakeLists.txt src/support/itoa/ src/suppo

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked 7 inline comments as done. lichray added a comment. Herald added a subscriber: christof. Pending patch update due to poor network. Comment at: include/charconv:90 + +enum class _LIBCPP_ENUM_VIS chars_format +{ EricWF wrote: > enum types should ha

[PATCH] D44534: Fix codegen for structured binding binding in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rC327780: Fix codegen for structured binding binding in conditions (authored by lichray, committed by ). Repository: rC Clang https://reviews.llvm.org/D44534 Files: lib/CodeGen/CGStmt.cpp test/Parse

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

This revision was automatically updated to reflect the committed changes. Closed by commit rC327782: [C++17] Allow an empty expression in an if init statement (authored by lichray, committed by ). Repository: rC Clang https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

lichray added a comment. LGTM Comment at: test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp:17 }; extern A x; // expected-error {{requires an initializer}} Please add one more test to the end of the file saying ``` static A y; ``` as a remainder

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as not done. lichray added inline comments. Comment at: include/support/itoa/itoa.h:29 +UINT64_C(1000), +UINT64_C(1), +UINT64_C(10), EricWF wrote: > The `UINT64_C` and `UINT32_C` macros are non-standard, so I w

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 138841. lichray marked an inline comment as not done. lichray added a comment. Addressing 'Done' comments Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/__errc include/charconv include/support/itoa/ include/su

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 138842. lichray added a comment. Keep patches split Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa/itoa.h lib/CMakeLists.txt src/support/itoa/ src/suppor

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 149824. lichray added a comment. Preserve value category in narrowing test. Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp test/std/utilities/varia

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 149825. lichray added a comment. Refine coding style Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp test/std/utilities/variant/variant.variant/vari

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

lichray updated this revision to Diff 172497. lichray added a comment. Herald added a subscriber: libcxx-commits. Rebased Repository: rCXX libc++ https://reviews.llvm.org/D51268 Files: include/istream test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extracto

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 172514. lichray added a comment. Herald added subscribers: libcxx-commits, ldionne. Updated implementation for https://reviews.llvm.org/source/clang/ Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/va

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

lichray accepted this revision. lichray added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: libcxx-commits. Comment at: libcxx/include/istream:365 __input_arithmetic(basic_istream<_CharT, _Traits>& __is, _Tp& __n) { -#ifndef _LIBCPP

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

lichray added a comment. In https://reviews.llvm.org/D51268#1303217, @ldionne wrote: > Please also update https://libcxx.llvm.org/cxx2a_status.html. Done. Comment at: include/istream:601 +streamsize __n = __is.width(); +if (__n <= 0) +__n = numeric_limits::ma

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

lichray updated this revision to Diff 174722. lichray added a comment. Update cxx2a status. Repository: rCXX libc++ https://reviews.llvm.org/D51268 Files: include/istream test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/signed_char_pointer.pass.cp

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX347377: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*) (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D51268?vs=174722&id=174864#toc

[PATCH] D52391: Document new symbols for __u64toa and __u32toa

lichray created this revision. lichray added a reviewer: EricWF. Herald added subscribers: libcxx-commits, ldionne, christof. They are introduced in r338479; their Linux ABI changes are recorded in r338486. TODO: Record the Mac OS X ABI changes. Repository: rCXX libc++ https://reviews.llvm.o

[PATCH] D52391: Document new symbols for __u64toa and __u32toa

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX342810: Document new symbols for __u64toa and __u32toa (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D52391?vs=166605&id=166610#toc Repository: rCXX libc++

[PATCH] D52401: Remove redundant null pointer check in operator delete

lichray reopened this revision. lichray added a comment. This revision is now accepted and ready to land. LGTM as well, unless @mclow.lists can tell us some history like interactions with K&R libc :) Repository: rL LLVM https://reviews.llvm.org/D52401 _

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

lichray added a comment. In https://reviews.llvm.org/D44609#1059675, @Wawha wrote: > In my case, the main requirement is to be able **avoid** a lambda in one line. That doesn't work for me. I would like short lambdas still be formatted in one line, when `AllowShortFunctionsOnASingleLine` or a

[PATCH] D52401: Remove redundant null pointer check in operator delete

lichray added a comment. In https://reviews.llvm.org/D52401#1250551, @MaskRay wrote: > `__free_hook` (defaults to NULL) is a user-supplied hook > (https://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html). Very interesting, that means if we don't apply this patch, we essentiall

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray added a comment. Ping @mclow.lists @EricWF ; the patch still applies, is there any other thing I need to address? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203733. lichray added a comment. Trivial rebase Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray marked an inline comment as done. lichray added a comment. In D44865#1535823 , @zoecarver wrote: > - the spacing is different from the rest of libc++ (a lot of it was that way > before). That's not something I can "fix" in this patch :( > - sin

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203766. lichray added a comment. Update www Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.p

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203966. lichray added a comment. Add fail tests Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp:130 { using V = std::variant; static_assert(!std::is_assignable::value, "ambiguous"); mclow.lis

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

This revision was automatically updated to reflect the committed changes. lichray marked an inline comment as done. Closed by commit rL363692: [libc++] Implement P0608R3 - A sane variant converting constructor (authored by lichray, committed by ). Herald added a project: LLVM. Herald added a subsc

[PATCH] D64034: [c++] Implement categorizing pointer-to-bool as narrowing conversions

lichray created this revision. lichray added reviewers: rsmith, EricWF. lichray added a project: clang. Herald added a subscriber: cfe-commits. This change implements an upcoming Core issue to categorize boolean conversions from pointer and pointer-to-member as (always) narrowing conversion (you

[PATCH] D41347: [libc++] Lift std::errc into a separated header

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX336164: [libc++] Lift std::errc into a separated header (authored by lichray, committed by ). Herald added a subscriber: ldionne. Changed prior to commit: https://reviews.llvm.org/D41347?vs=141109&id=

[PATCH] D48864: [libc++] Install the missing header __errc

lichray created this revision. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Herald added a reviewer: EricWF. Omitted from https://reviews.llvm.org/D41347. Repository: rCXX libc++ https://reviews.llvm.org/D48864 Files: include/CMakeLists.txt Index: include/CMakeLists.

[PATCH] D48864: [libc++] Install the missing header __errc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX336165: [libc++] Install the missing header __errc (authored by lichray, committed by ). Changed prior to commit: htt

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 153868. lichray added a comment. Herald added a subscriber: ldionne. A macro-free implementation Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/module.modulemap src/charconv.cpp test/libcxx/do

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: src/charconv.cpp:34 + +#define APPEND1(i) \ +do \ lichray wrote: > mclow.lists wrote: > > I'd really lik

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 153888. lichray added a comment. Install the header file Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added inline comments. Comment at: test/support/charconv_test_helpers.h:24 + +template +constexpr auto mclow.lists wrote: > If this is supposed to be a C++17 or later header (and I'm pretty sure it > is), you should add a `static_assert(TEST_STD_VER > 1

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154804. lichray marked an inline comment as done. lichray added a comment. Respond to the 2nd round review Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charcon

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked 3 inline comments as done. lichray added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format mclow.lists wrote: > Quuxplusone wrote: > > lichray wrote: > > > mclow.lists wrote: >

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154816. lichray added a comment. Less trailing return types Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp tes

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: include/charconv:234 +to_chars(char* __first, char* __last, _Tp __value, int __base) +-> to_chars_result +{ mclow.lists wrote: > lichray wrote: > > mclow.lists wrote: > > > W

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154842. lichray added a comment. Dropping C++11 support. Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp test/s

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format lichray wrote: > mclow.lists wrote: > > Quuxplusone wrote: > > > lichray wrote: > > >

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added inline comments. Comment at: include/charconv:244 +static _LIBCPP_INLINE_VISIBILITY char const* +read(char const* __p, char const* __ep, type& __a, type& __b) +{ mclow.lists wrote: > Same comment as above about `read` and `inner_product`

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 155780. lichray added a comment. Uglify all the names Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp test/std/

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: include/charconv:244 +static _LIBCPP_INLINE_VISIBILITY char const* +read(char const* __p, char const* __ep, type& __a, type& __b) +{ Quuxplusone wrote: > mclow.lists

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray updated this revision to Diff 125288. lichray marked 3 inline comments as done. lichray added a comment. Rephrase warning message. Repository: rC Clang https://reviews.llvm.org/D39284 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DeclSpec.h lib/Parse/Pars

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:712-720 + Diag(Decomp.getLSquareLoc(), [&] { +if (getLangOpts().CPlusPlus1z) { + if (D.getContext() == Declarator::ConditionContext) +return diag::ext_decomp_decl_cond; + else +retu

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray updated this revision to Diff 125581. lichray added a comment. Rebased. Repository: rC Clang https://reviews.llvm.org/D39284 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DeclSpec.h lib/Parse/ParseExprCXX.cpp lib/Sema/SemaDeclCXX.cpp test/Misc/warning

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray marked an inline comment as done. lichray added inline comments. Comment at: test/Misc/warning-flags.c:19 The list of warnings below should NEVER grow. It should gradually shrink to 0. rsmith wrote: > lichray wrote: > > rsmith wrote: > > > Please re

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray updated this revision to Diff 125665. lichray marked an inline comment as done. lichray added a comment. Added -Wbinding-in-condition. Repository: rC Clang https://reviews.llvm.org/D39284 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DeclSpec.h lib/Parse/

[PATCH] D39412: [Driver] Give LIBRARY_PATH precedence over native toolchains

lichray updated this revision to Diff 125668. lichray added a comment. Rebased. Repository: rC Clang https://reviews.llvm.org/D39412 Files: lib/Driver/ToolChains/AMDGPU.cpp lib/Driver/ToolChains/AVR.cpp lib/Driver/ToolChains/Ananas.cpp lib/Driver/ToolChains/BareMetal.cpp lib/Driver

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray added a comment. Can someone commit this please? One more patch then I'll go get a commit bit. Repository: rC Clang https://reviews.llvm.org/D39284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rC320011: Allow conditions to be decomposed with structured bindings (authored by lichray). Changed prior to commit: https://reviews.llvm.org/D39284?vs=125665&id=125892#toc Repository: rC Clang https:

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

lichray added a comment. Ping. Just accept this as a DR, like what GCC does, I guess? https://reviews.llvm.org/D39451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

lichray updated this revision to Diff 126092. lichray added a comment. Keep a pedantic Extension warning. Repository: rC Clang https://reviews.llvm.org/D39451 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/CXX/expr/expr.unary/expr.new/p2-cxx0x.cpp tes

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

lichray added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D39451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

This revision was automatically updated to reflect the committed changes. Closed by commit rC320401: P0620 follow-up: deducing `auto` from braced-init-list in new expr (authored by lichray). Changed prior to commit: https://reviews.llvm.org/D39451?vs=126092&id=126400#toc Repository: rC Clang

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

lichray added a comment. LGTM as-is with the changes to the TODO file... https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. Reproduced with lit -sv --param=cxx_under_test="$HOME/bin/clang++" test/std/utilities/tuple/ lit: [...] note: Using available_features: ['libc++', 'verify-support', 'clang-6', 'modules-s

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

lichray added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + Oh, common, I persuaded the committee to allow you to print a `(null)` and you don't do it... https://reviews.l

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

lichray added a comment. [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9: error: static_assert failed due to requirement '!std::is_nothrow_invocable_r_v' "" static_assert(!std::is_nothrow_invocable_r_v, ""); ^ ~~

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

This revision was automatically updated to reflect the committed changes. Closed by commit rL320509: [libcxx] P0604, invoke_result and is_invocable (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D38831?vs=126545&id=126580#toc Repository: rL LLVM http

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

lichray added a comment. That commit message generated from `arc` wasn't all that friendly :/ Thanks for the patch, and @K-ballo you should ask Chris for a commit bit :) Repository: rL LLVM https://reviews.llvm.org/D38831 ___ cfe-commits mailing

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

lichray added a comment. I beg you to resubmit this patch relative to "libcxx"; I had to `arc export` this patch and `patch -p1 < your.diff` manually rather than just `arc patch D41148`. Comment at: libcxx/include/experimental/simd:1069 +std::is_same<_Abi, sim

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

lichray added a comment. I'm not confident enough about the effects of this patch with only one test; the last patch also passes the test. I hope I can understand the effects better. https://reviews.llvm.org/D40284 ___ cfe-commits mailing list cf

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL320604: [libcxx] Fix basic_stringbuf constructor (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D40707?vs=126739&id=126779#toc Repository: rL LLVM https://re

[PATCH] D133659: [Clang] P1169R4: static operator()

lichray added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-static-call-operator.cpp:5 +struct Functor { + static int operator()(int x, int y) { +return x + y; I want to see some tests that diagnose `extern operator()`. Comment

[PATCH] D133659: [Clang] P1169R4: static operator()

lichray added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131466/new/ https://reviews.llvm.org/D131466 _

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

lichray added a comment. In D119136#3462660 , @aaron.ballman wrote:> > Thanks for the apology, but I still think the reverts were premature, so > hopefully we don't do this again. The issue with reverting all of these is > that you put the burden back

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 407425. lichray added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnostic

  1   2   3   >