ZequanWu wrote:
> > > Thanks for reporting. Those tests are failed due to not updated properly.
> > > I relanded this change with updated tests:
> > > [ae6dc64](https://github.com/llvm/llvm-project/commit/ae6dc64ec670891cb15049277e43133d4df7fb4b).
> >
> >
> > Your updated change still seems t
Author: Zequan Wu
Date: 2024-08-01T19:57:28-07:00
New Revision: 6c375ae7a4d97a9947fdc16be4d86e9eba3dde4c
URL:
https://github.com/llvm/llvm-project/commit/6c375ae7a4d97a9947fdc16be4d86e9eba3dde4c
DIFF:
https://github.com/llvm/llvm-project/commit/6c375ae7a4d97a9947fdc16be4d86e9eba3dde4c.diff
LOG
ZequanWu wrote:
> > > > > Thanks for reporting. Those tests are failed due to not updated
> > > > > properly. I relanded this change with updated tests:
> > > > > [ae6dc64](https://github.com/llvm/llvm-project/commit/ae6dc64ec670891cb15049277e43133d4df7fb4b).
> > > >
> > > >
> > > > Your upda
Author: Zequan Wu
Date: 2022-03-04T16:01:17-08:00
New Revision: be5705767aad8d8eafd40225f7dba8e7e661c6b5
URL:
https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5
DIFF:
https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5.diff
LOG
Author: Zequan Wu
Date: 2021-03-18T13:20:47-07:00
New Revision: 1c740b29fae3962a9c8644496352b10798d925ef
URL:
https://github.com/llvm/llvm-project/commit/1c740b29fae3962a9c8644496352b10798d925ef
DIFF:
https://github.com/llvm/llvm-project/commit/1c740b29fae3962a9c8644496352b10798d925ef.diff
LOG
Author: Zequan Wu
Date: 2021-03-23T20:12:09-07:00
New Revision: aae84b8e3939e815bbc1e64b3b30c0f10b055be4
URL:
https://github.com/llvm/llvm-project/commit/aae84b8e3939e815bbc1e64b3b30c0f10b055be4
DIFF:
https://github.com/llvm/llvm-project/commit/aae84b8e3939e815bbc1e64b3b30c0f10b055be4.diff
LOG
Author: Zequan Wu
Date: 2021-01-12T12:10:46-08:00
New Revision: e53bbd99516fc7b612df1ae08d48288d0b8784ea
URL:
https://github.com/llvm/llvm-project/commit/e53bbd99516fc7b612df1ae08d48288d0b8784ea
DIFF:
https://github.com/llvm/llvm-project/commit/e53bbd99516fc7b612df1ae08d48288d0b8784ea.diff
LOG
Author: Zequan Wu
Date: 2021-01-14T10:37:35-08:00
New Revision: 4fffbc150cca1638051b8ad2a20f4b8240df0869
URL:
https://github.com/llvm/llvm-project/commit/4fffbc150cca1638051b8ad2a20f4b8240df0869
DIFF:
https://github.com/llvm/llvm-project/commit/4fffbc150cca1638051b8ad2a20f4b8240df0869.diff
LOG
Author: Zequan Wu
Date: 2021-10-08T10:25:54-07:00
New Revision: f93169226a298f8fb22d768671d5564030c0ffa9
URL:
https://github.com/llvm/llvm-project/commit/f93169226a298f8fb22d768671d5564030c0ffa9
DIFF:
https://github.com/llvm/llvm-project/commit/f93169226a298f8fb22d768671d5564030c0ffa9.diff
LOG
Author: Zequan Wu
Date: 2021-10-19T12:39:34-07:00
New Revision: 57553ce43281a7c379e375161320cc09d8236839
URL:
https://github.com/llvm/llvm-project/commit/57553ce43281a7c379e375161320cc09d8236839
DIFF:
https://github.com/llvm/llvm-project/commit/57553ce43281a7c379e375161320cc09d8236839.diff
LOG
ZequanWu wrote:
This causes clang to crash when building chromium:
```
Assertion failed: (Loc.isValid() && "point of instantiation must be valid!"),
function setPointOfInstantiation, file DeclTemplate.h, line 1938.
PLEASE submit a bug report to https://crbug.com in the Tools>LLVM component,
run
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/97002
Reverts llvm/llvm-project#93113
>From 62d7d5611e70682f8743e7322e34204480ffe189 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Fri, 28 Jun 2024 00:36:19 -0400
Subject: [PATCH] =?UTF-8?q?Revert=20"[Clang]=20Fix=2
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/97002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
Reverting for now as this also breaks LLVM CI builder.
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/97002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
I have a partially reduced repro:
```
$ clang++ "-cc1" "-triple" "arm64-apple-macosx10.15.0"
"-Wundef-prefix=TARGET_OS_" "-Werror=undef-prefix"
"-Wdeprecated-objc-isa-usage" "-Werror=deprecated-objc-isa-usage"
"-emit-llvm-bc" "-flto=thin" "-flto-unit" "-disable-free"
"-clear-a
ZequanWu wrote:
Hi. this change caused chromium windows pgo build to fail:
https://g-issues.chromium.org/issues/373478548 and we see the profile runtime
error message:
```
LLVM Profile Error: Invalid profile data to merge
LLVM Profile Error: Profile Merging of file
default_16487515506031793746
ZequanWu wrote:
Oh, I see, there are windows version of `flock` in `WindowsMMap.h`, and this
new macro `COMPILER_RT_HAS_FLOCK` is defined here: [for
linux](https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/CMakeLists.txt#L41-L50)
https://github.com/llvm/llvm-project/pull/1
ZequanWu wrote:
Given there's already an implementation of `flock` in
`compiler-rt/lib/profile/WindowsMMap.c`. Setting `COMPILER_RT_TARGET_HAS_FLOCK`
according to this
https://github.com/llvm/llvm-project/blob/7dc2542ac24fcae89dfd179fa58c4ec4fb959e2b/compiler-rt/lib/profile/CMakeLists.txt#L41-
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/115196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/115196
We observed 2X slowdown in lldb's expression evaluation with
https://github.com/llvm/llvm-project/pull/109147. It turns out that calling
`isRedundantInlineQualifierFor` is quite expensive. Using short-circuit
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/115196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
Verified that it no longer crashes.
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Zequan Wu
Date: 2024-11-27T11:18:05-08:00
New Revision: c60b055d463a3e9f18a494aec075f35d38d447a0
URL:
https://github.com/llvm/llvm-project/commit/c60b055d463a3e9f18a494aec075f35d38d447a0
DIFF:
https://github.com/llvm/llvm-project/commit/c60b055d463a3e9f18a494aec075f35d38d447a0.diff
LOG
ZequanWu wrote:
It's actually an existing crash not caused by this one.
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
Confirmed that this change causes crash with -Wunsafe-buffer-usage:
https://godbolt.org/z/vcv8d6sYr.
My previously manual-reduced repro in
https://github.com/llvm/llvm-project/pull/91991#issuecomment-2477311737 happens
to crash before this change.
https://github.com/llvm/llv
Author: Zequan Wu
Date: 2024-11-14T13:43:59-08:00
New Revision: b05d37d0d25e5f3ef181e11eb2a61dd816ae72e1
URL:
https://github.com/llvm/llvm-project/commit/b05d37d0d25e5f3ef181e11eb2a61dd816ae72e1
DIFF:
https://github.com/llvm/llvm-project/commit/b05d37d0d25e5f3ef181e11eb2a61dd816ae72e1.diff
LOG
ZequanWu wrote:
Hi, we have found this causing clang to crash with -Wunsafe-buffer-usage:
https://godbolt.org/z/nvWxW43fK
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
ZequanWu wrote:
Hi, we see this test failed on our clang bots, looks like we should relax the
check
log:
```
/b/s/w/ir/cache/builder/src/third_party/llvm/clang/test/Driver/sanitizer-ld.c:335:39:
error: CHECK-ASAN-ANDROID-SHARED-LIBASAN: expected string not found in input
// CHECK-ASAN-ANDROID
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/121361
This fixes test breakage on clang bots. See comment
https://github.com/llvm/llvm-project/pull/121081#issuecomment-2565933062
>From c2e29a1822a592cdd96b5f4e9efc3bbf2ef2bf95 Mon Sep 17 00:00:00 2001
From: Zequan
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/121361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZequanWu approved this pull request.
https://github.com/llvm/llvm-project/pull/123963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/123963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
That should be fixed by
https://github.com/llvm/llvm-project/commit/8d925a1c72600807199894b5852bd8a032eca795.
https://github.com/llvm/llvm-project/pull/123963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -2916,6 +2917,12 @@ instrumentation:
$ LLVM_PROFILE_FILE="code-%m.profraw" ./code
+ Although rare, binary signatures used by the ``%m`` specifier can have
+ collisions. In this case, the ``%b`` specifier, which expands to the binary
+ ID (build ID in ELF and COF
@@ -785,6 +786,34 @@ static void addPGOAndCoverageFlags(const ToolChain &TC,
Compilation &C,
D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val;
}
+ if (const auto *A = Args.getLastArg(options::OPT_fprofile_continuous)) {
+if (!
@@ -785,6 +786,34 @@ static void addPGOAndCoverageFlags(const ToolChain &TC,
Compilation &C,
D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val;
}
+ if (const auto *A = Args.getLastArg(options::OPT_fprofile_continuous)) {
+if (!
https://github.com/ZequanWu approved this pull request.
LGTM. Thanks for fixing it.
https://github.com/llvm/llvm-project/pull/139777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 238 of 238 matches
Mail list logo
