[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:86 +"int j;\n" +"}// namespace A::M", +fixNamespaceEndComments("#define M(x) x##x\n" MyDeveloperDay wrote: > same here its not

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu updated this revision to Diff 412856. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/Form

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413109. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/For

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > Is t

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > zequ

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413139. zequanwu marked 2 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/Format/Namesp

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5705767aad: [clang-format] fix namepsace format when the name is macro expansion (authored by zequanwu). Repository: rG LLVM Github Monorepo CH

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

zequanwu created this revision. zequanwu added reviewers: thakis, phosek. Herald added subscribers: jansvoboda11, dang. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let clang-cl accepts `-ffile-compilation-dir` flag. Repositor

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu abandoned this revision. zequanwu added a comment. This overlaps with the functionality of attribute `used`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move nomerge attribute from function declaration/definition to callsites to allow virtual function calls

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGe53bbd99516f: [IR] move nomerge attribute from function declaration/definition to callsites (authored by zequanwu). Changed prior to commit: https://reviews.ll

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix PR48687. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94646 Files: clang/lib/Sema/SemaTemp

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = &A::value; +}; +extern template class A; +template class A; I tri

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316694. zequanwu added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/CodeGenCXX/mi

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = &A::value; +}; +extern template class A; +template class A; zequa

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316695. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files: clang/lib/Sema/S

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fffbc150cca: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization. (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu created this revision. zequanwu added reviewers: rnk, phosek. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we only delete lines that are outer block statements (if, while, etc), clang-format-diff.py can't format the

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu added a comment. In D111273#3047759 , @hans wrote: > Are there no tests for clang-format-diff.py? That seems unfortunate. No test for clang-format-diff.py. > Will this handle more nested cases, for example if the first line here is > deleted,

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu updated this revision to Diff 378291. zequanwu added a comment. Fix the same error in git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111273/new/ https://reviews.llvm.org/D111273 Files: clang/tools/clang-format/clang-for

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93169226a29: [clang-format-diff] Fix missing formatting for zero length git diff lines (authored by zequanwu). Repository: rG LLVM Github Monorep

<    1   2   3   4   5