[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5246 + + if (const auto *ICE = dyn_cast(Arg->IgnoreParens())) { +if (const auto *DR = dyn_cast(ICE->getSubExpr())) { sfertile wrote: > Nit: To avoid the deep nesting, can we instead h

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 413818. ZarkoCA added a comment. - Restructured checks - fixed comment - removed unnecessary parameter passed to function - slightly reworded summary of patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5255 + const auto *PVD = dyn_cast( + (dyn_cast( + (dyn_cast(Arg->IgnoreParens()))->getSubExpr())) sfertile wrote: > I find these l

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA created this revision. ZarkoCA added reviewers: PowerPC, clang, cebowleratibm, hubert.reinterpretcast, bmahjour. ZarkoCA added projects: clang, PowerPC. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Currently when including stdbool.h and altivec.h decl

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 343656. ZarkoCA added a comment. - update test cases to contain `_Bool` as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files: clang/include/clang/Parse/Par

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; nemanjai wrote: > Do we not want the test case to provide a similar define to what `stdbool.h`

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, cebowleratibm, sfertile. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default Altivec ABI was implem

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344078. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Simplify option logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/l

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344080. ZarkoCA added a comment. - Fix previous diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1854 const Option &O = A->getOption(); -if (O.matches(OPT_mabi_EQ_vec_default)) - Diags.Report(diag::err_aix_default_altivec_abi) -

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 344426. ZarkoCA edited the summary of this revision. ZarkoCA added reviewers: uweigand, neumannh. ZarkoCA added a comment. - clean up code per comments - Add test case for Z targets since that target is also affected Repository: rG LLVM Github Monorepo CH

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751001 , @uweigand wrote: > This means the implementation now deviates from the documented vector > extension syntax, right? I guess it's strictly an extension of the > documented syntax, but that may still lead to

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2750930 , @Everybody0523 wrote: > Minor nitpick, but is there a term that encompasses both the Z Vector syntax > and altivec? Since the test checks both Z and PPC it's a little odd that the > test's filename only ref

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751160 , @uweigand wrote: > In D102064#2751089 , @ZarkoCA wrote: > >> In D102064#2751001 , @uweigand >> wrote: >> >>> This means the

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, hubert.reinterpretcast, sfertile, Xiangling_L, etiotto. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we are not using vector code `-maltivec` should not b

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA updated this revision to Diff 317936. ZarkoCA added a comment. Readd test for mabi=vec-default. Add -mcpu=pwr8 to AIX specific test case invocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94986/new/ https://reviews.llvm.org/D94986

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA marked 3 inline comments as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/altivec.c:13 // RUN: not %clang -S -emit-llvm -maltivec -target powerpc64-unknown-aix %s 2>&1 | FileCheck %s --check-prefix=AIX-ERROR -// RUN: not %clang -S -emit-llvm -mabi

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 369112. ZarkoCA added a comment. Rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/aix32-co

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +addSystemInclude(DriverArgs, CC1Args, PathCPP.str()); +CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__"); +return; Maybe a comment as to why we need this, somethin

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INCL

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + sfertile wrote: > The code-gen for int and float

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + ZarkoCA wrote: > sfertile wrote: > > The code-ge

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 372736. ZarkoCA added a comment. - Removed llc tests - Added a helper function to combine the PPC64_SVR4ABI and AIXABI treatment of complex types less than register size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added a comment. In D106393#3000122 , @sfertile wrote: > I suggest we separate the clang change and testing into a standalone patch, > and the llvm backend tests into a standalone patch which we can commit > separately. LLVM tests added in http

<    1   2   3