[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

This revision was automatically updated to reflect the committed changes. Closed by commit rG95c0125f2bc6: [Clang][RISCV] Add rvv vsetvl and vsetvlmax intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:700 +for (auto Idx : CTypeOrder) { + if (Seen.count(Idx)) +PrintFatalError( craig.topper wrote: > You can use > > ``` > if

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai, evandro. Herald added subscribers: vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc2

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332307. khchen added a comment. Remove half type in TypeList. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332341. khchen added a comment. update tests, remove target-feature zfh. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 Files: clang/include/clang/Basic/riscv_vector.

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGab082b582dd0: [RISCV][NFC] Fix RVV intrinsic tests. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. I need to take a look why Buildbot run failed: https://lab.llvm.org/buildbot/#/builders/139/builds/1615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082 _

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. In D99082#2643322 , @jrtc27 wrote: > Most likely because you're adding assembly tests in Clang, which won't work > if the backend isn't present (and needs a REQUIRES line). Assembly tests in > Clang are generally bad practice and

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332660. khchen marked 8 inline comments as done. khchen added a comment. 1. address Craig's comments. 2. add 'REQUIRES: riscv-registered-target' for tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG88c2d4c8eb0e: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions. (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D98848?vs=332660&id=332850#toc Repository: rG LLV

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 332852. khchen added a comment. Fix unintended change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99189/new/ https://reviews.llvm.org/D99189 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Hea

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen added a comment. maybe we could merge different test into one vleff.c? Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:11 // ASM-NOT: warning -#include +#include liaolucy wrote: > riscv_vector_overloaded.h ? Sorry, I forget to have a di

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 333298. khchen marked an inline comment as done. khchen added a comment. Emit riscv_vector_overloaded.h into riscv_vector.h Remove riscv_vector_overloaded.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99189/new

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 333486. khchen added a comment. remove riscv_vector_overloaded.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99189/new/ https://reviews.llvm.org/D99189 Files: clang/include/clang/Basic/riscv_vector.td cla

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG821547cabb58: [RISCV][Clang] Update new overloading rules for RVV intrinsics. (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D99189?vs=333486&id=333727#toc Repository: rG LLV

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99525: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen added a comment. So sorry.. those huge tests make the browser so slowly, should I split them in the different patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99524/new/ https://reviews.llvm.org/D99524 _

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen updated this revision to Diff 334164. khchen added a comment. 1. Address Craig's comments. 2. I didn't add common class for shift instruction. I will add it when we add other shift instruction which have the same argments. Does it make sense? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334178. khchen added a comment. Create a common class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td clang/test/Co

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

khchen updated this revision to Diff 334188. khchen added a comment. Create a common class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99528/new/ https://reviews.llvm.org/D99528 Files: clang/include/clang/Basic/riscv_vector.td clang/test/Co

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

khchen updated this revision to Diff 334205. khchen added a comment. [NFC] move class position. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99528/new/ https://reviews.llvm.org/D99528 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D99610: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 334644. khchen added a comment. Fix vfrdiv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35 +vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) { + return vwadd_vx(op1, op2, vl); +} craig.topper wrote: > Why do scalars require _w

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334647. khchen added a comment. Address Craig's comments. Sorry for a lot of typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/ri

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334648. khchen added a comment. update missed part for Log2LMUL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td cla

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 334659. khchen added a comment. rebase and refine multiclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c05609e0d5: [RISCV][Clang] Add some RVV Integer intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99524/new/ https:

[PATCH] D99525: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a18ea01f197: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions. (authored by khchen). Changed prior to commit: https://reviews.ll

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe252b509ee6: [RISCV][Clang] Add more RVV Integer intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D99610: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2a3601aa5a5: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CH

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35 +vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) { + return vwadd_vx(op1, op2, vl); +} khchen wrote: > craig.topper wrote: > > Why do

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:315 +multiclass RVVFloatingWidenTerBuiltinSet { + let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in { +defm "" : RVVOutOp1Op2BuiltinSet

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 335840. khchen added a comment. align implementation to https://github.com/riscv/rvv-intrinsic-doc/pull/77. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clan

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 335846. khchen marked 4 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 Files: clang/include

[PATCH] D100074: [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100074/new/ https://reviews.llvm.org/D100074 __

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 336100. khchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 336101. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 336117. khchen added a comment. rebase. I don't know why `let` cannot overide field when we change instantiate single multiclasses to inheritance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

khchen updated this revision to Diff 336123. khchen added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99964/new/ https://reviews.llvm.org/D99964 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv

[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:594 auto PType = Transformer.back(); + static unsigned NFCount = 0; switch (PType) { rogfer01 wrote: > Was this meant to be `static` here? Maybe we can create a new complex ty

[PATCH] D100127: [RISCV][Clang] Add some RVV Permutation intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99151/new/ https://reviews.llvm.org/D99151 ___

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

khchen updated this revision to Diff 33. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99965/new/ https://reviews.llvm.org/D99965 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccc624bfd417: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG007ea0e73643: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98a3ff9d0525: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc680b0dabf36: [RISCV][Clang] Add all RVV Reduction intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5a821926407: [RISCV][Clang] Add more RVV load/store intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99965/new/ htt

[PATCH] D100127: [RISCV][Clang] Add some RVV Permutation intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59d5b8c27b43: [RISCV][Clang] Add some RVV Permutation intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1001 +["x", "Uv", "UvUe"]]>; +} Jim wrote: > I am not sure that indent is needed inside let expression. In some cases, it > don't have inden

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. > The fact that we're running the optimization pipeline in these tests might be > to blame. Might also be that riscv_vector.h is currently about 71000 lines > which probably isn't quick to parse. I found removing all overloaded api definition functions in `riscv_vector.h

[PATCH] D100617: [RISCV][Clang] Drop the assembly tests for RVV intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. In D99741#2694344 , @thakis wrote: > Was there any more progress on this? If not, let's revert for now to not > permanently slow down tests by over 20%. https://reviews.llvm.org/D100611 https://reviews.llvm.org/D100617 Do you mea

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. In D99741#2694435 , @thakis wrote: > In D99741#2694369 , @khchen wrote: > >> In D99741#2694344 , @thakis wrote: >> >>> Was there any more progress on

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:749 + foreach type = type_list in +foreach eew_list = [["8", "(Log2EEW:3)"], ["16", "(Log2EEW:4)"], +["32", "(Log2EEW:5)"], ["64", "(Log2EEW:6)"]] in { ---

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1304 +// Reinterpret between different SEW under the same LMUL +foreach dst_sew = ["(FixedLog2SEW:3)", "(FixedLog2SEW:4)", "(FixedLog2SEW:5)", + "(FixedLog2SEW:6)"]

[PATCH] D100658: [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins.

khchen added a comment. I think you also need to handle `PermuteOperands` field ? `PermuteOperands` performs the order permutation for non-masked and masked intrinsics when the operand order is diff

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Look good to me. BTW, we also need to update the document later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm

[PATCH] D100658: [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100658/new/ https://reviews.llvm.org/D100658 __

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Please remove the ASM check in upstream patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/ https://reviews.llvm.org/D10044

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Is it okay to you? @kito-cheng @frasercrmck This patch could fix https://bugs.llvm.org/show_bug.cgi?id=49962, I hope this could be merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -triple riscv32 -target-feature +f -target-feature +d -target-feature +experimental-v \ +// RUN: -target-feature +exp

[PATCH] D94403: [RISCV] Implement new architecture extension macros

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, HsiangKai, evandro, liaolucy, arcbbb, monkchiang. Herald added subscribers: dexonsmith, NickHung, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoul

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. Really thanks for @jrtc27 and @craig.topper 's review suggestions. Before I upload the patch, I would want to discuss about the test generator, because if we don't want to upstream it, I don't need to fix some issues which are addressed by reivewers. @asb @jrtc27 @craig.

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 317916. khchen added a comment. address reviewer's suggestion, do not include test generator related part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 317919. khchen added a comment. apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/include/c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 318102. khchen marked 74 inline comments as done. khchen added a comment. 1. use exponent LMUL. 2. address @Paul-C-Anagnostopoulos 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://rev

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. marked some inline comments as done except the test generator related part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 ___ cfe-commit

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111597/new/ https://reviews.llvm.org/D111597 __

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2089 else return Error(ValueExprLoc, "bad arch string " + Arch); } maybe we could have a NFC patch later to add ``` // Emit the arch string if needed. if

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

khchen accepted this revision. khchen added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112020/new/ https://reviews.llvm.org/D112020 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:120 // type transformer (say "vv") each of the types is separated with an // underscore as in "__builtin_rvv_foo_i32m1_i32m1". // nit: we need to update this comment. Reposit

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

khchen added a comment. LGTM, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

<    1   2   3